AI_Assistant/pcbjam
Watch
1
0
Fork
You've already forked pcbjam
 0
Code Issues Pull requests Projects Releases 4 Packages Wiki Activity Actions 2

test(eeschema): drop obsolete test.fail on crosshair cycle

Browse source 
The crosshair toolbar group-cycle (ACTION_TOOLBAR::onToolEvent) was
expected-to-fail because the kicad submodule was a pre-10.0 (9.99.0)
snapshot that lacked it. The KiCad 10.0.4 rebase on this branch restores
the behavior, so the test now passes and Playwright flagged it as
"Expected to fail, but passed". Remove the test.fail annotation as the
test's own comment instructed.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Istvan Matejcsok 2026-06-24 10:31:22 +02:00
commit 40629fe9b5
1 changed files with 0 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

7
tests/kicad/eeschema-crosshair.spec.ts
View file

@ -179,13 +179,6 @@ test.describe('Eeschema crosshair modes', () => {
// generically by tests/e2e/popup.spec.ts. Each click advances the group's selected action;
// the tooltip + the rendered crosshair both change.
test('crosshair toolbar button cycles small -> full -> 45 on click', async ({ page, testLogger }) => {
// Click-to-cycle is upstream KiCad's ACTION_TOOLBAR::onToolEvent behavior. This branch's
// kicad submodule is a pre-10.0 (9.99.0) snapshot that predates it, so the cycle is
// absent until the kicad submodule is rebased onto master. Expected-to-fail until then;
// remove this line once the rebase lands (Playwright will flag it as "unexpectedly
// passed", reminding us to drop the annotation).
test.fail(true, 'needs upstream ACTION_TOOLBAR::onToolEvent cycle (kicad rebase onto master)');
await completeWizard(page);
await hideCursor(page);