From 40629fe9b5c83eaa10b34b16d2d6d5b5ffbe4126 Mon Sep 17 00:00:00 2001 From: Istvan Matejcsok <119620946+matejcsok-ee@users.noreply.github.com> Date: Wed, 24 Jun 2026 10:31:22 +0200 Subject: [PATCH] test(eeschema): drop obsolete test.fail on crosshair cycle The crosshair toolbar group-cycle (ACTION_TOOLBAR::onToolEvent) was expected-to-fail because the kicad submodule was a pre-10.0 (9.99.0) snapshot that lacked it. The KiCad 10.0.4 rebase on this branch restores the behavior, so the test now passes and Playwright flagged it as "Expected to fail, but passed". Remove the test.fail annotation as the test's own comment instructed. Co-Authored-By: Claude Opus 4.8 (1M context) --- tests/kicad/eeschema-crosshair.spec.ts | 7 ------- 1 file changed, 7 deletions(-) diff --git a/tests/kicad/eeschema-crosshair.spec.ts b/tests/kicad/eeschema-crosshair.spec.ts index c56a3db..0786f0e 100644 --- a/tests/kicad/eeschema-crosshair.spec.ts +++ b/tests/kicad/eeschema-crosshair.spec.ts @@ -179,13 +179,6 @@ test.describe('Eeschema crosshair modes', () => { // generically by tests/e2e/popup.spec.ts. Each click advances the group's selected action; // the tooltip + the rendered crosshair both change. test('crosshair toolbar button cycles small -> full -> 45 on click', async ({ page, testLogger }) => { - // Click-to-cycle is upstream KiCad's ACTION_TOOLBAR::onToolEvent behavior. This branch's - // kicad submodule is a pre-10.0 (9.99.0) snapshot that predates it, so the cycle is - // absent until the kicad submodule is rebased onto master. Expected-to-fail until then; - // remove this line once the rebase lands (Playwright will flag it as "unexpectedly - // passed", reminding us to drop the annotation). - test.fail(true, 'needs upstream ACTION_TOOLBAR::onToolEvent cycle (kicad rebase onto master)'); - await completeWizard(page); await hideCursor(page);