AI_Assistant/pcbjam
Watch
1
0
Fork
You've already forked pcbjam
 0
Code Issues Pull requests Projects Releases 4 Packages Wiki Activity Actions 2

test(3d): npm run 3d:review — triptychs/heatmaps for ALL pairs, not just changed

Browse source 
compare-dirs gains --artifacts changed|always: 'always' also writes the
side-by-side triptych + heatmap for pairs that PASS the floor (blue-grey
UNCHANGED caption), so a human can eyeball old-vs-new without a failing
gate. The gating scripts keep the default (empty diff dir = green);
3d:review writes the full 47-pair set to output/diff/parity-review/.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Istvan Matejcsok 2026-07-03 15:25:51 +02:00
commit 2aa7657c64
3 changed files with 22 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

21
tests/tools/screenshots/compare-dirs.ts
View file

@ -60,6 +60,7 @@ function parseArgs(argv: string[]): Record<string, string | boolean> {
else if (a === '--floor') out.floor = argv[++i];
else if (a === '--label') out.label = argv[++i];
else if (a === '--fail-on-change') out.failOnChange = true;
else if (a === '--artifacts') out.artifacts = argv[++i];
else {
console.error(`[compare-dirs] unknown argument: ${a}`);
process.exit(2);
@ -72,7 +73,8 @@ function usageError(msg: string): never {
console.error(`[compare-dirs] ${msg}`);
console.error(
'[compare-dirs] usage: --old <dir> --new <dir> --out <dir> ' +
'[--floors <json> --level <level>] [--floor <ratio>] [--fail-on-change] [--label <text>]'
'[--floors <json> --level <level>] [--floor <ratio>] [--fail-on-change] [--label <text>] ' +
'[--artifacts changed|always]'
);
process.exit(2);
}
@ -131,7 +133,12 @@ function main(): void {
unchangedCount: 0,
};
const caption = (status: 'added' | 'removed' | 'changed', name: string) => labelText(status, name, label);
const artifacts = (args.artifacts as string) || 'changed';
if (artifacts !== 'changed' && artifacts !== 'always')
usageError(`--artifacts must be "changed" or "always", got "${artifacts}"`);
const caption = (status: 'added' | 'removed' | 'changed' | 'unchanged', name: string) =>
labelText(status, name, label);
for (const name of oldNames) {
if (!newNames.has(name)) {
@ -155,6 +162,16 @@ function main(): void {
const { result, heatmap, triptych } = pair;
if (result.verdict === 'unchanged') {
report.unchangedCount++;
// Review mode: keep the triptych/heatmap for passing pairs too, so a
// human can eyeball old-vs-new side by side without a failing gate.
if (artifacts === 'always') {
const triptychPath = path.join(outDir, `${name}.triptych.png`);
savePng(triptychPath,
withBottomLabel(triptych, caption('unchanged', name), LABEL.colors.unchanged));
savePng(path.join(outDir, `${name}.heatmap.png`), heatmap);
}
continue;
}
const triptychPath = path.join(outDir, `${name}.triptych.png`);

3
tests/tools/screenshots/config.ts
View file

@ -103,10 +103,11 @@ export const LABEL = {
added: [46, 125, 50] as [number, number, number], // green
removed: [198, 40, 40] as [number, number, number], // red
changed: [239, 108, 0] as [number, number, number], // orange
unchanged: [69, 90, 100] as [number, number, number], // blue-grey (review-only artifacts)
},
};
export type LabelStatus = 'added' | 'removed' | 'changed';
export type LabelStatus = 'added' | 'removed' | 'changed' | 'unchanged';
/** Caption text: `CHANGED name.png · kicad/pcbnew.spec.ts` (spec omitted if unknown). */
export function labelText(status: LabelStatus, name: string, spec: string | null): string {