AI_Assistant/cad-editor
Watch
1
0
Fork
You've already forked cad-editor
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: correct yaw recovery from view_direction vector

Browse source 
view_dir = rotation * Z = (sin(yaw)*cos(pitch), -cos(yaw)*cos(pitch), sin(pitch))
so yaw = atan2(x, -y), not atan2(x, y).
The sign error caused a 180-degree Z rotation on every save/reload cycle.
Applies to apply_active_vport_camera, apply_sheet_viewport_camera, and
camera_for_viewport.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Hakan Seven 2026-05-01 07:20:55 +03:00
commit 35e487934c
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/scene/mod.rs
View file

@ -2400,7 +2400,7 @@ impl Scene {
.normalize_or(glam::Vec3::Z); .normalize_or(glam::Vec3::Z);
let pitch = vd.z.clamp(-0.999, 0.999).asin(); let pitch = vd.z.clamp(-0.999, 0.999).asin();
let yaw = vd.x.atan2(vd.y); let yaw = vd.x.atan2(-vd.y);
let rotation = camera::yaw_pitch_to_quat(yaw, pitch); let rotation = camera::yaw_pitch_to_quat(yaw, pitch);
let view_right = rotation * glam::Vec3::X; let view_right = rotation * glam::Vec3::X;
let view_up = rotation * glam::Vec3::Y; let view_up = rotation * glam::Vec3::Y;
@ -2463,7 +2463,7 @@ impl Scene {
.normalize_or(glam::Vec3::Z); .normalize_or(glam::Vec3::Z);
let pitch = vd.z.clamp(-0.999, 0.999).asin(); let pitch = vd.z.clamp(-0.999, 0.999).asin();
let yaw = vd.x.atan2(vd.y); let yaw = vd.x.atan2(-vd.y);
let rotation = camera::yaw_pitch_to_quat(yaw, pitch); let rotation = camera::yaw_pitch_to_quat(yaw, pitch);
let view_right = rotation * glam::Vec3::X; let view_right = rotation * glam::Vec3::X;
let view_up = rotation * glam::Vec3::Y; let view_up = rotation * glam::Vec3::Y;
@ -2721,7 +2721,7 @@ impl Scene {
.normalize_or(glam::Vec3::Z); .normalize_or(glam::Vec3::Z);
let pitch = vd.z.clamp(-0.999, 0.999).asin(); let pitch = vd.z.clamp(-0.999, 0.999).asin();
let yaw = vd.x.atan2(vd.y); let yaw = vd.x.atan2(-vd.y);
let rotation = camera::yaw_pitch_to_quat(yaw, pitch); let rotation = camera::yaw_pitch_to_quat(yaw, pitch);
let view_right = rotation * glam::Vec3::X; let view_right = rotation * glam::Vec3::X;