AI_Assistant/cad-editor
Watch
1
0
Fork
You've already forked cad-editor
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: increment camera_generation on orbit/pan/zoom to trigger dirty sync

Browse source 
Direct camera.orbit/pan/zoom calls in update.rs bypassed camera_generation
so the Tick handler never detected a change and never wrote the camera back
to the document. Add camera_generation += 1 after each navigation call.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Hakan Seven 2026-05-01 07:16:58 +03:00
commit 05dd23a8dc
1 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/app/update.rs
View file

@ -1085,8 +1085,11 @@ impl H7CAD {
self.tabs[i].scene.orbit_active_viewport(dx, dy);
return Task::none();
} else {
self.tabs[i].scene.camera.borrow_mut().orbit(dx, dy);
sel.right_last_pos = Some(p);
drop(sel);
self.tabs[i].scene.camera.borrow_mut().orbit(dx, dy);
self.tabs[i].scene.camera_generation += 1;
return Task::none();
}
} else {
sel.right_last_pos = Some(p);
@ -1106,6 +1109,7 @@ impl H7CAD {
self.tabs[i].scene.pan_active_viewport(dx, dy, bounds);
} else {
self.tabs[i].scene.camera.borrow_mut().pan(dx, dy);
self.tabs[i].scene.camera_generation += 1;
}
self.tabs[i].scene.selection.borrow_mut().middle_last_pos = Some(p);
return Task::none();
@ -1826,6 +1830,8 @@ impl H7CAD {
} else {
cam.zoom(s);
}
drop(cam);
self.tabs[i].scene.camera_generation += 1;
}
Task::none()
}