pcbjam/tests/e2e/dataviewvirtual.spec.ts
Viktor Vaczi 4c3a4cacd4 test(determinism): deterministic waits + stableShot screenshots; drop blind sleeps/ifs/retries
Make the Playwright e2e + kicad suites deterministic so screenshot flake stops
tracing to timing races.

- Blind page.waitForTimeout -> condition waits (expect.poll, web-first
  assertions, waitUntil) + readiness helpers (waitForWxApp, waitForCanvasApp).
  Remaining sleeps are documented interaction dwells (annotated).
- Defensive "if element exists" branches -> loud asserts; label-fallback chains
  -> normalized clickMenuItemByText. First-run wizard for/if loops removed by
  seeding calculator/gerbview/pcbnew HTMLs.
- Screenshots: new stableShot(page, name) settles the render in-page (canvas
  hash over rAF) then writes a raw PNG to test-results/ for the existing offline
  gate (tools/screenshots vs baseline-screenshots). Replaces toHaveScreenshot,
  which did inline compare + its own baselines and had decoupled the specs from
  the real gate. scale:'css' pinned.
- retries: 0 in both configs.
- Guard: tests/tools/lint-determinism.ts (npm run lint:determinism) bans blind
  sleeps / toHaveScreenshot / inline retries / swallowed catches in specs;
  documented exceptions carry a marker. Rules in tests/TESTING.md.

Assertions, coverage, and renders unchanged (semantic-equivalence reviewed;
captures pixel-identical modulo inherent timer/timestamp/3d-raytrace variance).
Both suites green at retries:0 (e2e 340, kicad 92); ~35-61% faster.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BVX1pHMvRPYHdp6ZfEawrk
2026-07-07 10:50:24 +02:00

64 lines
2.7 KiB
TypeScript

// wxDataViewCtrl Virtual Mode Tests - Zone Manager/Net Inspector simulation
import { test, expect, waitForWxApp } from './utils/fixtures';
import { clickByLabel, findAllRenderedByLabel, clickDataViewItemByIndex, clickDataViewItem, stableShot } from './utils/element-tracker';
test.describe('wxDataViewCtrl Virtual Mode Tests', () => {
test('DataViewVirtual test app loads successfully', async ({ page, testLogger }) => {
await page.goto('/standalone/dataviewvirtual/dataviewvirtual_test.html');
await waitForWxApp(page);
await stableShot(page, 'dataviewvirtual-01-loaded.png', { fullPage: true });
expect(testLogger.errors.filter(e => !e.includes('favicon'))).toHaveLength(0);
});
test('Virtual list handles large datasets', async ({ page, testLogger }) => {
await page.goto('/standalone/dataviewvirtual/dataviewvirtual_test.html');
await waitForWxApp(page);
// Click 10,000 button to test large dataset using element registry
const clicked = await clickByLabel(page, '10,000');
expect(clicked, '10,000 button should be found').toBe(true);
await stableShot(page, 'dataviewvirtual-02-large-dataset.png', { fullPage: true });
const hasVirtualLog = testLogger.consoleLogs.some(l =>
l.includes('virtual') || l.includes('10,000') || l.includes('DATAVIEW'));
});
test('Virtual list scrolling works', async ({ page, testLogger }) => {
await page.goto('/standalone/dataviewvirtual/dataviewvirtual_test.html');
await waitForWxApp(page);
// Click Middle button using element registry
const clicked = await clickByLabel(page, 'Middle');
expect(clicked, 'Middle button should be found').toBe(true);
await stableShot(page, 'dataviewvirtual-03-scroll.png', { fullPage: true });
});
test('Virtual list selection works', async ({ page, testLogger }) => {
await page.goto('/standalone/dataviewvirtual/dataviewvirtual_test.html');
await waitForWxApp(page);
// Click on an item in the list using element registry
// Virtual list items have labels like "NET_00000", "NET_00001", etc.
const clicked = await clickDataViewItemByIndex(page, 0);
expect(clicked).toBe(true);
await stableShot(page, 'dataviewvirtual-04-selection.png', { fullPage: true });
});
test('Zone manager panel works', async ({ page, testLogger }) => {
await page.goto('/standalone/dataviewvirtual/dataviewvirtual_test.html');
await waitForWxApp(page);
// Click in zone manager panel using element registry
// Zone items have labels like "Zone_000", "Zone_001", etc.
const clicked = await clickDataViewItem(page, 'Zone_000');
expect(clicked).toBe(true);
await stableShot(page, 'dataviewvirtual-05-zone-manager.png', { fullPage: true });
});
});