Squash of experiment/ff-big-modules vs main.
Big-module routing removed: native-EH shrank kicad_editor below
SpiderMonkey's x86-64 code budget (runs 29355049705/29356152413 green on
stock Firefox), so BIG_MODULE_SPECS routing and the baseline-only-JIT
crutch are gone — kicad-firefox and kicad-chromium both run the full
suite, with the module compiled the way real users' browsers compile it.
Per-engine screenshots end to end: stableShot/shotPath write
test-results/<engine>/<name>.png; baselines move to
baseline-screenshots/{chromium,firefox}/ and the whole tools/screenshots
pipeline (compare/promote/manifest/spec-map/changelog/Discord) keys on
<engine>/<name>. Previously Firefox and Chromium renders of one spec
overwrote each other and Firefox renders were never actually gated.
Seeded from CI run 29421380806 (92 new firefox baselines, +24 chromium
web-suite shots); manifest generated from the baseline tree.
One merged playwright.config.ts (kicad/asyncify/coroutine/perf as
projects); ~25 dead npm scripts dropped. The web suite is gated in CI for
the first time ever (4 rotted specs fixed, 5 broken lib-bridge specs
triaged as fixme in docs/features/web-e2e-rot/); cheap lint step after
npm ci; last 26 blind-sleep violations fixed.
SwiftShader retired: CI Chromium renders WebGL on ANGLE → Mesa llvmpipe
(--use-gl=angle --use-angle=gl --ignore-gpu-blocklist; the blocklist flag
is mandatory — llvmpipe is blocklisted and WebGL is silently unavailable
without it) in BOTH configs. Under WORKERS=4 congestion SwiftShader
transiently failed the first post-board-load draw and the recovery
cascade ended in a silent permanent Cairo fallback — that engine flip was
the "~1.2% changedRatio both directions" occ-export baseline flake.
Validated 160/160 across two 80-repeat rigs; full analysis in
docs/features/wx-parity-bugs/occ-export-context-eviction.md. Chromium
baselines shift slightly on llvmpipe — promote once from the first green
run. Deflakes the new coverage exposed: presence baselines settle before
capture; presence fixtures declare current file formats; perf gets its
own outputDir so CI evidence survives; occ-export settles the board paint
before the export dialog; menu-item waits (waitForRenderedByLabel before
clickMenuItem) in 4 specs + the TESTING.md rule.
Web suite runs the PROD build, in parallel: webServer becomes backend
`start` + the standalone's e2e:preview (build-preview.mjs: link-wasm →
stash the public/wasm symlink aside during vite build, build-demo.mjs's
move — then vite preview as the persistent server). The wasm middleware
serves /wasm/* in preview and emits COOP/COEP/CORP itself (a pthread
worker script's own response must carry COEP or Chrome kills it with
ERR_BLOCKED_BY_RESPONSE). VITE_* flags bake at build time;
VITE_ALLOW_USER_OVERRIDE joins turbo globalEnv. fullyParallel + default
workers: 5.2m → 1.4m. Determinism fixes the parallel run exposed:
shared-page specs become serial groups; locks.spec grabs alice's exact
item via the new kicadCollabTestSelectByUuid hook (cross-tab "first
footprint" order is not a ysync invariant); quit specs poll page.url()
(quit supersedes its own navigation — NS_BINDING_ABORTED on Firefox).
Suite: 51 passed / 12 skipped / 0 failed in 1.6m.
CI-coverage gate (lint:ci-coverage): every tests/**/*.spec.ts must be
reachable from the npm scripts the workflows invoke — scraped from
.github/workflows/, resolved through package.json, coverage asked from
playwright --list itself. Rules: uncovered-spec + orphan-project (with a
documented LOCAL_ONLY_PROJECTS allowlist). Gating next to
lint:determinism; 138 spec files / 13 projects accounted for.
Product fixes kept from the investigations (reachable on real GPUs too):
wx 7799fd1be5 — paint flags clear before dispatch + Invalidate always
propagates; kicad 3dcfea5e45 — SwiftShader pass-boundary flush +
per-instance font texture + first-frame GL-error drain (GAL recovery
recovers instead of falling back to Cairo) + the user-facing eeschema
switch navigates again under __EMSCRIPTEN__ (project-sync's
FaceRegistered gate had rerouted it into the hidden sync player; caught
by the newly-gated web suite).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018eUxiPApHgGiu9NFyQfhAq
237 lines
7.3 KiB
TypeScript
237 lines
7.3 KiB
TypeScript
import type { Page } from "@playwright/test";
|
|
import { test, expect } from "./fixtures";
|
|
|
|
/**
|
|
* eeschema selection soft-locks — C++ veto e2e (collab-presence 0007).
|
|
* Mirror of presence-locks-pcbnew.spec.ts: eeschema has NO native item-lock
|
|
* plumbing (the itemPassesFilter lock branch is #if 0), so the veto rides the
|
|
* pcbjam remote-lock check in narrowSelection's aCheckLocked path — a real
|
|
* drag gesture on a locked wire must not move it, the same gesture moves it
|
|
* unlocked, and ReleaseSelection strips exactly the contested uuid.
|
|
*/
|
|
|
|
const WIRE1 = "22222222-0000-0000-0000-000000000001";
|
|
const SAMPLE_SCH = `(kicad_sch
|
|
\t(version 20250114)
|
|
\t(generator "eeschema")
|
|
\t(generator_version "9.0")
|
|
\t(uuid "11111111-1111-1111-1111-111111111111")
|
|
\t(paper "A4")
|
|
\t(lib_symbols)
|
|
\t(wire (pts (xy 50.8 50.8) (xy 101.6 50.8)) (stroke (width 0) (type default)) (uuid "${WIRE1}"))
|
|
\t(wire (pts (xy 50.8 76.2) (xy 101.6 76.2)) (stroke (width 0) (type default)) (uuid "22222222-0000-0000-0000-000000000002"))
|
|
\t(sheet_instances (path "/" (page "1")))
|
|
)
|
|
`;
|
|
|
|
type FS = { mkdirTree(p: string): void; writeFile(p: string, d: string): void };
|
|
type Mod = {
|
|
kicadOpenFile(p: string): unknown;
|
|
kicadCollabPresenceStart(): void;
|
|
kicadCollabSetRemote(j: string): void;
|
|
kicadCollabGetViewport(): string;
|
|
kicadCollabGetSelection(): string;
|
|
kicadCollabGetPos(id: string): string;
|
|
kicadCollabReleaseSelection(uuidsJson: string, holder: string): void;
|
|
kicadCollabTestGetLocked(): string;
|
|
kicadCollabTestSelectFirst(): string;
|
|
};
|
|
type LocksWindow = {
|
|
FS: FS;
|
|
Module: Mod;
|
|
kicadCollab?: Record<string, unknown>;
|
|
};
|
|
|
|
function hasAbort(l: { consoleLogs: string[]; errors: string[] }): boolean {
|
|
return [...l.consoleLogs, ...l.errors].some((s) => s.includes("Aborted("));
|
|
}
|
|
|
|
async function bootAndOpen(page: Page): Promise<void> {
|
|
await page.goto("/kicad/eeschema.html");
|
|
await expect(page.locator("#canvas")).toBeVisible({ timeout: 90000 });
|
|
await page.waitForFunction(() => !!window.wxElementRegistry, null, { timeout: 90000 });
|
|
await page.waitForFunction(
|
|
() => {
|
|
const m = (window as unknown as { Module?: Partial<Mod> }).Module;
|
|
return (
|
|
typeof m?.kicadOpenFile === "function" &&
|
|
typeof m?.kicadCollabTestGetLocked === "function"
|
|
);
|
|
},
|
|
null,
|
|
{ timeout: 90000 },
|
|
);
|
|
await page.waitForFunction(
|
|
() =>
|
|
!!window.wxElementRegistry &&
|
|
window.wxElementRegistry
|
|
.findAll({ visible: true })
|
|
.some((e) => /Frame$/.test(e.typeName) || (e.name || "").endsWith("Frame")),
|
|
null,
|
|
{ timeout: 90000 },
|
|
);
|
|
|
|
await page.evaluate(
|
|
({ content }) => {
|
|
const w = window as unknown as LocksWindow;
|
|
const dir = "/home/kicad/documents";
|
|
try {
|
|
w.FS.mkdirTree(dir);
|
|
} catch {
|
|
/* exists */
|
|
}
|
|
const p = `${dir}/locks.kicad_sch`;
|
|
w.FS.writeFile(p, content);
|
|
w.Module.kicadOpenFile(p);
|
|
},
|
|
{ content: SAMPLE_SCH },
|
|
);
|
|
|
|
await expect
|
|
.poll(() => page.title(), { timeout: 60000, intervals: [500] })
|
|
.toMatch(/locks/i);
|
|
|
|
await page.evaluate(() => {
|
|
(window as unknown as LocksWindow).Module.kicadCollabPresenceStart();
|
|
});
|
|
}
|
|
|
|
function setLock(page: Page, locked: boolean): Promise<void> {
|
|
return page.evaluate(
|
|
({ id, locked: isLocked }) => {
|
|
const w = window as unknown as LocksWindow;
|
|
w.Module.kicadCollabSetRemote(
|
|
JSON.stringify({
|
|
peers: [],
|
|
locks: isLocked ? [{ uuid: id, name: "bob" }] : [],
|
|
}),
|
|
);
|
|
},
|
|
{ id: WIRE1, locked },
|
|
);
|
|
}
|
|
|
|
const wirePos = (page: Page) =>
|
|
page.evaluate(() =>
|
|
(window as unknown as LocksWindow).Module.kicadCollabGetPos(
|
|
"22222222-0000-0000-0000-000000000001",
|
|
),
|
|
);
|
|
|
|
/** Screen position of the wire's stored (start) point via the GAL transform. */
|
|
async function wireScreenPos(page: Page): Promise<{ x: number; y: number }> {
|
|
const glId = await page.evaluate(() => {
|
|
const visible = Array.from(document.querySelectorAll('[id^="glcanvas-"]'))
|
|
.map((c) => c as HTMLCanvasElement)
|
|
.find(
|
|
(c) =>
|
|
window.getComputedStyle(c).display !== "none" &&
|
|
c.getBoundingClientRect().width > 0,
|
|
);
|
|
return visible?.id ?? null;
|
|
});
|
|
expect(glId).toBeTruthy();
|
|
const box = await page.locator(`#${glId}`).boundingBox();
|
|
expect(box).toBeTruthy();
|
|
|
|
const { vp, pos } = await page.evaluate(() => {
|
|
const w = window as unknown as LocksWindow;
|
|
return {
|
|
vp: JSON.parse(w.Module.kicadCollabGetViewport()),
|
|
pos: w.Module.kicadCollabGetPos("22222222-0000-0000-0000-000000000001"),
|
|
};
|
|
});
|
|
const [wx, wy] = pos.split(",").map(Number);
|
|
return {
|
|
x: box!.x + (wx - vp.cx) * vp.scale + vp.w / 2,
|
|
y: box!.y + (wy - vp.cy) * vp.scale + vp.h / 2,
|
|
};
|
|
}
|
|
|
|
async function dragFromWire(page: Page): Promise<void> {
|
|
const at = await wireScreenPos(page);
|
|
await page.mouse.move(at.x, at.y);
|
|
await page.mouse.down();
|
|
await page.mouse.move(at.x + 100, at.y + 60, { steps: 10 });
|
|
await page.mouse.up();
|
|
// The drag commit has no JS-observable in the VETOED (locked) case — the whole
|
|
// point is that NOTHING happens. Bounded chance for a slow wrongful move to
|
|
// surface before the caller's position assert; the unlocked control leg proves
|
|
// the gesture itself works via its own position poll.
|
|
await page.waitForTimeout(800); // eslint-disable-line -- documented interaction dwell: negative-assert window
|
|
}
|
|
|
|
test("a locked wire resists a real drag; the same drag moves it unlocked", async ({
|
|
page,
|
|
testLogger,
|
|
}) => {
|
|
test.setTimeout(240000);
|
|
await bootAndOpen(page);
|
|
|
|
await setLock(page, true);
|
|
await expect
|
|
.poll(() =>
|
|
page.evaluate(() =>
|
|
JSON.parse((window as unknown as LocksWindow).Module.kicadCollabTestGetLocked()),
|
|
),
|
|
)
|
|
.toEqual([{ uuid: WIRE1, name: "bob" }]);
|
|
|
|
const before = await wirePos(page);
|
|
expect(before).toBeTruthy();
|
|
await dragFromWire(page);
|
|
expect(await wirePos(page)).toBe(before);
|
|
|
|
// Control: unlocked, the same gesture moves/bends the wire.
|
|
await setLock(page, false);
|
|
await dragFromWire(page);
|
|
await expect
|
|
.poll(() => wirePos(page), {
|
|
timeout: 10000,
|
|
message: "control drag never moved the unlocked wire",
|
|
})
|
|
.not.toBe(before);
|
|
|
|
expect(hasAbort(testLogger)).toBe(false);
|
|
});
|
|
|
|
test("a locked wire stays selectable; ReleaseSelection strips it", async ({
|
|
page,
|
|
testLogger,
|
|
}) => {
|
|
test.setTimeout(240000);
|
|
await bootAndOpen(page);
|
|
await setLock(page, true);
|
|
|
|
// Inspection: programmatic select through the real tool still lands.
|
|
const id = await page.evaluate(() =>
|
|
(window as unknown as LocksWindow).Module.kicadCollabTestSelectFirst(),
|
|
);
|
|
expect(id).toBeTruthy();
|
|
await expect
|
|
.poll(() =>
|
|
page.evaluate(() =>
|
|
JSON.parse((window as unknown as LocksWindow).Module.kicadCollabGetSelection()),
|
|
),
|
|
)
|
|
.toContain(id);
|
|
|
|
// Tiebreak-loser path: release exactly that uuid.
|
|
await page.evaluate(
|
|
({ uuid }) =>
|
|
(window as unknown as LocksWindow).Module.kicadCollabReleaseSelection(
|
|
JSON.stringify([uuid]),
|
|
"bob",
|
|
),
|
|
{ uuid: id },
|
|
);
|
|
await expect
|
|
.poll(() =>
|
|
page.evaluate(() =>
|
|
JSON.parse((window as unknown as LocksWindow).Module.kicadCollabGetSelection()),
|
|
),
|
|
)
|
|
.toEqual([]);
|
|
|
|
expect(hasAbort(testLogger)).toBe(false);
|
|
});
|