pcbjam/tests/e2e/coroutine-pthread.spec.ts
Viktor Vaczi 9c475a804e jspi cleanup: remove the asyncify-era residue — dead code, conditionals, pipeline scaffolding, stale prose
The runtime is JSPI-only; this removes everything that still pretended
otherwise. Three exhaustive sweeps (C++/JS+build+CI/tests+docs) drove
the inventory; every deletion verified by grep closure + full gates.

Broken-right-now fixes:
- deploy-staging.yml passed the retired opt_level input — the workflow
  could not even start. Removed.
- env.sh carried dead exports with a live -sASYNCIFY=1 inside
  (WASM_LDFLAGS/PTHREAD_LDFLAGS, zero consumers). Removed; the
  WASM_LEGACY_EXCEPTIONS rationale rewritten to the real reason.
- docker/build.sh exported PCBJAM_ASYNC_BACKEND (read nowhere). Gone.

Dead weight removed:
- binaryen submodule (nothing builds or invokes it), wasm-opt-bench
  workflow + scripts/bench/, get-wasm-opt.sh, diagnostics.js (242 lines
  of Asyncify-API-only code), the KICAD_PIPELINE background-postprocess
  scaffolding (existed to parallelize the deleted wasm-opt phase; the
  postprocess is a seconds-long node script and now runs inline),
  build-monitor's dead asyncify rows, sched-context orphan build
  output, dead .gitignore entries, the .jspi-assets spike dir (the two
  wf-result research JSONs moved to docs/features/async/migration-evidence/).
- bindings: fiber_park.h + its 12 embind registrations (broken-if-
  called under JSPI), the kicadOpenFileStart/OPEN_JOB starter route,
  main_stack_runner.h + 5 includes, the always-null context-sleep weak
  hook in nanosleep_yield.c.
- shim: the backend field (installed-flag idempotency instead),
  noteContextWait (dead both sides), the __wxAsyncifyDump alias (+ the
  WasmTool fallback and string-dump normalize branch).
- web: the emscripten-6-ignored mainScriptUrlOrBlob option in boot.ts
  (gerber-demo keeps it: it loads the deployed CDN release, which
  predates emscripten 6 — noted inline).

Conditionals: all 'backend === jspi' checks reduced to scheduler-
presence checks; races_quiescent re-keyed from Asyncify.state (vacuous)
to real backlog quiescence (resumeReady/mutatorQueue — NOT _windowLive,
which is the probing activation's own window by definition).

Renames (identifiers only, no file renames): ASYNC_LINK_FLAGS→
JSPI_LINK_FLAGS and Makefile ASYNC_LDFLAGS→JSPI_LDFLAGS,
kicadCollabFiberBusy→kicadCollabBusy (embind + web + tests),
collab_common.h fiber*→apply*/coroutine naming, asyncifySignatures→
wasmTrapSignatures (lists byte-identical).

Tests: the two remaining vacuous [wx-asyncify]/fiber-resume-refused
asserts re-keyed to live JSPI beacons; eeschema-load's failure message
no longer sends the developer to a deleted script; wait-beacons' dead
families/parser deleted; lane-0 legacy-glue guards removed (lane 0 is
unconstructible); the embind test.fail re-gated with the JSPI reason
(plain embind invokers cannot suspend — verified still failing);
lint-determinism now scans tests/jspi (166 files clean);
eeschema-collab local-move gated to chromium (~50% flaky on FF even
solo; pcbnew twin covers both engines).

Docs: DEBUG.md rewritten as the JSPI debugging guide; build.md
describes the single-phase build; docs/features/async/README.md
banner-marked historical and repointed at the NEW
23-jspi-runtime.md (current architecture: export census, turnstile,
libcontext ownership + refusal contract, embind call shapes, the
em-pthread service-wrapper trick, exception policy, known gaps).

Gates on the cleaned tree: test:e2e 725 passed / 0 failed (after the
quiescence-probe fix; the 3 other reds were verified contention flakes
solo-green or the documented FF gate), web 76/0, jspi 18/18 both
engines, vitest 295/295 + 17/17, all lints green, live-app census
clean.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016X9eh1s5sTx1o9Em9KBuwR
2026-08-14 09:25:32 +02:00

157 lines
7.7 KiB
TypeScript

import { test, expect, tryLoadApp } from './utils/fixtures';
// Isolated reproduction probe for the KiCad Asyncify-fiber x pthreads Chrome crash.
// Loads main_repro.html (fiber Call/Yield/Resume in main(), built WITH pthreads, no wx).
// Firefox should print "[REPRO] DONE"; if system Chrome crashes before DONE, the crash
// is reproduced in isolation.
test.describe('Coroutine pthread main() reproduction', () => {
test('fiber-in-main + pthreads reaches DONE without renderer crash', async ({ page, testLogger }) => {
await page.goto('/standalone/coroutine-pthread/main_repro.html');
await tryLoadApp(page, 20000).catch(() => {}); // eslint-disable-line -- best-effort load in a pthread/coroutine runtime probe
await expect
.poll(() => testLogger.consoleLogs.some((l) => l.includes('[REPRO] DONE')), {
timeout: 30000,
message: 'should reach [REPRO] DONE (i.e. the main-context suspension chain survived)',
})
.toBe(true);
// Sanity: the coroutine body must actually have run (fiber entry wired up).
expect(
testLogger.consoleLogs.some((l) => l.includes('[REPRO] coroutine body running')),
'coroutine body should have executed'
).toBe(true);
});
// Probe #2: coroutine activated through nested JS<->wasm dynCall boundaries (KiCad's shape).
test('nested dynCall-boundary fiber reaches DONE without renderer crash', async ({ page, testLogger }) => {
await page.goto('/standalone/coroutine-pthread/nested_repro_ex.html');
await tryLoadApp(page, 20000).catch(() => {}); // eslint-disable-line -- best-effort load in a pthread/coroutine runtime probe
await expect
.poll(() => testLogger.consoleLogs.some((l) => l.includes('[REPRO] DONE')), {
timeout: 30000,
message: 'should reach [REPRO] DONE (the suspension chain through the dynCall boundaries survived)',
})
.toBe(true);
expect(
testLogger.consoleLogs.some((l) => l.includes('[REPRO] coroutine body running')),
'coroutine body should have executed'
).toBe(true);
});
// Probe #3: the full 13-scenario wx-event-loop harness, built WITH pthreads.
test('wx event loop + pthreads coroutine suite completes without renderer crash', async ({ page, testLogger }) => {
await page.goto('/standalone/coroutine-pthread/coroutine_test_wxpt.html');
await tryLoadApp(page, 30000).catch(() => {}); // eslint-disable-line -- best-effort load in a pthread/coroutine runtime probe
await expect
.poll(() => testLogger.consoleLogs.find((l) => l.includes('[COROUTINE_TEST] SUMMARY')) ?? null, {
timeout: 45000,
message: 'wx+pthreads suite should emit a SUMMARY line (no crash)',
})
.not.toBeNull();
const summary = testLogger.consoleLogs.find((l) => l.includes('[COROUTINE_TEST] SUMMARY'))!;
const m = summary.match(/total=(\d+)\s+passed=(\d+)\s+failed=(\d+)/);
expect(m, 'SUMMARY parseable').not.toBeNull();
expect(Number(m![3]), 'no failed cases').toBe(0);
});
// Probe #4: coroutine activated via an embind (--bind) call.
// Still an expected failure, for the JSPI-era reason (re-probed 2026-08-14):
// a PLAIN embind invoker is not a promising entry, so the coroutine's first
// suspension inside it cannot suspend the activation — the page never
// reaches DONE. The shipped app never uses this shape: suspending embind
// entries are either emscripten::async() + parker-wrapped (kicadOpenFile)
// or raw KEEPALIVE promising exports. Un-fail only if embind ever grows a
// true one-shot promising registration.
test.fail('embind-activated fiber reaches DONE without renderer crash', async ({ page, testLogger }) => {
await page.goto('/standalone/coroutine-pthread/embind_repro.html');
await tryLoadApp(page, 20000).catch(() => {}); // eslint-disable-line -- best-effort load in a pthread/coroutine runtime probe
await expect
.poll(() => testLogger.consoleLogs.some((l) => l.includes('[REPRO] DONE')), {
timeout: 30000,
message: 'should reach [REPRO] DONE (the suspension chain through the embind dispatch survived)',
})
.toBe(true);
expect(
testLogger.consoleLogs.some((l) => l.includes('ToolHost::activate')),
'embind activate should have run'
).toBe(true);
});
// Probe #5: coroutine activated inside an emscripten_set_main_loop (rAF) callback
// (the single JS->wasm boundary KiCad uses; matches "main-refresh" in the crash trace).
test('main-loop(rAF)-activated fiber reaches DONE without renderer crash', async ({ page, testLogger }) => {
await page.goto('/standalone/coroutine-pthread/mainloop_repro.html');
await tryLoadApp(page, 20000).catch(() => {}); // eslint-disable-line -- best-effort load in a pthread/coroutine runtime probe
await expect
.poll(() => testLogger.consoleLogs.some((l) => l.includes('[REPRO] DONE')), {
timeout: 30000,
message: 'should reach [REPRO] DONE (the suspension chain through the main-loop dynCall_v survived)',
})
.toBe(true);
expect(
testLogger.consoleLogs.some((l) => l.includes('activating coroutine inside main-loop refresh')),
'main loop should have run and activated the coroutine'
).toBe(true);
});
// Probe #6: WebGL 2.0 + coroutine activated mid-render-frame (KiCad's GAL render path).
test('WebGL2 + mid-frame fiber reaches DONE without renderer crash', async ({ page, testLogger }) => {
await page.goto('/standalone/coroutine-pthread/gl_repro.html');
await tryLoadApp(page, 20000).catch(() => {}); // eslint-disable-line -- best-effort load in a pthread/coroutine runtime probe
await expect
.poll(() => testLogger.consoleLogs.some((l) => l.includes('[REPRO] DONE')), {
timeout: 30000,
message: 'should reach [REPRO] DONE (the mid-GL-frame suspension chain survived)',
})
.toBe(true);
expect(
testLogger.consoleLogs.some((l) => l.includes('WebGL2 context=')),
'a WebGL2 context should have been created'
).toBe(true);
});
// Probe #7: WebGL2 + coroutine mid-frame + PTHREADS (the GL x pthreads combo KiCad uses).
test('WebGL2 + pthreads mid-frame fiber reaches DONE without renderer crash', async ({ page, testLogger }) => {
await page.goto('/standalone/coroutine-pthread/gl_repro_pt.html');
await tryLoadApp(page, 25000).catch(() => {}); // eslint-disable-line -- best-effort load in a pthread/coroutine runtime probe
await expect
.poll(() => testLogger.consoleLogs.some((l) => l.includes('[REPRO] DONE')), {
timeout: 30000,
message: 'should reach [REPRO] DONE (GL + pthreads mid-frame suspension chain survived)',
})
.toBe(true);
});
// Probe #8: a VIRTUAL call via invoke_vi -> instrumented dynCall_vi made from the
// asyncify-rewound frame AFTER a coroutine round-trip. This is the exact factor the
// KiCad crash has that nested_repro lacked: PCB_EDIT_FRAME's ctor calls the virtual
// setupUIConditions() after InvokeTool's first coroutine unwinds/rewinds the ctor stack.
test('post-coroutine virtual call (invoke_vi->dynCall_vi) reaches DONE without renderer crash', async ({ page, testLogger }) => {
await page.goto('/standalone/coroutine-pthread/vcall_repro.html');
await tryLoadApp(page, 25000).catch(() => {}); // eslint-disable-line -- best-effort load in a pthread/coroutine runtime probe
await expect
.poll(() => testLogger.consoleLogs.some((l) => l.includes('[REPRO] DONE')), {
timeout: 30000,
message: 'should reach [REPRO] DONE (virtual call from the rewound frame survived)',
})
.toBe(true);
expect(
testLogger.consoleLogs.some((l) => l.includes('post-coroutine virtual call returned OK')),
'the post-coroutine virtual call should have completed'
).toBe(true);
});
});