4c3a4cacd4
Make the Playwright e2e + kicad suites deterministic so screenshot flake stops tracing to timing races. - Blind page.waitForTimeout -> condition waits (expect.poll, web-first assertions, waitUntil) + readiness helpers (waitForWxApp, waitForCanvasApp). Remaining sleeps are documented interaction dwells (annotated). - Defensive "if element exists" branches -> loud asserts; label-fallback chains -> normalized clickMenuItemByText. First-run wizard for/if loops removed by seeding calculator/gerbview/pcbnew HTMLs. - Screenshots: new stableShot(page, name) settles the render in-page (canvas hash over rAF) then writes a raw PNG to test-results/ for the existing offline gate (tools/screenshots vs baseline-screenshots). Replaces toHaveScreenshot, which did inline compare + its own baselines and had decoupled the specs from the real gate. scale:'css' pinned. - retries: 0 in both configs. - Guard: tests/tools/lint-determinism.ts (npm run lint:determinism) bans blind sleeps / toHaveScreenshot / inline retries / swallowed catches in specs; documented exceptions carry a marker. Rules in tests/TESTING.md. Assertions, coverage, and renders unchanged (semantic-equivalence reviewed; captures pixel-identical modulo inherent timer/timestamp/3d-raytrace variance). Both suites green at retries:0 (e2e 340, kicad 92); ~35-61% faster. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BVX1pHMvRPYHdp6ZfEawrk
76 lines
2.6 KiB
TypeScript
76 lines
2.6 KiB
TypeScript
// wxDialog/wxMessageBox Tests - Modal dialogs for KiCad confirmations, errors, properties
|
|
// Uses element registry for semantic element identification
|
|
import { test, expect, waitForWxApp, clickByLabel } from './utils/fixtures';
|
|
import { stableShot } from './utils/element-tracker';
|
|
|
|
test.describe('wxDialog/wxMessageBox Tests', () => {
|
|
test('Dialog test app loads successfully', async ({ page, testLogger }) => {
|
|
await page.goto('/standalone/dialog/dialog_test.html');
|
|
await waitForWxApp(page);
|
|
|
|
await stableShot(page, 'dialog-01-loaded.png', { fullPage: true });
|
|
|
|
const hasStartupLog = testLogger.consoleLogs.some(log =>
|
|
log.includes('DIALOG_TEST') && log.includes('started successfully')
|
|
);
|
|
|
|
expect(testLogger.errors.filter(e => !e.includes('favicon'))).toHaveLength(0);
|
|
});
|
|
|
|
test('Info dialog button can be clicked', async ({ page, testLogger }) => {
|
|
await page.goto('/standalone/dialog/dialog_test.html');
|
|
await waitForWxApp(page);
|
|
|
|
// Click "Info Dialog" button
|
|
await clickByLabel(page, 'Info Dialog');
|
|
|
|
await expect.poll(
|
|
() => testLogger.consoleLogs.some(l => l.includes('Opening Info dialog')),
|
|
{ message: 'Info dialog should open' }
|
|
).toBe(true);
|
|
|
|
await stableShot(page, 'dialog-02-info-clicked.png', { fullPage: true });
|
|
});
|
|
|
|
test('Yes/No dialog button can be clicked', async ({ page, testLogger }) => {
|
|
await page.goto('/standalone/dialog/dialog_test.html');
|
|
await waitForWxApp(page);
|
|
|
|
// Click "Yes/No Dialog" button
|
|
await clickByLabel(page, 'Yes/No Dialog');
|
|
|
|
await expect.poll(
|
|
() => testLogger.consoleLogs.some(l => l.includes('Opening Yes/No dialog')),
|
|
{ message: 'Yes/No dialog should open' }
|
|
).toBe(true);
|
|
|
|
await stableShot(page, 'dialog-03-yesno-clicked.png', { fullPage: true });
|
|
});
|
|
|
|
test('Error dialog button can be clicked', async ({ page, testLogger }) => {
|
|
await page.goto('/standalone/dialog/dialog_test.html');
|
|
await waitForWxApp(page);
|
|
|
|
// Click "Error Dialog" button
|
|
await clickByLabel(page, 'Error Dialog');
|
|
|
|
await expect.poll(
|
|
() => testLogger.consoleLogs.some(l => l.includes('Opening Error dialog')),
|
|
{ message: 'Error dialog should open' }
|
|
).toBe(true);
|
|
|
|
await stableShot(page, 'dialog-04-error-clicked.png', { fullPage: true });
|
|
});
|
|
|
|
test('Custom dialog button can be clicked', async ({ page }) => {
|
|
await page.goto('/standalone/dialog/dialog_test.html');
|
|
await waitForWxApp(page);
|
|
|
|
// Click "Custom Dialog" button
|
|
await clickByLabel(page, 'Custom Dialog');
|
|
|
|
await stableShot(page, 'dialog-05-custom-clicked.png', { fullPage: true });
|
|
|
|
expect(true).toBe(true);
|
|
});
|
|
});
|