4c3a4cacd4
Make the Playwright e2e + kicad suites deterministic so screenshot flake stops tracing to timing races. - Blind page.waitForTimeout -> condition waits (expect.poll, web-first assertions, waitUntil) + readiness helpers (waitForWxApp, waitForCanvasApp). Remaining sleeps are documented interaction dwells (annotated). - Defensive "if element exists" branches -> loud asserts; label-fallback chains -> normalized clickMenuItemByText. First-run wizard for/if loops removed by seeding calculator/gerbview/pcbnew HTMLs. - Screenshots: new stableShot(page, name) settles the render in-page (canvas hash over rAF) then writes a raw PNG to test-results/ for the existing offline gate (tools/screenshots vs baseline-screenshots). Replaces toHaveScreenshot, which did inline compare + its own baselines and had decoupled the specs from the real gate. scale:'css' pinned. - retries: 0 in both configs. - Guard: tests/tools/lint-determinism.ts (npm run lint:determinism) bans blind sleeps / toHaveScreenshot / inline retries / swallowed catches in specs; documented exceptions carry a marker. Rules in tests/TESTING.md. Assertions, coverage, and renders unchanged (semantic-equivalence reviewed; captures pixel-identical modulo inherent timer/timestamp/3d-raytrace variance). Both suites green at retries:0 (e2e 340, kicad 92); ~35-61% faster. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BVX1pHMvRPYHdp6ZfEawrk
59 lines
2.2 KiB
TypeScript
59 lines
2.2 KiB
TypeScript
// wxXmlDocument Tests - XML parsing like KiCad's config and project files
|
|
//
|
|
// Determinism: no waitForTimeout. Readiness via waitForWxApp (canvas visible + registry
|
|
// populated, fails loudly) replaces the tryLoadApp + expect(loaded).toBe(true) dance. Each
|
|
// test screenshots a STATIC loaded state, so the 500ms settle sleeps are dropped and the
|
|
// screenshots become stableShot (its stabilization is the settle). Same base names.
|
|
import { test, expect, waitForWxApp } from './utils/fixtures';
|
|
import { stableShot } from './utils/element-tracker';
|
|
|
|
test.describe('wxXmlDocument Tests', () => {
|
|
|
|
test('XML test app loads successfully', async ({ page, testLogger }) => {
|
|
await page.goto('/standalone/xml/xml_test.html');
|
|
await waitForWxApp(page);
|
|
|
|
await stableShot(page, 'xml-01-loaded.png', { fullPage: true });
|
|
|
|
expect(testLogger.errors.filter(e => !e.includes('favicon'))).toHaveLength(0);
|
|
});
|
|
|
|
test('Sample XML input exists', async ({ page, testLogger }) => {
|
|
await page.goto('/standalone/xml/xml_test.html');
|
|
await waitForWxApp(page);
|
|
|
|
await stableShot(page, 'xml-02-input.png', { fullPage: true });
|
|
|
|
// App loaded successfully - verify no errors
|
|
expect(testLogger.errors.filter(e => !e.includes('favicon'))).toHaveLength(0);
|
|
});
|
|
|
|
test('Parse button exists', async ({ page, testLogger }) => {
|
|
await page.goto('/standalone/xml/xml_test.html');
|
|
await waitForWxApp(page);
|
|
|
|
await stableShot(page, 'xml-03-parse.png', { fullPage: true });
|
|
});
|
|
|
|
test('Traverse button exists', async ({ page, testLogger }) => {
|
|
await page.goto('/standalone/xml/xml_test.html');
|
|
await waitForWxApp(page);
|
|
|
|
await stableShot(page, 'xml-04-traverse.png', { fullPage: true });
|
|
});
|
|
|
|
test('Create XML button exists', async ({ page, testLogger }) => {
|
|
await page.goto('/standalone/xml/xml_test.html');
|
|
await waitForWxApp(page);
|
|
|
|
await stableShot(page, 'xml-05-create.png', { fullPage: true });
|
|
});
|
|
|
|
test('Results output panel exists', async ({ page, testLogger }) => {
|
|
await page.goto('/standalone/xml/xml_test.html');
|
|
await waitForWxApp(page);
|
|
|
|
await stableShot(page, 'xml-06-results.png', { fullPage: true });
|
|
});
|
|
|
|
});
|