pcbjam/tests/e2e/gal-webgl.spec.ts
Viktor Vaczi 4c3a4cacd4 test(determinism): deterministic waits + stableShot screenshots; drop blind sleeps/ifs/retries
Make the Playwright e2e + kicad suites deterministic so screenshot flake stops
tracing to timing races.

- Blind page.waitForTimeout -> condition waits (expect.poll, web-first
  assertions, waitUntil) + readiness helpers (waitForWxApp, waitForCanvasApp).
  Remaining sleeps are documented interaction dwells (annotated).
- Defensive "if element exists" branches -> loud asserts; label-fallback chains
  -> normalized clickMenuItemByText. First-run wizard for/if loops removed by
  seeding calculator/gerbview/pcbnew HTMLs.
- Screenshots: new stableShot(page, name) settles the render in-page (canvas
  hash over rAF) then writes a raw PNG to test-results/ for the existing offline
  gate (tools/screenshots vs baseline-screenshots). Replaces toHaveScreenshot,
  which did inline compare + its own baselines and had decoupled the specs from
  the real gate. scale:'css' pinned.
- retries: 0 in both configs.
- Guard: tests/tools/lint-determinism.ts (npm run lint:determinism) bans blind
  sleeps / toHaveScreenshot / inline retries / swallowed catches in specs;
  documented exceptions carry a marker. Rules in tests/TESTING.md.

Assertions, coverage, and renders unchanged (semantic-equivalence reviewed;
captures pixel-identical modulo inherent timer/timestamp/3d-raytrace variance).
Both suites green at retries:0 (e2e 340, kicad 92); ~35-61% faster.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BVX1pHMvRPYHdp6ZfEawrk
2026-07-07 10:50:24 +02:00

199 lines
6.8 KiB
TypeScript

/**
* GAL WebGL Regression Test
*
* Runs all 28 GAL test scenarios in WebGL and captures screenshots
* for comparison against native OpenGL rendering.
*/
import { test, expect } from './utils/fixtures';
import * as path from 'path';
import * as fs from 'fs';
// Scenario names (must match native test)
const SCENARIO_NAMES = [
'basic-lines', // 0
'line-widths', // 1
'circles', // 2
'arcs', // 3
'rectangles', // 4
'polygons', // 5
'alpha-blending', // 6
'transforms', // 7
'grid-cursor', // 8
'segments', // 9
'complex-scene', // 10
'bezier-curves', // 11
'arc-segments', // 12
'segment-chain', // 13
'group-caching', // 14
'polylines-multi', // 15
'hole-walls', // 16
'grid-native', // 17
'cursor-native', // 18
'render-targets', // 19
'screen-transform', // 20
'clear-colors', // 21
'depth-testing', // 22
'negative-mode', // 23
'text-attrs', // 24
'glyphs', // 25
'bitmap', // 26
'transform-api' // 27
];
// Output directory for WebGL screenshots
const OUTPUT_DIR = path.join(__dirname, '../gal-regression/output/webgl');
test.describe('GAL WebGL Regression Tests', () => {
test.beforeAll(async () => {
// Ensure output directory exists
if (!fs.existsSync(OUTPUT_DIR)) {
fs.mkdirSync(OUTPUT_DIR, { recursive: true });
}
});
test('Load GAL WebGL test module', async ({ page, testLogger }) => {
await page.goto('/gal-webgl/gal_webgl_test.html');
// Wait for the custom event indicating module is ready
await page.waitForFunction(() => {
return (window as any).galTest !== undefined;
}, { timeout: 60000 });
// Verify module loaded
const totalScenarios = await page.evaluate(() => {
return (window as any).galTest.getTotalScenarios();
});
expect(totalScenarios).toBe(28);
await page.screenshot({
path: path.join(OUTPUT_DIR, 'gal-module-loaded.png'),
fullPage: true
});
console.log(`GAL WebGL test module loaded with ${totalScenarios} scenarios`);
});
// Generate a test for each scenario
for (let i = 0; i < SCENARIO_NAMES.length; i++) {
const scenarioName = SCENARIO_NAMES[i];
const scenarioIndex = i;
test(`Scenario ${scenarioIndex}: ${scenarioName}`, async ({ page, testLogger }) => {
// Capture console output for debugging
const consoleLogs: string[] = [];
page.on('console', msg => {
consoleLogs.push(`[${msg.type()}] ${msg.text()}`);
});
page.on('pageerror', err => {
consoleLogs.push(`[ERROR] ${err.message}`);
});
await page.goto('/gal-webgl/gal_webgl_test.html');
// Wait for module to be ready
await page.waitForFunction(() => {
return (window as any).galTest !== undefined && (window as any).galTest.isReady();
}, { timeout: 60000 });
// Run the scenario
await page.evaluate((index) => {
(window as any).galTest.runScenario(index);
}, scenarioIndex);
// Wait deterministically for rendering to complete: runScenario reports
// success by logging `[GAL Test] Rendered: <name>` (setStatus).
await expect.poll(
() => consoleLogs.some(l => l.includes(`Rendered: ${scenarioName}`)),
{ message: `scenario ${scenarioName} did not report render completion` }
).toBe(true);
// Debug: list all canvases on the page
const canvasInfo = await page.evaluate(() => {
const canvases = document.querySelectorAll('canvas');
const windowContainer = document.getElementById('window-container');
return {
canvases: Array.from(canvases).map(c => ({
id: c.id,
className: c.className,
width: c.width,
height: c.height,
display: window.getComputedStyle(c).display,
parentId: c.parentElement?.id
})),
windowContainerChildren: windowContainer?.children.length || 0,
allElements: document.querySelectorAll('#window-container *').length
};
});
console.log('Canvas debug:', JSON.stringify(canvasInfo, null, 2));
// wxGLCanvas renders as class 'gl-canvas' (per the harness); target it directly.
const canvas = page.locator('canvas').first();
await expect(canvas).toBeVisible({ timeout: 5000 });
// Hide controls overlay before screenshot (it sits on top of canvas)
await page.locator('#controls-overlay').evaluate(el => el.style.visibility = 'hidden');
// Screenshot the canvas (matching native 800x600 output)
const screenshotPath = path.join(OUTPUT_DIR, `gal-${scenarioName}.png`);
await canvas.screenshot({ path: screenshotPath });
// Restore overlay for manual debugging
await page.locator('#controls-overlay').evaluate(el => el.style.visibility = 'visible');
// Print console logs for first scenario (debugging)
if (scenarioIndex === 0) {
console.log('\n=== Console logs ===');
consoleLogs.forEach(log => console.log(log));
console.log('===================\n');
}
console.log(`Saved: ${screenshotPath}`);
});
}
test('Run all scenarios sequentially', async ({ page, testLogger }) => {
await page.goto('/gal-webgl/gal_webgl_test.html');
// Wait for module to be fully ready (not just defined)
await page.waitForFunction(() => {
return (window as any).galTest !== undefined && (window as any).galTest.isReady();
}, { timeout: 60000 });
console.log('Running all 28 scenarios...');
// Find the GL canvas (same logic as individual tests)
const canvas = page.locator('canvas').first(); // wxGLCanvas renders as class 'gl-canvas'
for (let i = 0; i < SCENARIO_NAMES.length; i++) {
const scenarioName = SCENARIO_NAMES[i];
// Run scenario
await page.evaluate((index) => {
(window as any).galTest.runScenario(index);
}, i);
// Wait deterministically for rendering to complete: on success runScenario
// sets the status element to `Rendered: <name>` (setStatus).
await expect.poll(
() => page.evaluate(() => document.getElementById('status')?.textContent ?? ''),
{ message: `scenario ${scenarioName} did not report render completion` }
).toContain(`Rendered: ${scenarioName}`);
// Hide controls overlay before screenshot
await page.locator('#controls-overlay').evaluate(el => el.style.visibility = 'hidden');
// Screenshot the GL canvas
const screenshotPath = path.join(OUTPUT_DIR, `gal-${scenarioName}.png`);
await canvas.screenshot({ path: screenshotPath });
// Restore overlay
await page.locator('#controls-overlay').evaluate(el => el.style.visibility = 'visible');
console.log(`[${i + 1}/28] ${scenarioName}`);
}
console.log('All scenarios completed');
});
});