8a20f69c5e
Quit used to mimic the Back button (history.back() whenever a referrer
existed), but every in-app entry and every tool switch is a hard
location.assign that pushes a history entry — so after schematic ⇄ pcb
switches, one step back is another editor, not the page the user left from.
Quit now navigates to the project overview explicitly (projectPath; "/" for
lib editors), which also covers deep links uniformly.
New VITE_QUIT_ORIGIN ("" ⇒ same-origin) lets the backed editor deployment
exit to the management app's project page instead of the standalone's own;
build-editor.mjs sets it (override with --app-origin).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
86 lines
3.4 KiB
TypeScript
86 lines
3.4 KiB
TypeScript
import { test, expect, type Page } from '@playwright/test';
|
|
import { clickMenuBarItem, clickMenuItemByText } from '../e2e/utils/element-tracker';
|
|
|
|
/**
|
|
* File → Quit e2e: quitting an editor must leave it for the project overview,
|
|
* however the editor was entered (project-page link or deep link).
|
|
*
|
|
* The wx wasm port notifies the page when the app's top window is destroyed
|
|
* (window.wxAppTopWindowClosed, wxwidgets src/wasm/toplevel.cpp); WasmTool maps
|
|
* that to location.assign(projectPath) — deliberately NOT history.back(),
|
|
* which strands the user in the previous editor after a tool switch (see
|
|
* quit-after-tool-switch.spec.ts). A quit vetoed by the unsaved-changes prompt
|
|
* never destroys the frame, so it never navigates.
|
|
*
|
|
* URL-only assertions — no screenshots.
|
|
*/
|
|
|
|
/** Scope segment for the demo project (the reference backend serves it for any). */
|
|
const SCOPE = 'default';
|
|
|
|
const EDITOR_URL_RE = /\/default\/projects\/demo\/demo\.kicad_sch/;
|
|
// Project overview: path ends at /projects/demo (optionally a query string).
|
|
const PROJECT_URL_RE = /\/default\/projects\/demo\/?(\?.*)?$/;
|
|
|
|
async function waitForToolReady(page: Page, titleRe: RegExp): Promise<void> {
|
|
await expect(page.locator('#canvas')).toBeVisible({ timeout: 120000 });
|
|
await expect
|
|
.poll(() => page.title(), {
|
|
message: `editor never reached title ${titleRe}`,
|
|
timeout: 120000,
|
|
intervals: [1000],
|
|
})
|
|
.toMatch(titleRe);
|
|
// The menu helpers drive the rendered-element registry.
|
|
await page.waitForFunction(
|
|
() =>
|
|
!!(window as unknown as { wxElementRegistry?: { findAllRendered?: unknown } })
|
|
.wxElementRegistry,
|
|
null,
|
|
{ timeout: 30000 }
|
|
);
|
|
// The boot and eager-library overlays (WasmTool, `absolute inset-0 z-30`)
|
|
// cover the whole editor including the menubar — synthetic menu clicks land
|
|
// on them until they clear (eeschema hydrates the full symbol set post-boot).
|
|
await expect(page.locator("div.absolute.inset-0.z-30")).toHaveCount(0, {
|
|
timeout: 180000,
|
|
});
|
|
}
|
|
|
|
async function quitViaFileMenu(page: Page): Promise<void> {
|
|
expect(await clickMenuBarItem(page, 'File'), 'File menubar item clickable').toBe(true);
|
|
await clickMenuItemByText(page, 'Quit');
|
|
}
|
|
|
|
test.describe('web app — File → Quit leaves the editor', () => {
|
|
test('quit after entering from the project page navigates back to it', async ({ page }) => {
|
|
test.setTimeout(300000); // full wasm boot
|
|
|
|
// Enter the editor the way a user does: the project page's "Open in …"
|
|
// link is a hard navigation, creating the history entry Quit pops.
|
|
await page.goto(`/${SCOPE}/projects/demo`);
|
|
await page
|
|
.getByRole('link', { name: /Open in Schematic Editor/i })
|
|
.first()
|
|
.click();
|
|
await page.waitForURL(EDITOR_URL_RE, { timeout: 30000 });
|
|
await waitForToolReady(page, /demo — Schematic Editor/i);
|
|
|
|
await quitViaFileMenu(page);
|
|
|
|
await page.waitForURL(PROJECT_URL_RE, { timeout: 30000 });
|
|
});
|
|
|
|
test('quit on a deep-linked editor goes to the project page', async ({ page }) => {
|
|
test.setTimeout(300000);
|
|
|
|
// Direct entry (typed URL): no project page in this tab's history —
|
|
// quit must land on the project overview all the same.
|
|
await page.goto(`/${SCOPE}/projects/demo/demo.kicad_sch`);
|
|
await waitForToolReady(page, /demo — Schematic Editor/i);
|
|
|
|
await quitViaFileMenu(page);
|
|
|
|
await page.waitForURL(PROJECT_URL_RE, { timeout: 30000 });
|
|
});
|
|
});
|