pcbjam/tests/e2e/coroutine-pthread.spec.ts
Viktor Vaczi 4c3a4cacd4 test(determinism): deterministic waits + stableShot screenshots; drop blind sleeps/ifs/retries
Make the Playwright e2e + kicad suites deterministic so screenshot flake stops
tracing to timing races.

- Blind page.waitForTimeout -> condition waits (expect.poll, web-first
  assertions, waitUntil) + readiness helpers (waitForWxApp, waitForCanvasApp).
  Remaining sleeps are documented interaction dwells (annotated).
- Defensive "if element exists" branches -> loud asserts; label-fallback chains
  -> normalized clickMenuItemByText. First-run wizard for/if loops removed by
  seeding calculator/gerbview/pcbnew HTMLs.
- Screenshots: new stableShot(page, name) settles the render in-page (canvas
  hash over rAF) then writes a raw PNG to test-results/ for the existing offline
  gate (tools/screenshots vs baseline-screenshots). Replaces toHaveScreenshot,
  which did inline compare + its own baselines and had decoupled the specs from
  the real gate. scale:'css' pinned.
- retries: 0 in both configs.
- Guard: tests/tools/lint-determinism.ts (npm run lint:determinism) bans blind
  sleeps / toHaveScreenshot / inline retries / swallowed catches in specs;
  documented exceptions carry a marker. Rules in tests/TESTING.md.

Assertions, coverage, and renders unchanged (semantic-equivalence reviewed;
captures pixel-identical modulo inherent timer/timestamp/3d-raytrace variance).
Both suites green at retries:0 (e2e 340, kicad 92); ~35-61% faster.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BVX1pHMvRPYHdp6ZfEawrk
2026-07-07 10:50:24 +02:00

153 lines
7.3 KiB
TypeScript

import { test, expect, tryLoadApp } from './utils/fixtures';
// Isolated reproduction probe for the KiCad Asyncify-fiber x pthreads Chrome crash.
// Loads main_repro.html (fiber Call/Yield/Resume in main(), built WITH pthreads, no wx).
// Firefox should print "[REPRO] DONE"; if system Chrome crashes before DONE, the crash
// is reproduced in isolation.
test.describe('Coroutine pthread main() reproduction', () => {
test('fiber-in-main + pthreads reaches DONE without renderer crash', async ({ page, testLogger }) => {
await page.goto('/standalone/coroutine-pthread/main_repro.html');
await tryLoadApp(page, 20000).catch(() => {}); // eslint-disable-line -- best-effort load in a pthread/coroutine runtime probe
await expect
.poll(() => testLogger.consoleLogs.some((l) => l.includes('[REPRO] DONE')), {
timeout: 30000,
message: 'should reach [REPRO] DONE (i.e. the main-context rewind survived)',
})
.toBe(true);
// Sanity: the coroutine body must actually have run (fiber entry wired up).
expect(
testLogger.consoleLogs.some((l) => l.includes('[REPRO] coroutine body running')),
'coroutine body should have executed'
).toBe(true);
});
// Probe #2: coroutine activated through nested JS<->wasm dynCall boundaries (KiCad's shape).
test('nested dynCall-boundary fiber reaches DONE without renderer crash', async ({ page, testLogger }) => {
await page.goto('/standalone/coroutine-pthread/nested_repro_ex.html');
await tryLoadApp(page, 20000).catch(() => {}); // eslint-disable-line -- best-effort load in a pthread/coroutine runtime probe
await expect
.poll(() => testLogger.consoleLogs.some((l) => l.includes('[REPRO] DONE')), {
timeout: 30000,
message: 'should reach [REPRO] DONE (main rewind through the dynCall chain survived)',
})
.toBe(true);
expect(
testLogger.consoleLogs.some((l) => l.includes('[REPRO] coroutine body running')),
'coroutine body should have executed'
).toBe(true);
});
// Probe #3: the full 13-scenario wx-event-loop harness, built WITH pthreads.
test('wx event loop + pthreads coroutine suite completes without renderer crash', async ({ page, testLogger }) => {
await page.goto('/standalone/coroutine-pthread/coroutine_test_wxpt.html');
await tryLoadApp(page, 30000).catch(() => {}); // eslint-disable-line -- best-effort load in a pthread/coroutine runtime probe
await expect
.poll(() => testLogger.consoleLogs.find((l) => l.includes('[COROUTINE_TEST] SUMMARY')) ?? null, {
timeout: 45000,
message: 'wx+pthreads suite should emit a SUMMARY line (no crash)',
})
.not.toBeNull();
const summary = testLogger.consoleLogs.find((l) => l.includes('[COROUTINE_TEST] SUMMARY'))!;
const m = summary.match(/total=(\d+)\s+passed=(\d+)\s+failed=(\d+)/);
expect(m, 'SUMMARY parseable').not.toBeNull();
expect(Number(m![3]), 'no failed cases').toBe(0);
});
// Probe #4: coroutine activated via an embind (--bind) call.
// Known crash repro: the embind-dispatched fiber currently crashes the renderer
// before reaching DONE. Marked as an expected failure until the coroutine/asyncify
// rewind through the embind dispatch is fixed.
test.fail('embind-activated fiber reaches DONE without renderer crash', async ({ page, testLogger }) => {
await page.goto('/standalone/coroutine-pthread/embind_repro.html');
await tryLoadApp(page, 20000).catch(() => {}); // eslint-disable-line -- best-effort load in a pthread/coroutine runtime probe
await expect
.poll(() => testLogger.consoleLogs.some((l) => l.includes('[REPRO] DONE')), {
timeout: 30000,
message: 'should reach [REPRO] DONE (rewind through the embind dispatch survived)',
})
.toBe(true);
expect(
testLogger.consoleLogs.some((l) => l.includes('ToolHost::activate')),
'embind activate should have run'
).toBe(true);
});
// Probe #5: coroutine activated inside an emscripten_set_main_loop (rAF) callback
// (the single JS->wasm boundary KiCad uses; matches "main-refresh" in the crash trace).
test('main-loop(rAF)-activated fiber reaches DONE without renderer crash', async ({ page, testLogger }) => {
await page.goto('/standalone/coroutine-pthread/mainloop_repro.html');
await tryLoadApp(page, 20000).catch(() => {}); // eslint-disable-line -- best-effort load in a pthread/coroutine runtime probe
await expect
.poll(() => testLogger.consoleLogs.some((l) => l.includes('[REPRO] DONE')), {
timeout: 30000,
message: 'should reach [REPRO] DONE (rewind through the main-loop dynCall_v survived)',
})
.toBe(true);
expect(
testLogger.consoleLogs.some((l) => l.includes('activating coroutine inside main-loop refresh')),
'main loop should have run and activated the coroutine'
).toBe(true);
});
// Probe #6: WebGL 2.0 + coroutine activated mid-render-frame (KiCad's GAL render path).
test('WebGL2 + mid-frame fiber reaches DONE without renderer crash', async ({ page, testLogger }) => {
await page.goto('/standalone/coroutine-pthread/gl_repro.html');
await tryLoadApp(page, 20000).catch(() => {}); // eslint-disable-line -- best-effort load in a pthread/coroutine runtime probe
await expect
.poll(() => testLogger.consoleLogs.some((l) => l.includes('[REPRO] DONE')), {
timeout: 30000,
message: 'should reach [REPRO] DONE (rewind of a mid-GL-frame survived)',
})
.toBe(true);
expect(
testLogger.consoleLogs.some((l) => l.includes('WebGL2 context=')),
'a WebGL2 context should have been created'
).toBe(true);
});
// Probe #7: WebGL2 + coroutine mid-frame + PTHREADS (the GL x pthreads combo KiCad uses).
test('WebGL2 + pthreads mid-frame fiber reaches DONE without renderer crash', async ({ page, testLogger }) => {
await page.goto('/standalone/coroutine-pthread/gl_repro_pt.html');
await tryLoadApp(page, 25000).catch(() => {}); // eslint-disable-line -- best-effort load in a pthread/coroutine runtime probe
await expect
.poll(() => testLogger.consoleLogs.some((l) => l.includes('[REPRO] DONE')), {
timeout: 30000,
message: 'should reach [REPRO] DONE (GL + pthreads mid-frame rewind survived)',
})
.toBe(true);
});
// Probe #8: a VIRTUAL call via invoke_vi -> instrumented dynCall_vi made from the
// asyncify-rewound frame AFTER a coroutine round-trip. This is the exact factor the
// KiCad crash has that nested_repro lacked: PCB_EDIT_FRAME's ctor calls the virtual
// setupUIConditions() after InvokeTool's first coroutine unwinds/rewinds the ctor stack.
test('post-coroutine virtual call (invoke_vi->dynCall_vi) reaches DONE without renderer crash', async ({ page, testLogger }) => {
await page.goto('/standalone/coroutine-pthread/vcall_repro.html');
await tryLoadApp(page, 25000).catch(() => {}); // eslint-disable-line -- best-effort load in a pthread/coroutine runtime probe
await expect
.poll(() => testLogger.consoleLogs.some((l) => l.includes('[REPRO] DONE')), {
timeout: 30000,
message: 'should reach [REPRO] DONE (virtual call from the rewound frame survived)',
})
.toBe(true);
expect(
testLogger.consoleLogs.some((l) => l.includes('post-coroutine virtual call returned OK')),
'the post-coroutine virtual call should have completed'
).toBe(true);
});
});