Squash of experiment/ff-big-modules vs main.
Big-module routing removed: native-EH shrank kicad_editor below
SpiderMonkey's x86-64 code budget (runs 29355049705/29356152413 green on
stock Firefox), so BIG_MODULE_SPECS routing and the baseline-only-JIT
crutch are gone — kicad-firefox and kicad-chromium both run the full
suite, with the module compiled the way real users' browsers compile it.
Per-engine screenshots end to end: stableShot/shotPath write
test-results/<engine>/<name>.png; baselines move to
baseline-screenshots/{chromium,firefox}/ and the whole tools/screenshots
pipeline (compare/promote/manifest/spec-map/changelog/Discord) keys on
<engine>/<name>. Previously Firefox and Chromium renders of one spec
overwrote each other and Firefox renders were never actually gated.
Seeded from CI run 29421380806 (92 new firefox baselines, +24 chromium
web-suite shots); manifest generated from the baseline tree.
One merged playwright.config.ts (kicad/asyncify/coroutine/perf as
projects); ~25 dead npm scripts dropped. The web suite is gated in CI for
the first time ever (4 rotted specs fixed, 5 broken lib-bridge specs
triaged as fixme in docs/features/web-e2e-rot/); cheap lint step after
npm ci; last 26 blind-sleep violations fixed.
SwiftShader retired: CI Chromium renders WebGL on ANGLE → Mesa llvmpipe
(--use-gl=angle --use-angle=gl --ignore-gpu-blocklist; the blocklist flag
is mandatory — llvmpipe is blocklisted and WebGL is silently unavailable
without it) in BOTH configs. Under WORKERS=4 congestion SwiftShader
transiently failed the first post-board-load draw and the recovery
cascade ended in a silent permanent Cairo fallback — that engine flip was
the "~1.2% changedRatio both directions" occ-export baseline flake.
Validated 160/160 across two 80-repeat rigs; full analysis in
docs/features/wx-parity-bugs/occ-export-context-eviction.md. Chromium
baselines shift slightly on llvmpipe — promote once from the first green
run. Deflakes the new coverage exposed: presence baselines settle before
capture; presence fixtures declare current file formats; perf gets its
own outputDir so CI evidence survives; occ-export settles the board paint
before the export dialog; menu-item waits (waitForRenderedByLabel before
clickMenuItem) in 4 specs + the TESTING.md rule.
Web suite runs the PROD build, in parallel: webServer becomes backend
`start` + the standalone's e2e:preview (build-preview.mjs: link-wasm →
stash the public/wasm symlink aside during vite build, build-demo.mjs's
move — then vite preview as the persistent server). The wasm middleware
serves /wasm/* in preview and emits COOP/COEP/CORP itself (a pthread
worker script's own response must carry COEP or Chrome kills it with
ERR_BLOCKED_BY_RESPONSE). VITE_* flags bake at build time;
VITE_ALLOW_USER_OVERRIDE joins turbo globalEnv. fullyParallel + default
workers: 5.2m → 1.4m. Determinism fixes the parallel run exposed:
shared-page specs become serial groups; locks.spec grabs alice's exact
item via the new kicadCollabTestSelectByUuid hook (cross-tab "first
footprint" order is not a ysync invariant); quit specs poll page.url()
(quit supersedes its own navigation — NS_BINDING_ABORTED on Firefox).
Suite: 51 passed / 12 skipped / 0 failed in 1.6m.
CI-coverage gate (lint:ci-coverage): every tests/**/*.spec.ts must be
reachable from the npm scripts the workflows invoke — scraped from
.github/workflows/, resolved through package.json, coverage asked from
playwright --list itself. Rules: uncovered-spec + orphan-project (with a
documented LOCAL_ONLY_PROJECTS allowlist). Gating next to
lint:determinism; 138 spec files / 13 projects accounted for.
Product fixes kept from the investigations (reachable on real GPUs too):
wx 7799fd1be5 — paint flags clear before dispatch + Invalidate always
propagates; kicad 3dcfea5e45 — SwiftShader pass-boundary flush +
per-instance font texture + first-frame GL-error drain (GAL recovery
recovers instead of falling back to Cairo) + the user-facing eeschema
switch navigates again under __EMSCRIPTEN__ (project-sync's
FaceRegistered gate had rerouted it into the hidden sync player; caught
by the newly-gated web suite).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018eUxiPApHgGiu9NFyQfhAq
152 lines
6.7 KiB
TypeScript
152 lines
6.7 KiB
TypeScript
/**
|
|
* Churn-free baseline updater — "promote CI's render".
|
|
*
|
|
* CI's x86 render is the source of truth. This pulls a CI run's screenshots
|
|
* (`gh run download`) — or a local dir via --from — and, for each one, overwrites
|
|
* the committed baseline ONLY when the decoded pixels differ beyond the per-engine
|
|
* floor. Unchanged baselines are left byte-identical (never re-encoded), so git
|
|
* sees no churn. New shots are added; baselines with no render are reported as
|
|
* removal candidates and only deleted with --prune.
|
|
*
|
|
* CLI (from tests/):
|
|
* tsx tools/screenshots/promote.ts --run <ci-run-id> [--repo owner/repo] [--prune] [--dry-run]
|
|
* tsx tools/screenshots/promote.ts --from <dir> [--prune] [--dry-run]
|
|
*/
|
|
import * as fs from 'fs';
|
|
import * as os from 'os';
|
|
import * as path from 'path';
|
|
import { execFileSync } from 'child_process';
|
|
import { BASELINE_ROOT, MANIFEST_PATH, floorFor, isIgnored, listEngineKeys, splitKey, type Manifest } from './config';
|
|
import { writeManifest } from './gen-manifest';
|
|
import { diffImages, loadPng } from './image-ops';
|
|
|
|
/** key (`<engine>/<name>`) → absolute committed baseline path. */
|
|
function baselineIndex(root: string): Map<string, string> {
|
|
const abs = path.join(root, BASELINE_ROOT);
|
|
const index = new Map<string, string>();
|
|
for (const key of listEngineKeys(abs)) index.set(key, path.join(abs, key));
|
|
return index;
|
|
}
|
|
|
|
function loadManifest(root: string): Manifest | undefined {
|
|
const p = path.join(root, MANIFEST_PATH);
|
|
if (!fs.existsSync(p)) return undefined;
|
|
try {
|
|
return JSON.parse(fs.readFileSync(p, 'utf8')) as Manifest;
|
|
} catch {
|
|
return undefined;
|
|
}
|
|
}
|
|
|
|
/** Download a CI run's artifact and return the top-level test-results dir holding the shots. */
|
|
function downloadRun(runId: string, repo?: string): string {
|
|
const tmp = fs.mkdtempSync(path.join(os.tmpdir(), 'promote-'));
|
|
const repoArgs = repo ? ['--repo', repo] : [];
|
|
execFileSync('gh', ['run', 'download', runId, '-D', tmp, ...repoArgs], { stdio: 'inherit' });
|
|
// The artifact stores test-results/** — find that dir; its immediate *.png are the shots
|
|
// (exclude the nested screenshot-diff/ triptychs).
|
|
const stack = [tmp];
|
|
while (stack.length) {
|
|
const dir = stack.pop()!;
|
|
const entries = fs.readdirSync(dir, { withFileTypes: true });
|
|
if (path.basename(dir) === 'test-results') return dir;
|
|
for (const e of entries) if (e.isDirectory()) stack.push(path.join(dir, e.name));
|
|
}
|
|
throw new Error(`no test-results/ dir found in the downloaded artifact under ${tmp}`);
|
|
}
|
|
|
|
type Plan = { updated: string[]; added: string[]; unchanged: string[]; removedCandidates: string[] };
|
|
|
|
function buildPlan(root: string, renderDir: string, manifest?: Manifest): { plan: Plan; apply: () => void } {
|
|
const baselines = baselineIndex(root);
|
|
const rendered = new Set(listEngineKeys(renderDir));
|
|
// Never promote excluded screenshots (e.g. the flaky retinascale fullPage shot).
|
|
for (const key of [...rendered]) if (isIgnored(key)) rendered.delete(key);
|
|
for (const key of [...baselines.keys()]) if (isIgnored(key)) baselines.delete(key);
|
|
const plan: Plan = { updated: [], added: [], unchanged: [], removedCandidates: [] };
|
|
const actions: Array<() => void> = [];
|
|
|
|
for (const key of rendered) {
|
|
const src = path.join(renderDir, key);
|
|
const existing = baselines.get(key);
|
|
if (!existing) {
|
|
const dest = path.join(root, BASELINE_ROOT, key);
|
|
plan.added.push(key);
|
|
actions.push(() => {
|
|
fs.mkdirSync(path.dirname(dest), { recursive: true });
|
|
fs.copyFileSync(src, dest); // verbatim bytes
|
|
});
|
|
continue;
|
|
}
|
|
const d = diffImages(loadPng(existing), loadPng(src));
|
|
const floor = floorFor(key);
|
|
if (!d.dimsMatch || d.changedRatio > floor.changedRatio) {
|
|
plan.updated.push(key);
|
|
actions.push(() => fs.copyFileSync(src, existing)); // verbatim bytes, no re-encode → no churn
|
|
} else {
|
|
plan.unchanged.push(key); // leave the committed file untouched
|
|
}
|
|
}
|
|
|
|
// Removal candidates: a committed baseline the manifest expects but this render didn't produce.
|
|
for (const [key, abs] of baselines) {
|
|
if (rendered.has(key)) continue;
|
|
const { engine, name } = splitKey(key);
|
|
if (manifest && !manifest.screenshots.some((e) => e.name === name && e.engine === engine)) continue;
|
|
plan.removedCandidates.push(key);
|
|
actions.push(() => {}); // pruning is opt-in (see main)
|
|
void abs;
|
|
}
|
|
|
|
return { plan, apply: () => actions.forEach((a) => a()) };
|
|
}
|
|
|
|
function parseArgs(argv: string[]): Record<string, string | boolean> {
|
|
const out: Record<string, string | boolean> = {};
|
|
for (let i = 0; i < argv.length; i++) {
|
|
const a = argv[i];
|
|
if (a === '--run') out.run = argv[++i];
|
|
else if (a === '--from') out.from = argv[++i];
|
|
else if (a === '--repo') out.repo = argv[++i];
|
|
else if (a === '--prune') out.prune = true;
|
|
else if (a === '--dry-run') out.dryRun = true;
|
|
}
|
|
return out;
|
|
}
|
|
|
|
function main(): void {
|
|
const args = parseArgs(process.argv.slice(2));
|
|
const root = process.cwd();
|
|
if (!args.run && !args.from) {
|
|
console.error('usage: promote.ts --run <ci-run-id> [--repo owner/repo] | --from <dir> [--prune] [--dry-run]');
|
|
process.exitCode = 2;
|
|
return;
|
|
}
|
|
const renderDir = args.from ? (args.from as string) : downloadRun(args.run as string, args.repo as string);
|
|
const manifest = loadManifest(root);
|
|
const { plan, apply } = buildPlan(root, renderDir, manifest);
|
|
|
|
console.log(
|
|
`[promote] updated=${plan.updated.length} added=${plan.added.length} ` +
|
|
`unchanged=${plan.unchanged.length} removal-candidates=${plan.removedCandidates.length}`
|
|
);
|
|
for (const n of plan.updated) console.log(` UPDATE ${n}`);
|
|
for (const n of plan.added) console.log(` ADD ${n}`);
|
|
for (const n of plan.removedCandidates) console.log(` REMOVE? ${n}${args.prune ? ' (pruning)' : ' (use --prune to delete)'}`);
|
|
|
|
if (args.dryRun) {
|
|
console.log('[promote] dry-run — no files written');
|
|
return;
|
|
}
|
|
apply();
|
|
if (args.prune) {
|
|
const baselines = baselineIndex(root);
|
|
for (const n of plan.removedCandidates) fs.rmSync(baselines.get(n)!, { force: true });
|
|
}
|
|
// Keep the manifest in lockstep with the baseline tree — a stale manifest silently
|
|
// disables removed-screenshot detection for anything added after the last regen.
|
|
writeManifest(root);
|
|
console.log('[promote] done (manifest regenerated) — review `git status` and commit');
|
|
}
|
|
|
|
if (require.main === module) main();
|