pcbjam/tests/e2e/coroutine-nested.spec.ts
Viktor Vaczi 9c475a804e jspi cleanup: remove the asyncify-era residue — dead code, conditionals, pipeline scaffolding, stale prose
The runtime is JSPI-only; this removes everything that still pretended
otherwise. Three exhaustive sweeps (C++/JS+build+CI/tests+docs) drove
the inventory; every deletion verified by grep closure + full gates.

Broken-right-now fixes:
- deploy-staging.yml passed the retired opt_level input — the workflow
  could not even start. Removed.
- env.sh carried dead exports with a live -sASYNCIFY=1 inside
  (WASM_LDFLAGS/PTHREAD_LDFLAGS, zero consumers). Removed; the
  WASM_LEGACY_EXCEPTIONS rationale rewritten to the real reason.
- docker/build.sh exported PCBJAM_ASYNC_BACKEND (read nowhere). Gone.

Dead weight removed:
- binaryen submodule (nothing builds or invokes it), wasm-opt-bench
  workflow + scripts/bench/, get-wasm-opt.sh, diagnostics.js (242 lines
  of Asyncify-API-only code), the KICAD_PIPELINE background-postprocess
  scaffolding (existed to parallelize the deleted wasm-opt phase; the
  postprocess is a seconds-long node script and now runs inline),
  build-monitor's dead asyncify rows, sched-context orphan build
  output, dead .gitignore entries, the .jspi-assets spike dir (the two
  wf-result research JSONs moved to docs/features/async/migration-evidence/).
- bindings: fiber_park.h + its 12 embind registrations (broken-if-
  called under JSPI), the kicadOpenFileStart/OPEN_JOB starter route,
  main_stack_runner.h + 5 includes, the always-null context-sleep weak
  hook in nanosleep_yield.c.
- shim: the backend field (installed-flag idempotency instead),
  noteContextWait (dead both sides), the __wxAsyncifyDump alias (+ the
  WasmTool fallback and string-dump normalize branch).
- web: the emscripten-6-ignored mainScriptUrlOrBlob option in boot.ts
  (gerber-demo keeps it: it loads the deployed CDN release, which
  predates emscripten 6 — noted inline).

Conditionals: all 'backend === jspi' checks reduced to scheduler-
presence checks; races_quiescent re-keyed from Asyncify.state (vacuous)
to real backlog quiescence (resumeReady/mutatorQueue — NOT _windowLive,
which is the probing activation's own window by definition).

Renames (identifiers only, no file renames): ASYNC_LINK_FLAGS→
JSPI_LINK_FLAGS and Makefile ASYNC_LDFLAGS→JSPI_LDFLAGS,
kicadCollabFiberBusy→kicadCollabBusy (embind + web + tests),
collab_common.h fiber*→apply*/coroutine naming, asyncifySignatures→
wasmTrapSignatures (lists byte-identical).

Tests: the two remaining vacuous [wx-asyncify]/fiber-resume-refused
asserts re-keyed to live JSPI beacons; eeschema-load's failure message
no longer sends the developer to a deleted script; wait-beacons' dead
families/parser deleted; lane-0 legacy-glue guards removed (lane 0 is
unconstructible); the embind test.fail re-gated with the JSPI reason
(plain embind invokers cannot suspend — verified still failing);
lint-determinism now scans tests/jspi (166 files clean);
eeschema-collab local-move gated to chromium (~50% flaky on FF even
solo; pcbnew twin covers both engines).

Docs: DEBUG.md rewritten as the JSPI debugging guide; build.md
describes the single-phase build; docs/features/async/README.md
banner-marked historical and repointed at the NEW
23-jspi-runtime.md (current architecture: export census, turnstile,
libcontext ownership + refusal contract, embind call shapes, the
em-pthread service-wrapper trick, exception policy, known gaps).

Gates on the cleaned tree: test:e2e 725 passed / 0 failed (after the
quiescence-probe fix; the 3 other reds were verified contention flakes
solo-green or the documented FF gate), web 76/0, jspi 18/18 both
engines, vitest 295/295 + 17/17, all lints green, live-app census
clean.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016X9eh1s5sTx1o9Em9KBuwR
2026-08-14 09:25:32 +02:00

106 lines
3.8 KiB
TypeScript

import { test, expect, tryLoadApp } from './utils/fixtures';
import { shotPath } from './utils/element-tracker';
const EXPECTED_CASES = [
'baseline_modal_alone',
'baseline_fiber_alone',
'fiber_create_run_destroy_inside_modal',
'fiber_multi_swap_inside_modal',
'fiber_yield_across_modal_close',
'fiber_deep_yield_loop_inside_modal',
'modal_fiber_modal_sequence',
'nested_fibers_inside_modal',
];
function findSummary(logs: string[]) {
return logs.find((log) => log.includes('[COROUTINE_TEST] SUMMARY'));
}
test.describe('Nested Coroutine+Modal Tests', () => {
test('nested harness loads and reports its case inventory', async ({ page, testLogger }) => {
await page.goto('/standalone/coroutine-nested/nested_test.html');
const loaded = await tryLoadApp(page, 30000);
await expect
.poll(
() => testLogger.consoleLogs.filter((log) => log.includes('[COROUTINE_TEST] CASE ')).length,
{ timeout: 45000 }
)
.toBe(EXPECTED_CASES.length);
const caseLogs = testLogger.consoleLogs.filter((log) => log.includes('[COROUTINE_TEST] CASE '));
for (const caseName of EXPECTED_CASES) {
expect(
caseLogs.some((log) => log.includes(`[COROUTINE_TEST] CASE ${caseName}`)),
`case ${caseName} should appear in logs`
).toBe(true);
}
await page.screenshot({ path: shotPath(page, 'coroutine-nested-01-loaded.png'), fullPage: true });
expect(loaded, 'Nested harness should load').toBe(true);
});
test('nested suite reports zero failures', async ({ page, testLogger }) => {
await page.goto('/standalone/coroutine-nested/nested_test.html');
const loaded = await tryLoadApp(page, 30000);
expect(loaded, 'Nested harness should load').toBe(true);
await expect
.poll(() => findSummary(testLogger.consoleLogs) ?? null, {
timeout: 45000,
message: 'Nested suite should emit a final summary line',
})
.not.toBeNull();
const summary = findSummary(testLogger.consoleLogs)!;
const match = summary.match(/total=(\d+)\s+passed=(\d+)\s+failed=(\d+)/);
expect(match, 'Nested summary should be parseable').not.toBeNull();
const total = Number(match![1]);
const passed = Number(match![2]);
const failed = Number(match![3]);
const failLogs = testLogger.consoleLogs.filter((log) => log.includes('[COROUTINE_TEST] FAIL '));
const passLogs = testLogger.consoleLogs.filter((log) => log.includes('[COROUTINE_TEST] PASS '));
expect(total).toBe(EXPECTED_CASES.length);
expect(passed).toBe(EXPECTED_CASES.length);
expect(failed).toBe(0);
expect(failLogs).toHaveLength(0);
expect(passLogs).toHaveLength(EXPECTED_CASES.length);
// Critical: catch the historic nested-suspension crash signature
const indexOobErrors = testLogger.errors.filter((e) =>
e.toLowerCase().includes('index out of bounds')
);
expect(indexOobErrors, 'no index out of bounds errors').toHaveLength(0);
expect(
testLogger.errors.filter((error) => !error.includes('favicon')),
'no unexpected page errors'
).toHaveLength(0);
await page.screenshot({ path: shotPath(page, 'coroutine-nested-02-summary.png'), fullPage: true });
});
test('per-scenario status (diagnostic)', async ({ page, testLogger }) => {
await page.goto('/standalone/coroutine-nested/nested_test.html');
await tryLoadApp(page, 30000);
await expect
.poll(() => findSummary(testLogger.consoleLogs) ?? null, {
timeout: 45000,
})
.not.toBeNull();
// Use soft assertions so we see the full failure map instead of stopping at the first FAIL.
for (const name of EXPECTED_CASES) {
const passed = testLogger.consoleLogs.some((log) =>
log.includes(`[COROUTINE_TEST] PASS ${name}`)
);
expect.soft(passed, `scenario ${name} should PASS`).toBe(true);
}
});
});