e01256b54d
The binopt cache from b4cb10b saved only binaryen-hoist-build/bin, but the
tools dynamically link lib/libbinaryen.so, so the first cache HIT (run
28585074335) failed all 7 tools' finalize with a loader error. Cache bin/ +
lib/, bump the key to binopt-v2 (Ubicloud never re-saves an exact-key hit, so
the poisoned v1 entry can't be repaired in place), and make the
BINARYEN_TRUST_PREBUILT guard exec both tools with --version instead of -x
existence checks so an incomplete restore falls through to a source build.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NTxTrY9on6A8gLvogFbGiy
51 lines
2.6 KiB
Shell
Executable file
51 lines
2.6 KiB
Shell
Executable file
#!/bin/bash
|
|
# Build the host post-process Binaryen tools from our submodule: wasm-opt (with the
|
|
# catch-arm-hoisting pass, --hoist-cpp-catches) AND wasm-emscripten-finalize.
|
|
#
|
|
# Source of truth is the tracked Binaryen submodule (binaryen/, branch wasm-port =
|
|
# upstream version_130 + src/passes/HoistCppCatches.cpp). This configures an out-of-source
|
|
# build into the gitignored build-wasm/ tree and prints the wasm-opt path on stdout
|
|
# (build progress to stderr); wasm-emscripten-finalize lands next to it in the same bin/
|
|
# (apply-finalize.sh derives it from the wasm-opt dir). Building both from one submodule
|
|
# keeps finalize and asyncify on a single Binaryen version and removes the host emsdk
|
|
# dependency from the post-process. See docs/features/wasm-exceptions/06-spike-plan.md (Phase 1.5).
|
|
set -eo pipefail
|
|
|
|
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
|
|
PROJECT_ROOT="$(cd "${SCRIPT_DIR}/../.." && pwd)"
|
|
SRC="${PROJECT_ROOT}/binaryen"
|
|
BUILD="${PROJECT_ROOT}/build-wasm/tools/binaryen-hoist-build"
|
|
|
|
if [ ! -f "${SRC}/src/passes/HoistCppCatches.cpp" ]; then
|
|
echo "ERROR: binaryen submodule is missing the hoist pass." >&2
|
|
echo " Run: git submodule update --init binaryen" >&2
|
|
exit 1
|
|
fi
|
|
|
|
# CI fast-path: the workflow cache-restores bin/ + lib/ keyed on the exact submodule
|
|
# SHA and sets this var on a hit, so the restored binaries are authoritative — skip
|
|
# cmake+ninja. Trust only if both tools actually RUN: the binaries dynamically link
|
|
# lib/libbinaryen.so, so an existence check alone passes on an incomplete restore
|
|
# (bin/ without lib/ shipped a red main, run 28585074335) while --version proves the
|
|
# loader resolves everything. Never set the var locally when iterating on the pass:
|
|
# uncommitted source edits would be silently ignored (the SHA key can't see them).
|
|
if [ "${BINARYEN_TRUST_PREBUILT:-0}" = "1" ] \
|
|
&& "${BUILD}/bin/wasm-opt" --version >/dev/null 2>&1 \
|
|
&& "${BUILD}/bin/wasm-emscripten-finalize" --version >/dev/null 2>&1; then
|
|
echo "Using prebuilt Binaryen tools (BINARYEN_TRUST_PREBUILT=1): ${BUILD}/bin" >&2
|
|
echo "${BUILD}/bin/wasm-opt"
|
|
exit 0
|
|
fi
|
|
|
|
# Configure once (mirrors scripts/common/get-wasm-opt.sh's from-source flags).
|
|
if [ ! -f "${BUILD}/build.ninja" ]; then
|
|
echo "Configuring Binaryen submodule build (one-time, ~5 min to build)..." >&2
|
|
cmake -S "${SRC}" -B "${BUILD}" -G Ninja \
|
|
-DCMAKE_BUILD_TYPE=Release \
|
|
-DCMAKE_CXX_FLAGS="-Wno-maybe-uninitialized" \
|
|
-DCMAKE_INTERPROCEDURAL_OPTIMIZATION=ON -DBUILD_TESTS=OFF >&2
|
|
fi
|
|
|
|
ninja -C "${BUILD}" wasm-opt wasm-emscripten-finalize >&2
|
|
|
|
echo "${BUILD}/bin/wasm-opt"
|