pcbjam/tests/kicad/load-pcb-probe.spec.ts
Viktor Vaczi 9c475a804e jspi cleanup: remove the asyncify-era residue — dead code, conditionals, pipeline scaffolding, stale prose
The runtime is JSPI-only; this removes everything that still pretended
otherwise. Three exhaustive sweeps (C++/JS+build+CI/tests+docs) drove
the inventory; every deletion verified by grep closure + full gates.

Broken-right-now fixes:
- deploy-staging.yml passed the retired opt_level input — the workflow
  could not even start. Removed.
- env.sh carried dead exports with a live -sASYNCIFY=1 inside
  (WASM_LDFLAGS/PTHREAD_LDFLAGS, zero consumers). Removed; the
  WASM_LEGACY_EXCEPTIONS rationale rewritten to the real reason.
- docker/build.sh exported PCBJAM_ASYNC_BACKEND (read nowhere). Gone.

Dead weight removed:
- binaryen submodule (nothing builds or invokes it), wasm-opt-bench
  workflow + scripts/bench/, get-wasm-opt.sh, diagnostics.js (242 lines
  of Asyncify-API-only code), the KICAD_PIPELINE background-postprocess
  scaffolding (existed to parallelize the deleted wasm-opt phase; the
  postprocess is a seconds-long node script and now runs inline),
  build-monitor's dead asyncify rows, sched-context orphan build
  output, dead .gitignore entries, the .jspi-assets spike dir (the two
  wf-result research JSONs moved to docs/features/async/migration-evidence/).
- bindings: fiber_park.h + its 12 embind registrations (broken-if-
  called under JSPI), the kicadOpenFileStart/OPEN_JOB starter route,
  main_stack_runner.h + 5 includes, the always-null context-sleep weak
  hook in nanosleep_yield.c.
- shim: the backend field (installed-flag idempotency instead),
  noteContextWait (dead both sides), the __wxAsyncifyDump alias (+ the
  WasmTool fallback and string-dump normalize branch).
- web: the emscripten-6-ignored mainScriptUrlOrBlob option in boot.ts
  (gerber-demo keeps it: it loads the deployed CDN release, which
  predates emscripten 6 — noted inline).

Conditionals: all 'backend === jspi' checks reduced to scheduler-
presence checks; races_quiescent re-keyed from Asyncify.state (vacuous)
to real backlog quiescence (resumeReady/mutatorQueue — NOT _windowLive,
which is the probing activation's own window by definition).

Renames (identifiers only, no file renames): ASYNC_LINK_FLAGS→
JSPI_LINK_FLAGS and Makefile ASYNC_LDFLAGS→JSPI_LDFLAGS,
kicadCollabFiberBusy→kicadCollabBusy (embind + web + tests),
collab_common.h fiber*→apply*/coroutine naming, asyncifySignatures→
wasmTrapSignatures (lists byte-identical).

Tests: the two remaining vacuous [wx-asyncify]/fiber-resume-refused
asserts re-keyed to live JSPI beacons; eeschema-load's failure message
no longer sends the developer to a deleted script; wait-beacons' dead
families/parser deleted; lane-0 legacy-glue guards removed (lane 0 is
unconstructible); the embind test.fail re-gated with the JSPI reason
(plain embind invokers cannot suspend — verified still failing);
lint-determinism now scans tests/jspi (166 files clean);
eeschema-collab local-move gated to chromium (~50% flaky on FF even
solo; pcbnew twin covers both engines).

Docs: DEBUG.md rewritten as the JSPI debugging guide; build.md
describes the single-phase build; docs/features/async/README.md
banner-marked historical and repointed at the NEW
23-jspi-runtime.md (current architecture: export census, turnstile,
libcontext ownership + refusal contract, embind call shapes, the
em-pthread service-wrapper trick, exception policy, known gaps).

Gates on the cleaned tree: test:e2e 725 passed / 0 failed (after the
quiescence-probe fix; the 3 other reds were verified contention flakes
solo-green or the documented FF gate), web 76/0, jspi 18/18 both
engines, vitest 295/295 + 17/17, all lints green, live-app census
clean.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016X9eh1s5sTx1o9Em9KBuwR
2026-08-14 09:25:32 +02:00

226 lines
8.4 KiB
TypeScript

import * as fs from 'fs';
import * as path from 'path';
import type { Page } from '@playwright/test';
import { test, expect } from './fixtures';
import { clickMenuBarItem, clickMenuItem, waitForEditorReady, shotPath } from '../e2e/utils/element-tracker';
/**
* Probe spec: drives the wizard, opens File menu, clicks Open, then dumps
* everything we need to know about the wxFileDialog state — what frame paints,
* what directory the dialog starts in, what list items are registered, what
* the OK/Cancel button labels are, and which MEMFS directories exist.
*
* Output:
* tests/logs/kicad/load-pcb-probe/<test-name>.log (everything via console)
* tests/test-results/probe-*.png (screenshots)
*
* This is a one-shot investigation, not a regression test. It always passes;
* the value is the captured state.
*/
async function dumpRegistry(page: Page, label: string): Promise<void> {
const summary = await page.evaluate((tag: string) => {
const registry = window.wxElementRegistry;
if (!registry) {
return { tag, error: 'no registry' };
}
const stats = registry.getStats();
const renderedStats = registry.getRenderedStats?.();
const allElements = registry.findAll({ visible: true });
const frames = allElements
.filter((el) => /Frame|Dialog|Wizard/.test(el.typeName))
.slice(0, 30)
.map((el) => ({
id: el.id,
typeName: el.typeName,
label: el.label,
name: el.name,
visible: el.visible,
enabled: el.enabled,
screenX: el.screenX,
screenY: el.screenY,
width: el.width,
height: el.height,
}));
// Try to spot the file dialog specifically
const fileDialogs = allElements
.filter((el) =>
/FileDialog|FileCtrl|FileList|GenericDir/.test(el.typeName) ||
/file/i.test(el.label) ||
/file/i.test(el.name)
)
.slice(0, 50)
.map((el) => ({
id: el.id,
typeName: el.typeName,
label: el.label,
name: el.name,
visible: el.visible,
screenX: el.screenX,
screenY: el.screenY,
width: el.width,
height: el.height,
}));
const rendered = registry.findAllRendered ? registry.findAllRendered({}) : [];
const byType = rendered.reduce<Record<string, number>>((acc, item) => {
acc[item.elementType] = (acc[item.elementType] ?? 0) + 1;
return acc;
}, {});
const menuItems = rendered
.filter((r) => r.elementType === 'menuitem')
.slice(0, 60)
.map((r) => ({
id: r.id,
subType: r.subType,
label: r.label,
enabled: r.enabled,
screenX: r.screenX,
screenY: r.screenY,
}));
const listItems = rendered
.filter((r) => r.elementType === 'listitem')
.slice(0, 60)
.map((r) => ({
id: r.id,
label: r.label,
index: r.index,
screenX: r.screenX,
screenY: r.screenY,
}));
// Buttons (rendered as wxButton in elements, not in rendered registry)
const buttons = allElements
.filter((el) => /Button/.test(el.typeName))
.slice(0, 40)
.map((el) => ({
id: el.id,
typeName: el.typeName,
label: el.label,
name: el.name,
screenX: el.screenX,
screenY: el.screenY,
}));
// Text controls (path bar in dialog is usually a wxTextCtrl)
const textCtrls = allElements
.filter((el) => /TextCtrl|ComboCtrl|ComboBox|Choice/.test(el.typeName))
.slice(0, 30)
.map((el) => ({
id: el.id,
typeName: el.typeName,
label: el.label,
name: el.name,
screenX: el.screenX,
screenY: el.screenY,
width: el.width,
height: el.height,
}));
return {
tag,
stats,
renderedStats,
renderedByType: byType,
frames,
fileDialogs,
menuItems,
listItems,
buttons,
textCtrls,
};
}, label);
// Logged via console so it lands in tests/logs/kicad/load-pcb-probe/<test>.log
console.log(`[PROBE] ${label} :: ${JSON.stringify(summary)}`);
}
async function dumpMemfs(page: Page, candidates: string[]): Promise<void> {
const results = await page.evaluate((paths: string[]) => {
const out: Array<{ path: string; entries: string[] | string }> = [];
for (const p of paths) {
try {
// @ts-ignore — Emscripten FS is global on Module
const entries = (window as any).FS.readdir(p) as string[];
out.push({ path: p, entries });
} catch (e: any) {
out.push({ path: p, entries: `ERROR: ${e?.message ?? e}` });
}
}
return out;
}, candidates);
console.log(`[PROBE-FS] ${JSON.stringify(results)}`);
}
test.describe('PCB load probe', () => {
test.beforeEach(async ({ page }) => {
await page.goto('/kicad/pcbnew.html');
});
// NOTE: This is a one-shot DIAGNOSTIC probe (always green; its value is the logged
// state dumps + screenshots). The fixed waits below are intentional "let state evolve,
// then capture it" intervals, not readiness races — they are exempt from the no-sleep
// guard on purpose. Regression specs (load-pcb, occ-export, …) use deterministic waits.
test('inspect File→Open dialog state', async ({ page }) => {
await waitForEditorReady(page);
await page.screenshot({ path: shotPath(page, 'probe-00-after-wizard.png'), scale: 'css' });
await dumpMemfs(page, [
'/',
'/home',
'/home/kicad',
'/home/kicad/documents',
'/home/kicad/documents/kicad',
'/home/kicad/documents/kicad/10.0',
'/home/kicad/documents/kicad/10.0/projects',
'/tmp',
'/workspace',
]);
await dumpRegistry(page, 'after-wizard');
// Click File menu
const fileClicked = await clickMenuBarItem(page, 'File');
console.log(`[PROBE] File menu clicked: ${fileClicked}`);
await page.waitForTimeout(500); // eslint-disable-line -- diagnostic one-shot; intentional state-capture interval
await page.screenshot({ path: shotPath(page, 'probe-01-file-menu-open.png'), scale: 'css' });
await dumpRegistry(page, 'file-menu-open');
// Click Open menu item (try common label variants)
let openClicked = await clickMenuItem(page, 'Open...');
if (!openClicked) openClicked = await clickMenuItem(page, 'Open…');
if (!openClicked) openClicked = await clickMenuItem(page, 'Open');
console.log(`[PROBE] Open menu item clicked: ${openClicked}`);
// Give the file dialog generous time to render — wxGenericFileDialog
// populates its file list by scanning the directory, which on MEMFS
// is fast but goes through the suspending event loop.
await page.waitForTimeout(3000); // eslint-disable-line -- diagnostic one-shot; intentional state-capture interval
await page.screenshot({ path: shotPath(page, 'probe-02-after-open-click.png'), scale: 'css' });
await dumpRegistry(page, 'after-open-click');
// Wait a bit longer and dump again, in case the dialog paints late
await page.waitForTimeout(3000); // eslint-disable-line -- diagnostic one-shot; intentional state-capture interval
await page.screenshot({ path: shotPath(page, 'probe-03-late.png'), scale: 'css' });
await dumpRegistry(page, 'late');
// Final check: re-dump MEMFS so we can confirm nothing changed under us
await dumpMemfs(page, [
'/home/kicad/documents/kicad/10.0/projects',
'/tmp',
]);
// Probe is always green — the artifacts (logs + screenshots) are the result.
expect(true).toBe(true);
});
});