Squash of experiment/ff-big-modules vs main.
Big-module routing removed: native-EH shrank kicad_editor below
SpiderMonkey's x86-64 code budget (runs 29355049705/29356152413 green on
stock Firefox), so BIG_MODULE_SPECS routing and the baseline-only-JIT
crutch are gone — kicad-firefox and kicad-chromium both run the full
suite, with the module compiled the way real users' browsers compile it.
Per-engine screenshots end to end: stableShot/shotPath write
test-results/<engine>/<name>.png; baselines move to
baseline-screenshots/{chromium,firefox}/ and the whole tools/screenshots
pipeline (compare/promote/manifest/spec-map/changelog/Discord) keys on
<engine>/<name>. Previously Firefox and Chromium renders of one spec
overwrote each other and Firefox renders were never actually gated.
Seeded from CI run 29421380806 (92 new firefox baselines, +24 chromium
web-suite shots); manifest generated from the baseline tree.
One merged playwright.config.ts (kicad/asyncify/coroutine/perf as
projects); ~25 dead npm scripts dropped. The web suite is gated in CI for
the first time ever (4 rotted specs fixed, 5 broken lib-bridge specs
triaged as fixme in docs/features/web-e2e-rot/); cheap lint step after
npm ci; last 26 blind-sleep violations fixed.
SwiftShader retired: CI Chromium renders WebGL on ANGLE → Mesa llvmpipe
(--use-gl=angle --use-angle=gl --ignore-gpu-blocklist; the blocklist flag
is mandatory — llvmpipe is blocklisted and WebGL is silently unavailable
without it) in BOTH configs. Under WORKERS=4 congestion SwiftShader
transiently failed the first post-board-load draw and the recovery
cascade ended in a silent permanent Cairo fallback — that engine flip was
the "~1.2% changedRatio both directions" occ-export baseline flake.
Validated 160/160 across two 80-repeat rigs; full analysis in
docs/features/wx-parity-bugs/occ-export-context-eviction.md. Chromium
baselines shift slightly on llvmpipe — promote once from the first green
run. Deflakes the new coverage exposed: presence baselines settle before
capture; presence fixtures declare current file formats; perf gets its
own outputDir so CI evidence survives; occ-export settles the board paint
before the export dialog; menu-item waits (waitForRenderedByLabel before
clickMenuItem) in 4 specs + the TESTING.md rule.
Web suite runs the PROD build, in parallel: webServer becomes backend
`start` + the standalone's e2e:preview (build-preview.mjs: link-wasm →
stash the public/wasm symlink aside during vite build, build-demo.mjs's
move — then vite preview as the persistent server). The wasm middleware
serves /wasm/* in preview and emits COOP/COEP/CORP itself (a pthread
worker script's own response must carry COEP or Chrome kills it with
ERR_BLOCKED_BY_RESPONSE). VITE_* flags bake at build time;
VITE_ALLOW_USER_OVERRIDE joins turbo globalEnv. fullyParallel + default
workers: 5.2m → 1.4m. Determinism fixes the parallel run exposed:
shared-page specs become serial groups; locks.spec grabs alice's exact
item via the new kicadCollabTestSelectByUuid hook (cross-tab "first
footprint" order is not a ysync invariant); quit specs poll page.url()
(quit supersedes its own navigation — NS_BINDING_ABORTED on Firefox).
Suite: 51 passed / 12 skipped / 0 failed in 1.6m.
CI-coverage gate (lint:ci-coverage): every tests/**/*.spec.ts must be
reachable from the npm scripts the workflows invoke — scraped from
.github/workflows/, resolved through package.json, coverage asked from
playwright --list itself. Rules: uncovered-spec + orphan-project (with a
documented LOCAL_ONLY_PROJECTS allowlist). Gating next to
lint:determinism; 138 spec files / 13 projects accounted for.
Product fixes kept from the investigations (reachable on real GPUs too):
wx 7799fd1be5 — paint flags clear before dispatch + Invalidate always
propagates; kicad 3dcfea5e45 — SwiftShader pass-boundary flush +
per-instance font texture + first-frame GL-error drain (GAL recovery
recovers instead of falling back to Cairo) + the user-facing eeschema
switch navigates again under __EMSCRIPTEN__ (project-sync's
FaceRegistered gate had rerouted it into the hidden sync player; caught
by the newly-gated web suite).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018eUxiPApHgGiu9NFyQfhAq
61 lines
2.5 KiB
TypeScript
61 lines
2.5 KiB
TypeScript
/**
|
|
* Generate tests/screenshot-manifest.json — the canonical list of expected
|
|
* screenshots. Each entry is {name, engine}, read STRAIGHT from the per-engine
|
|
* baseline tree (baseline-screenshots/<engine>/<name>.png) — the engine is the
|
|
* directory, no spec-scanning guesswork.
|
|
*
|
|
* The list is what lets compare/promote tell an intentional REMOVAL from a
|
|
* flaky/absent render. promote.ts regenerates it automatically after applying;
|
|
* --check keeps CI honest if baselines are ever edited by hand.
|
|
*
|
|
* CLI (from tests/): tsx tools/screenshots/gen-manifest.ts [--check]
|
|
* --check exits 1 if the committed manifest is stale (for CI hygiene).
|
|
*/
|
|
import * as fs from 'fs';
|
|
import * as path from 'path';
|
|
import { BASELINE_ROOT, MANIFEST_PATH, isIgnored, listEngineKeys, splitKey, type Manifest } from './config';
|
|
|
|
/** Render the manifest JSON for the current baseline tree. */
|
|
export function manifestJson(root: string): string {
|
|
const screenshots = listEngineKeys(path.join(root, BASELINE_ROOT))
|
|
.filter((key) => !isIgnored(key))
|
|
.map((key) => splitKey(key))
|
|
.map(({ engine, name }) => ({ name, engine }))
|
|
.sort((a, b) => a.engine.localeCompare(b.engine) || a.name.localeCompare(b.name));
|
|
|
|
const manifest: Manifest & { _note: string } = {
|
|
_note: 'Generated from baseline-screenshots/<engine>/ — run `npm run screenshots:manifest`. The name list is authoritative for removed-screenshot detection.',
|
|
screenshots,
|
|
};
|
|
return JSON.stringify(manifest, null, 2) + '\n';
|
|
}
|
|
|
|
/** Regenerate the manifest on disk (used by the CLI and by promote.ts after apply). */
|
|
export function writeManifest(root: string): void {
|
|
fs.writeFileSync(path.join(root, MANIFEST_PATH), manifestJson(root));
|
|
}
|
|
|
|
function main(): void {
|
|
const check = process.argv.includes('--check');
|
|
const root = process.cwd();
|
|
const json = manifestJson(root);
|
|
const outPath = path.join(root, MANIFEST_PATH);
|
|
const count = (JSON.parse(json) as Manifest).screenshots.length;
|
|
|
|
console.log(`[manifest] ${count} screenshots across engines`);
|
|
|
|
if (check) {
|
|
const current = fs.existsSync(outPath) ? fs.readFileSync(outPath, 'utf8') : '';
|
|
if (current !== json) {
|
|
console.error('[manifest] STALE — run `npm run screenshots:manifest` and commit');
|
|
process.exitCode = 1;
|
|
} else {
|
|
console.log('[manifest] up to date');
|
|
}
|
|
return;
|
|
}
|
|
fs.writeFileSync(outPath, json);
|
|
console.log(`[manifest] wrote ${MANIFEST_PATH}`);
|
|
}
|
|
|
|
if (require.main === module) main();
|