| Filename | Latest commit message | Latest commit date |
|---|---|---|
Switching OpenGL → raytracing → OpenGL could leave the viewer showing only the background gradient, with mid-session "[gl1] WebGL context changed" thrash and INVALID_OPERATION storms on BOTH WebGL contexts. Traced mechanism: the shim's FFP draw routing keyed on one process-global client-array flag; an interrupted fixed-function window (MODEL_3D::BeginDrawMulti loops, or the switch-back reload re-recording display lists with the GL context lock released across JSPI suspensions) left it set, after which the raytracer blit's and the 2D GAL's glDrawArrays were routed through the FFP pipeline — and one misrouted draw permanently repointed the VICTIM's own VAO attributes at shim buffers (the blit's attribute 0 collides with ATTR_POSITION), so both stayed broken/blank even after the flag cleared. Shim fixes (wasm/gl1): - Owner-context routing gate: __wrap_glDrawArrays/Elements route into the FFP pipeline only under the shim's owner context (adopted at the first FFP client-state mutation or programSync in a context); foreign-context draws always pass through — the 2D GAL can never be misrouted and the context guard can never thrash. - VAO isolation (ScopedDefaultVAO): draw executors do their attribute setup on VAO 0 and restore the caller's binding — a misrouted draw can no longer corrupt the caller. - contextSync() resets the whole client-array mirror on a context change (enables/pointers/VBO names all described the dead context). kicad pointer bump (d6e3dc1a87a): blit preamble disables the four client arrays (same-context firewall) + DoRePaint hidden-parent early return now clears m_is_currently_painting like its six siblings (a standalone sufficient cause of a permanently blank viewer). TDD (each observed red before its fix, green after; harness = authoritative): - T1 VAO corruption, T2 foreign-context routing + guard thrash, T3 stale client-state surviving context recreation — tests/e2e/3d-webgl.spec.ts over new harness choreography (appQuad/ffpMakeStale/createSecondContext/ quadDrawFresh). Parity stays 47/47 with zero drift. - tests/kicad/3d-viewer-engine-toggle.spec.ts (new, CI-skipped like the deadlock spec): real round-trip happy-path gate — board re-renders, zero [gl1] lines, zero INVALID_OPERATION. (The raytraced image itself never displays on the wasm build — the pre-existing inert-toggle KNOWN ISSUE in 3d-viewer-deadlock.spec.ts, out of scope here; the engine switch and the poisoning reload path run regardless.) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> |
||
| .. | ||
| bindings | ||
| cli | ||
| cmake | ||
| editor | ||
| gl1 | ||
| kiplatform | ||
| ngspice-service | ||
| occ-service | ||
| shims | ||
| stubs | ||
| tools | ||
| README.md | ||
WASM Compatibility Layer
This directory contains WASM-specific implementations that allow KiCad to run in a web browser while keeping our KiCad fork as close to upstream as possible.
Principle
Instead of patching KiCad source files, we:
- Provide alternative implementations for platform-specific code (kiplatform)
- Stub out libraries/features that can't work in the browser (libgit2, curl, nng, scripting, 3D viewer, ...)
- Expose KiCad to JavaScript via Embind bindings
- Override host package detection during cross-compilation (cmake find-modules)
The KiCad-side hooks for this are small if(EMSCRIPTEN) branches in KiCad's own
CMakeLists that pull sources from this directory — see "How it's wired" below.
Directory Structure
wasm/
├── README.md # This file
├── kiplatform/ # Platform abstraction implementations (compiled into KiCad)
│ ├── app.cpp # App lifecycle (paths, startup)
│ ├── drivers.cpp # GPU detection (returns "WebGL")
│ ├── environment.cpp # Environment variables
│ ├── io.cpp # File I/O (WASM virtual filesystem)
│ ├── policy.cpp # Security policy (always permissive)
│ ├── secrets.cpp # Credential storage
│ ├── sysinfo.cpp # System information
│ ├── printing.cpp # Print support (browser print())
│ └── ui.cpp # UI helpers
├── bindings/ # Embind bindings exposing each app to JavaScript
│ ├── pcbnew_embind.cpp
│ ├── eeschema_embind.cpp
│ ├── pl_editor_embind.cpp
│ └── calculator_embind.cpp
├── stubs/ # Stub implementations + header shims for unavailable deps
│ ├── *.c / *.cpp # libgit2, curl, nng, scripting, 3D viewer, frame stubs, ...
│ ├── char_traits_uint16_workaround.h
│ └── GL/ nng/ ngspice/ # Header stubs found via include paths
└── cmake/ # CMake find-module overrides for cross-compilation
└── Find*.cmake / Use*.cmake
How it's wired
kiplatform — compiled into KiCad
The kiplatform/*.cpp files are added directly to KiCad's kiplatform library by an
if(EMSCRIPTEN) branch in kicad/libs/kiplatform/CMakeLists.txt, which references
them as ${PROJECT_SOURCE_DIR}/../wasm/kiplatform/*.cpp. There is no separate
libkiplatform_wasm.a.
stubs — compiled by the build script and KiCad CMakeLists
scripts/kicad/build-kicad-target.sh compiles the C stubs (libgit2_stub.c,
curl_stub.c, nng_stub.c) and force-includes char_traits_uint16_workaround.h.
App-specific *_frame_stub.cpp / *_scripting_stub.cpp are picked up per app, and
the remaining *_stub.cpp files are pulled in by if(EMSCRIPTEN) branches in the
KiCad fork's own CMakeLists. Header stubs under GL/, nng/, ngspice/ are resolved
via include paths.
bindings — per app
build-kicad-target.sh compiles wasm/bindings/<app>_embind.cpp for the app being
built (apps without an embind file get an empty placeholder object).
cmake — module path
build-kicad-target.sh passes -DCMAKE_MODULE_PATH="${PROJECT_ROOT}/wasm/cmake" so
the WASM find-module stubs override host package detection.
Coroutine/fiber support is not in this directory — it comes from the KiCad fork's
kicad/thirdparty/libcontext/libcontext.cpp(LIBCONTEXT_PLATFORM_wasm32). The GLU tesselator comes fromkicad/libs/kimath/glu_tess/glu_tess_impl.cpp.
Adding New Implementations
- Create the implementation file in the appropriate directory (
kiplatform/,stubs/,bindings/). - Wire it in: a stub C file goes in
build-kicad-target.sh; a kiplatform/app source goes in the relevantif(EMSCRIPTEN)branch of the KiCad-side CMakeLists. - Ensure the header interface matches KiCad's expected interface.
- Test with a minimal build before full integration.