Make the Playwright e2e + kicad suites deterministic so screenshot flake stops tracing to timing races. - Blind page.waitForTimeout -> condition waits (expect.poll, web-first assertions, waitUntil) + readiness helpers (waitForWxApp, waitForCanvasApp). Remaining sleeps are documented interaction dwells (annotated). - Defensive "if element exists" branches -> loud asserts; label-fallback chains -> normalized clickMenuItemByText. First-run wizard for/if loops removed by seeding calculator/gerbview/pcbnew HTMLs. - Screenshots: new stableShot(page, name) settles the render in-page (canvas hash over rAF) then writes a raw PNG to test-results/ for the existing offline gate (tools/screenshots vs baseline-screenshots). Replaces toHaveScreenshot, which did inline compare + its own baselines and had decoupled the specs from the real gate. scale:'css' pinned. - retries: 0 in both configs. - Guard: tests/tools/lint-determinism.ts (npm run lint:determinism) bans blind sleeps / toHaveScreenshot / inline retries / swallowed catches in specs; documented exceptions carry a marker. Rules in tests/TESTING.md. Assertions, coverage, and renders unchanged (semantic-equivalence reviewed; captures pixel-identical modulo inherent timer/timestamp/3d-raytrace variance). Both suites green at retries:0 (e2e 340, kicad 92); ~35-61% faster. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BVX1pHMvRPYHdp6ZfEawrk
165 lines
7.7 KiB
TypeScript
165 lines
7.7 KiB
TypeScript
import type { Page } from '@playwright/test';
|
|
import { test, expect } from './fixtures';
|
|
import { clickMenuBarItem, clickMenuItem, waitForEditorReady, waitUntil, stableShot } from '../e2e/utils/element-tracker';
|
|
import { injectFromSubmodule } from './utils/fs-inject';
|
|
import { waitForBoardLoaded } from './utils/board-ready';
|
|
|
|
/** Wait for a rendered popup menu to have its items (replaces a fixed post-menu-click sleep). */
|
|
async function waitForMenuItems(page: Page): Promise<void> {
|
|
await waitUntil(
|
|
page,
|
|
() => {
|
|
const r = window.wxElementRegistry;
|
|
if (!r?.findAllRendered) return false;
|
|
return r.findAllRendered({ elementType: 'menuitem' }).length > 3;
|
|
},
|
|
'popup menu items rendered',
|
|
);
|
|
}
|
|
|
|
/**
|
|
* STEP export through the occ_service worker (docs/features/occ-split/):
|
|
* pcbnew.wasm carries no OCC — DIALOG_EXPORT_STEP's browser branch runs
|
|
* EXPORTER_STEP, whose WASM shadow suspends via EM_ASYNC_JS and hands the
|
|
* job to `globalThis.occService` (worker with its own OCC-linked module).
|
|
*
|
|
* Asserted end to end:
|
|
* 1. occ_service.{js,wasm} is NOT fetched at boot or board load — only the
|
|
* export click triggers it (the lazy-load boundary).
|
|
* 2. The (unchanged) export dialog drives the whole chain: menu → dialog →
|
|
* Export button → worker → STEP bytes.
|
|
* 3. The result is a real STEP file (ISO-10303-21 magic, non-trivial size),
|
|
* captured by the provider stub where the app would download it.
|
|
*/
|
|
|
|
const KICAD_VERSION_DIR = '10.0';
|
|
const PROJECT_DIR_MEMFS = `/home/kicad/documents/kicad/${KICAD_VERSION_DIR}/projects`;
|
|
|
|
const DEMO = { name: 'pic_programmer', dir: 'pic_programmer', stem: 'pic_programmer' } as const;
|
|
|
|
async function loadBoard(page: Page, testLogger: { consoleLogs: string[]; errors: string[] }): Promise<void> {
|
|
const pcbFilename = `${DEMO.stem}.kicad_pcb`;
|
|
const proFilename = `${DEMO.stem}.kicad_pro`;
|
|
|
|
await injectFromSubmodule(page, `kicad/demos/${DEMO.dir}/${pcbFilename}`,
|
|
`${PROJECT_DIR_MEMFS}/${pcbFilename}`);
|
|
await injectFromSubmodule(page, `kicad/demos/${DEMO.dir}/${proFilename}`,
|
|
`${PROJECT_DIR_MEMFS}/${proFilename}`);
|
|
|
|
expect(await clickMenuBarItem(page, 'File'), 'File menu should be findable').toBe(true);
|
|
await waitForMenuItems(page);
|
|
expect(await clickMenuItem(page, 'Open...'), 'Open… menu item should be findable').toBe(true);
|
|
|
|
await page.waitForFunction(() => {
|
|
const registry = window.wxElementRegistry;
|
|
return !!registry && registry.findAll({ visible: true })
|
|
.some((el) => el.typeName === 'wxFileDialog');
|
|
}, null, { timeout: 15000 });
|
|
// Wait for the filename text input to paint (the dialog object exists before its
|
|
// inner controls register; replaces a fixed 1000ms).
|
|
await waitUntil(page, () => {
|
|
const r = window.wxElementRegistry;
|
|
return !!r && r.findAll({ visible: true }).some((el) => el.typeName === 'wxTextCtrl' && el.name === 'text');
|
|
}, 'file dialog filename input');
|
|
|
|
const filenameInput = await page.evaluate(() => {
|
|
const registry = window.wxElementRegistry;
|
|
if (!registry) return null;
|
|
const text = registry.findAll({ visible: true })
|
|
.find((el) => el.typeName === 'wxTextCtrl' && el.name === 'text');
|
|
return text ? { x: text.centerX, y: text.centerY } : null;
|
|
});
|
|
expect(filenameInput, 'filename text input should be visible').not.toBeNull();
|
|
if (!filenameInput) throw new Error('filename text input not found');
|
|
|
|
await page.mouse.click(filenameInput.x, filenameInput.y);
|
|
// Documented interaction dwells: focus + typed-text registration have no observable signal.
|
|
await page.waitForTimeout(200); // eslint-disable-line -- documented interaction dwell
|
|
await page.keyboard.type(pcbFilename);
|
|
await page.waitForTimeout(300); // eslint-disable-line -- documented interaction dwell
|
|
await page.keyboard.press('Enter');
|
|
|
|
const result = await waitForBoardLoaded(page, testLogger, 60000);
|
|
console.log(`[TEST] ${DEMO.name} board-ready result: ${result}`);
|
|
}
|
|
|
|
/** Click a visible wx button by label; returns whether it was found. */
|
|
async function clickWxButton(page: Page, label: string): Promise<boolean> {
|
|
const pos = await page.evaluate((wanted: string) => {
|
|
const registry = window.wxElementRegistry;
|
|
if (!registry) return null;
|
|
const el = registry.findAll({ visible: true })
|
|
.find((e) => (e.label === wanted || e.label === `&${wanted}`)
|
|
&& (e.typeName ?? '').includes('Button'));
|
|
return el ? { x: el.centerX, y: el.centerY } : null;
|
|
}, label);
|
|
if (!pos) return false;
|
|
await page.mouse.click(pos.x, pos.y);
|
|
return true;
|
|
}
|
|
|
|
test.describe('OCC export via occ_service worker', () => {
|
|
test.describe.configure({ mode: 'serial' });
|
|
test.setTimeout(240000);
|
|
|
|
test('export dialog produces a valid STEP; occ_service fetches lazily', async ({ page, testLogger }) => {
|
|
// Track occ_service fetches from the very start — the lazy boundary is
|
|
// the core assertion.
|
|
const occFetches: string[] = [];
|
|
page.on('request', (r) => {
|
|
if (r.url().includes('occ_service')) occFetches.push(r.url());
|
|
});
|
|
|
|
await page.goto('/kicad/pcbnew.html');
|
|
await waitForEditorReady(page);
|
|
await loadBoard(page, testLogger);
|
|
|
|
expect(occFetches, 'occ_service must NOT be fetched before the export').toHaveLength(0);
|
|
|
|
// File → Export → STEP/GLB/…
|
|
expect(await clickMenuBarItem(page, 'File'), 'File menu').toBe(true);
|
|
await waitForMenuItems(page);
|
|
expect(await clickMenuItem(page, 'Export'), 'Export submenu').toBe(true);
|
|
await waitForMenuItems(page);
|
|
expect(await clickMenuItem(page, 'STEP/GLB/BREP/XAO/PLY/STL...'),
|
|
'STEP export menu item').toBe(true);
|
|
|
|
// The (unchanged) DIALOG_EXPORT_STEP: wait for its Export button.
|
|
await page.waitForFunction(() => {
|
|
const registry = window.wxElementRegistry;
|
|
return !!registry && registry.findAll({ visible: true })
|
|
.some((el) => (el.label === 'Export' || el.label === '&Export')
|
|
&& (el.typeName ?? '').includes('Button'));
|
|
}, null, { timeout: 20000 });
|
|
await stableShot(page, 'occ-export-dialog.png');
|
|
|
|
expect(await clickWxButton(page, 'Export'), 'Export button click').toBe(true);
|
|
|
|
// The provider stub captures the bytes where the app would download.
|
|
await page.waitForFunction(
|
|
() => ((window as any).__occExports?.length ?? 0) > 0,
|
|
null, { timeout: 180000 });
|
|
|
|
const exports = await page.evaluate(() => (window as any).__occExports as Array<{
|
|
name: string; size: number; magic: string;
|
|
}>);
|
|
console.log(`[TEST] captured exports: ${JSON.stringify(exports)}`);
|
|
|
|
expect(exports).toHaveLength(1);
|
|
expect(exports[0].name, 'download name comes from the dialog')
|
|
.toMatch(/\.step$/i);
|
|
expect(exports[0].magic.startsWith('ISO-10303-21'), 'STEP magic').toBe(true);
|
|
expect(exports[0].size, 'non-trivial STEP body').toBeGreaterThan(10_000);
|
|
|
|
expect(occFetches.length, 'occ_service was fetched lazily by the export')
|
|
.toBeGreaterThan(0);
|
|
|
|
// Dismiss the "Export complete" report dialog if present. Its appearance after
|
|
// the worker returns has no distinct registry signal to poll — a short documented
|
|
// dwell, then click OK if present.
|
|
await page.waitForTimeout(1000); // eslint-disable-line -- documented interaction dwell
|
|
await clickWxButton(page, 'OK');
|
|
|
|
await stableShot(page, 'occ-export-done.png');
|
|
});
|
|
});
|