Squash of experiment/ff-big-modules vs main.
Big-module routing removed: native-EH shrank kicad_editor below
SpiderMonkey's x86-64 code budget (runs 29355049705/29356152413 green on
stock Firefox), so BIG_MODULE_SPECS routing and the baseline-only-JIT
crutch are gone — kicad-firefox and kicad-chromium both run the full
suite, with the module compiled the way real users' browsers compile it.
Per-engine screenshots end to end: stableShot/shotPath write
test-results/<engine>/<name>.png; baselines move to
baseline-screenshots/{chromium,firefox}/ and the whole tools/screenshots
pipeline (compare/promote/manifest/spec-map/changelog/Discord) keys on
<engine>/<name>. Previously Firefox and Chromium renders of one spec
overwrote each other and Firefox renders were never actually gated.
Seeded from CI run 29421380806 (92 new firefox baselines, +24 chromium
web-suite shots); manifest generated from the baseline tree.
One merged playwright.config.ts (kicad/asyncify/coroutine/perf as
projects); ~25 dead npm scripts dropped. The web suite is gated in CI for
the first time ever (4 rotted specs fixed, 5 broken lib-bridge specs
triaged as fixme in docs/features/web-e2e-rot/); cheap lint step after
npm ci; last 26 blind-sleep violations fixed.
SwiftShader retired: CI Chromium renders WebGL on ANGLE → Mesa llvmpipe
(--use-gl=angle --use-angle=gl --ignore-gpu-blocklist; the blocklist flag
is mandatory — llvmpipe is blocklisted and WebGL is silently unavailable
without it) in BOTH configs. Under WORKERS=4 congestion SwiftShader
transiently failed the first post-board-load draw and the recovery
cascade ended in a silent permanent Cairo fallback — that engine flip was
the "~1.2% changedRatio both directions" occ-export baseline flake.
Validated 160/160 across two 80-repeat rigs; full analysis in
docs/features/wx-parity-bugs/occ-export-context-eviction.md. Chromium
baselines shift slightly on llvmpipe — promote once from the first green
run. Deflakes the new coverage exposed: presence baselines settle before
capture; presence fixtures declare current file formats; perf gets its
own outputDir so CI evidence survives; occ-export settles the board paint
before the export dialog; menu-item waits (waitForRenderedByLabel before
clickMenuItem) in 4 specs + the TESTING.md rule.
Web suite runs the PROD build, in parallel: webServer becomes backend
`start` + the standalone's e2e:preview (build-preview.mjs: link-wasm →
stash the public/wasm symlink aside during vite build, build-demo.mjs's
move — then vite preview as the persistent server). The wasm middleware
serves /wasm/* in preview and emits COOP/COEP/CORP itself (a pthread
worker script's own response must carry COEP or Chrome kills it with
ERR_BLOCKED_BY_RESPONSE). VITE_* flags bake at build time;
VITE_ALLOW_USER_OVERRIDE joins turbo globalEnv. fullyParallel + default
workers: 5.2m → 1.4m. Determinism fixes the parallel run exposed:
shared-page specs become serial groups; locks.spec grabs alice's exact
item via the new kicadCollabTestSelectByUuid hook (cross-tab "first
footprint" order is not a ysync invariant); quit specs poll page.url()
(quit supersedes its own navigation — NS_BINDING_ABORTED on Firefox).
Suite: 51 passed / 12 skipped / 0 failed in 1.6m.
CI-coverage gate (lint:ci-coverage): every tests/**/*.spec.ts must be
reachable from the npm scripts the workflows invoke — scraped from
.github/workflows/, resolved through package.json, coverage asked from
playwright --list itself. Rules: uncovered-spec + orphan-project (with a
documented LOCAL_ONLY_PROJECTS allowlist). Gating next to
lint:determinism; 138 spec files / 13 projects accounted for.
Product fixes kept from the investigations (reachable on real GPUs too):
wx 7799fd1be5 — paint flags clear before dispatch + Invalidate always
propagates; kicad 3dcfea5e45 — SwiftShader pass-boundary flush +
per-instance font texture + first-frame GL-error drain (GAL recovery
recovers instead of falling back to Cairo) + the user-facing eeschema
switch navigates again under __EMSCRIPTEN__ (project-sync's
FaceRegistered gate had rerouted it into the hidden sync player; caught
by the newly-gated web suite).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018eUxiPApHgGiu9NFyQfhAq
88 lines
3.9 KiB
TypeScript
88 lines
3.9 KiB
TypeScript
import { test, expect, type Page } from '@playwright/test';
|
|
import { shotPath } from '../e2e/utils/element-tracker';
|
|
|
|
/**
|
|
* Web-app tool open-path e2e.
|
|
*
|
|
* Drives the real React app (not the standalone harness): for each tool, navigate
|
|
* to its route, let WasmTool boot the tool in-document and (for file tools)
|
|
* auto-open the demo file via Module.kicadOpenFile, then assert the editor came up
|
|
* with the expected title, a painted canvas, no first-run wizard, and no WASM abort
|
|
* or URL-regex modal. Fixtures live in the committed "demo" project (seed-data/),
|
|
* ensured by global-setup-web.ts.
|
|
*/
|
|
|
|
/** Scope segment for the demo project (the reference backend serves it for any). */
|
|
const SCOPE = 'default';
|
|
|
|
interface ToolCase {
|
|
/** URL tail after /:scope/projects/demo/ — a file path (tool inferred from the
|
|
* extension) for file tools, or `-/<tool>` for a file-less boot. */
|
|
route: string;
|
|
/** title the document settles on once the tool is up / file is open */
|
|
titleRe: RegExp;
|
|
/** file tools must drop "untitled"; file-less tools just need to boot */
|
|
fileless: boolean;
|
|
}
|
|
|
|
const CASES: Record<string, ToolCase> = {
|
|
eeschema: { route: 'demo.kicad_sch', titleRe: /demo — Schematic Editor/i, fileless: false },
|
|
pcbnew: { route: 'demo.kicad_pcb', titleRe: /demo — PCB Editor/i, fileless: false },
|
|
pl_editor: { route: 'demo.kicad_wks', titleRe: /demo — Drawing Sheet Editor/i, fileless: false },
|
|
calculator: { route: '-/calculator', titleRe: /Calculator Tools/i, fileless: true },
|
|
symbol_editor: { route: '-/symbol_editor', titleRe: /Symbol Editor/i, fileless: true },
|
|
footprint_editor: { route: '-/footprint_editor', titleRe: /Footprint Editor/i, fileless: true },
|
|
gerbview: { route: '-/gerbview', titleRe: /Gerber Viewer/i, fileless: true },
|
|
};
|
|
|
|
/** Console text that must never appear (wizard-crash + URL-regex modal markers). */
|
|
const FORBIDDEN = /Aborted\(|Invalid regular expression|code points 0xd800|func is not a function/i;
|
|
|
|
async function bootAndAssert(page: Page, tc: ToolCase): Promise<void> {
|
|
const consoleLines: string[] = [];
|
|
page.on('console', (m) => consoleLines.push(m.text()));
|
|
page.on('pageerror', (e) => consoleLines.push(`pageerror: ${e.message}`));
|
|
|
|
await page.goto(`/${SCOPE}/projects/demo/${tc.route}`);
|
|
|
|
// boot.ts mounts the Emscripten <canvas id="canvas"> once the runtime starts.
|
|
await expect(page.locator('#canvas')).toBeVisible({ timeout: 120000 });
|
|
|
|
// The wasm sets the document title once the frame is up (and, for file tools,
|
|
// once OpenProjectFiles finishes). Poll until it matches.
|
|
await expect
|
|
.poll(() => page.title(), {
|
|
message: `${tc.route}: editor never reached expected title`,
|
|
timeout: 120000,
|
|
intervals: [1000],
|
|
})
|
|
.toMatch(tc.titleRe);
|
|
|
|
// File tools must have actually loaded the file (title no longer "untitled").
|
|
if (!tc.fileless) {
|
|
expect(await page.title(), 'file should be open (title not untitled)').not.toMatch(/untitled/i);
|
|
}
|
|
|
|
// No first-run setup wizard should be visible (config seed must have skipped it).
|
|
const wizardVisible = await page.evaluate(() => {
|
|
const reg = (window as unknown as { wxElementRegistry?: { findAll(f: object): { typeName: string }[] } })
|
|
.wxElementRegistry;
|
|
if (!reg) return 0;
|
|
return reg.findAll({ visible: true }).filter((e) => /^wxDialog|Wizard/.test(e.typeName)).length;
|
|
});
|
|
expect(wizardVisible, 'no setup wizard/dialog should be visible').toBe(0);
|
|
|
|
const offending = consoleLines.filter((l) => FORBIDDEN.test(l));
|
|
expect(offending, `forbidden console output:\n${offending.join('\n')}`).toHaveLength(0);
|
|
}
|
|
|
|
test.describe('web app — tool open paths', () => {
|
|
for (const [tool, tc] of Object.entries(CASES)) {
|
|
test(`${tool}: ${tc.fileless ? 'boots file-less' : 'opens its demo file'} wizard-free`, async ({
|
|
page,
|
|
}) => {
|
|
await bootAndAssert(page, tc);
|
|
await page.screenshot({ path: shotPath(page, `web-${tool}.png`), scale: 'css' });
|
|
});
|
|
}
|
|
});
|