pcbjam/tests/e2e/contextmenu.spec.ts
Viktor Vaczi 63ed1f3c1f e2e/CI: dual-engine suites, per-engine screenshots, SwiftShader retired, prod web suite, CI-coverage gate
Squash of experiment/ff-big-modules vs main.

Big-module routing removed: native-EH shrank kicad_editor below
SpiderMonkey's x86-64 code budget (runs 29355049705/29356152413 green on
stock Firefox), so BIG_MODULE_SPECS routing and the baseline-only-JIT
crutch are gone — kicad-firefox and kicad-chromium both run the full
suite, with the module compiled the way real users' browsers compile it.

Per-engine screenshots end to end: stableShot/shotPath write
test-results/<engine>/<name>.png; baselines move to
baseline-screenshots/{chromium,firefox}/ and the whole tools/screenshots
pipeline (compare/promote/manifest/spec-map/changelog/Discord) keys on
<engine>/<name>. Previously Firefox and Chromium renders of one spec
overwrote each other and Firefox renders were never actually gated.
Seeded from CI run 29421380806 (92 new firefox baselines, +24 chromium
web-suite shots); manifest generated from the baseline tree.

One merged playwright.config.ts (kicad/asyncify/coroutine/perf as
projects); ~25 dead npm scripts dropped. The web suite is gated in CI for
the first time ever (4 rotted specs fixed, 5 broken lib-bridge specs
triaged as fixme in docs/features/web-e2e-rot/); cheap lint step after
npm ci; last 26 blind-sleep violations fixed.

SwiftShader retired: CI Chromium renders WebGL on ANGLE → Mesa llvmpipe
(--use-gl=angle --use-angle=gl --ignore-gpu-blocklist; the blocklist flag
is mandatory — llvmpipe is blocklisted and WebGL is silently unavailable
without it) in BOTH configs. Under WORKERS=4 congestion SwiftShader
transiently failed the first post-board-load draw and the recovery
cascade ended in a silent permanent Cairo fallback — that engine flip was
the "~1.2% changedRatio both directions" occ-export baseline flake.
Validated 160/160 across two 80-repeat rigs; full analysis in
docs/features/wx-parity-bugs/occ-export-context-eviction.md. Chromium
baselines shift slightly on llvmpipe — promote once from the first green
run. Deflakes the new coverage exposed: presence baselines settle before
capture; presence fixtures declare current file formats; perf gets its
own outputDir so CI evidence survives; occ-export settles the board paint
before the export dialog; menu-item waits (waitForRenderedByLabel before
clickMenuItem) in 4 specs + the TESTING.md rule.

Web suite runs the PROD build, in parallel: webServer becomes backend
`start` + the standalone's e2e:preview (build-preview.mjs: link-wasm →
stash the public/wasm symlink aside during vite build, build-demo.mjs's
move — then vite preview as the persistent server). The wasm middleware
serves /wasm/* in preview and emits COOP/COEP/CORP itself (a pthread
worker script's own response must carry COEP or Chrome kills it with
ERR_BLOCKED_BY_RESPONSE). VITE_* flags bake at build time;
VITE_ALLOW_USER_OVERRIDE joins turbo globalEnv. fullyParallel + default
workers: 5.2m → 1.4m. Determinism fixes the parallel run exposed:
shared-page specs become serial groups; locks.spec grabs alice's exact
item via the new kicadCollabTestSelectByUuid hook (cross-tab "first
footprint" order is not a ysync invariant); quit specs poll page.url()
(quit supersedes its own navigation — NS_BINDING_ABORTED on Firefox).
Suite: 51 passed / 12 skipped / 0 failed in 1.6m.

CI-coverage gate (lint:ci-coverage): every tests/**/*.spec.ts must be
reachable from the npm scripts the workflows invoke — scraped from
.github/workflows/, resolved through package.json, coverage asked from
playwright --list itself. Rules: uncovered-spec + orphan-project (with a
documented LOCAL_ONLY_PROJECTS allowlist). Gating next to
lint:determinism; 138 spec files / 13 projects accounted for.

Product fixes kept from the investigations (reachable on real GPUs too):
wx 7799fd1be5 — paint flags clear before dispatch + Invalidate always
propagates; kicad 3dcfea5e45 — SwiftShader pass-boundary flush +
per-instance font texture + first-frame GL-error drain (GAL recovery
recovers instead of falling back to Cairo) + the user-facing eeschema
switch navigates again under __EMSCRIPTEN__ (project-sync's
FaceRegistered gate had rerouted it into the hidden sync player; caught
by the newly-gated web suite).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018eUxiPApHgGiu9NFyQfhAq
2026-07-17 12:21:54 +02:00

94 lines
4 KiB
TypeScript

// Context-menu (DoPopupMenu) e2e — right-click pops a DOM popup, items route
// wxEVT_MENU back to the handler, and outside-click/Escape cancels.
import { test, expect, tryLoadApp, getCanvasBox } from './utils/fixtures';
import { findRenderedByType, clickMenuItem, shotPath } from './utils/element-tracker';
async function rightClickCanvasCentre(page: import('@playwright/test').Page) {
const box = await getCanvasBox(page);
const x = Math.round(box.x + box.width / 2);
const y = Math.round(box.y + box.height / 2);
await page.mouse.click(x, y, { button: 'right' });
return { x, y };
}
async function popupItemCount(page: import('@playwright/test').Page): Promise<number> {
const items = await findRenderedByType(page, 'menuitem', { parentId: 'popupmenu' });
return items.length;
}
test.describe('DOM-port context menu', () => {
test.beforeEach(async ({ page }) => {
await page.goto('/standalone/contextmenu/contextmenu_test.html');
expect(await tryLoadApp(page, 30000), 'context-menu app should load').toBe(true);
await expect
.poll(() => true, { timeout: 1000 })
.toBe(true);
});
test('right-click opens the menu with the expected items', async ({ page, testLogger }) => {
await rightClickCanvasCentre(page);
// The popup builds its rows + registers them in a requestAnimationFrame.
await expect.poll(() => popupItemCount(page), {
timeout: 8000,
message: 'context menu items should register',
}).toBeGreaterThanOrEqual(4); // Cut, Snap to grid, Paste, More (separators excluded)
const items = await findRenderedByType(page, 'menuitem', { parentId: 'popupmenu' });
const labels = items.map((i) => i.label);
expect(labels).toContain('Cut');
expect(labels).toContain('Snap to grid');
expect(labels).toContain('More');
// The disabled "Paste" item registers but is not enabled.
const paste = items.find((i) => i.label === 'Paste');
expect(paste, 'Paste should be present').toBeTruthy();
expect(paste!.enabled, 'Paste should be disabled').toBe(false);
await page.screenshot({ path: shotPath(page, 'contextmenu-01-open.png'), fullPage: true });
expect(testLogger.errors.filter((e) => !e.includes('favicon'))).toHaveLength(0);
});
test('choosing an item routes wxEVT_MENU to the handler', async ({ page, testLogger }) => {
await rightClickCanvasCentre(page);
await expect.poll(() => popupItemCount(page), { timeout: 8000 }).toBeGreaterThanOrEqual(4);
expect(await clickMenuItem(page, 'Cut'), 'Cut should be clickable').toBe(true);
await expect.poll(
() => testLogger.consoleLogs.some((l) => l.includes('[CTXMENU_EVENT] Cut chosen')),
{ timeout: 8000, message: 'the Cut handler should fire' },
).toBe(true);
// The popup is dismissed after a choice.
await expect.poll(() => popupItemCount(page), { timeout: 4000 }).toBe(0);
});
test('a checkable item toggles and reports its new state', async ({ page, testLogger }) => {
await rightClickCanvasCentre(page);
await expect.poll(() => popupItemCount(page), { timeout: 8000 }).toBeGreaterThanOrEqual(4);
expect(await clickMenuItem(page, 'Snap to grid')).toBe(true);
await expect.poll(
() => testLogger.consoleLogs.some((l) => l.includes('[CTXMENU_EVENT] Snap to grid ON')),
{ timeout: 8000, message: 'the check item should toggle ON' },
).toBe(true);
});
test('Escape cancels without firing a command', async ({ page, testLogger }) => {
await rightClickCanvasCentre(page);
await expect.poll(() => popupItemCount(page), { timeout: 8000 }).toBeGreaterThanOrEqual(4);
const before = testLogger.consoleLogs.filter((l) => l.includes('chosen')).length;
await page.keyboard.press('Escape');
await expect.poll(() => popupItemCount(page), {
timeout: 4000,
message: 'Escape should dismiss the popup',
}).toBe(0);
const after = testLogger.consoleLogs.filter((l) => l.includes('chosen')).length;
expect(after, 'no command should fire on cancel').toBe(before);
});
});