pcbjam/tests/e2e/pickers.spec.ts
Viktor Vaczi 4c3a4cacd4 test(determinism): deterministic waits + stableShot screenshots; drop blind sleeps/ifs/retries
Make the Playwright e2e + kicad suites deterministic so screenshot flake stops
tracing to timing races.

- Blind page.waitForTimeout -> condition waits (expect.poll, web-first
  assertions, waitUntil) + readiness helpers (waitForWxApp, waitForCanvasApp).
  Remaining sleeps are documented interaction dwells (annotated).
- Defensive "if element exists" branches -> loud asserts; label-fallback chains
  -> normalized clickMenuItemByText. First-run wizard for/if loops removed by
  seeding calculator/gerbview/pcbnew HTMLs.
- Screenshots: new stableShot(page, name) settles the render in-page (canvas
  hash over rAF) then writes a raw PNG to test-results/ for the existing offline
  gate (tools/screenshots vs baseline-screenshots). Replaces toHaveScreenshot,
  which did inline compare + its own baselines and had decoupled the specs from
  the real gate. scale:'css' pinned.
- retries: 0 in both configs.
- Guard: tests/tools/lint-determinism.ts (npm run lint:determinism) bans blind
  sleeps / toHaveScreenshot / inline retries / swallowed catches in specs;
  documented exceptions carry a marker. Rules in tests/TESTING.md.

Assertions, coverage, and renders unchanged (semantic-equivalence reviewed;
captures pixel-identical modulo inherent timer/timestamp/3d-raytrace variance).
Both suites green at retries:0 (e2e 340, kicad 92); ~35-61% faster.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BVX1pHMvRPYHdp6ZfEawrk
2026-07-07 10:50:24 +02:00

49 lines
1.8 KiB
TypeScript

// wxColourPickerCtrl/wxFontPickerCtrl Tests - Color and font pickers for KiCad
import { test, expect, waitForWxApp } from './utils/fixtures';
import { stableShot } from './utils/element-tracker';
test.describe('wxPicker Controls Tests', () => {
test('Pickers test app loads successfully', async ({ page, testLogger }) => {
await page.goto('/standalone/pickers/pickers_test.html');
await waitForWxApp(page);
await stableShot(page, 'pickers-01-loaded.png', { fullPage: true });
const hasStartup = testLogger.consoleLogs.some(l => l.includes('PICKERS_TEST'));
expect(testLogger.errors.filter(e => !e.includes('favicon'))).toHaveLength(0);
});
test('Color pickers are visible', async ({ page, testLogger }) => {
await page.goto('/standalone/pickers/pickers_test.html');
await waitForWxApp(page);
// Check startup logged (deterministic: poll the SAME console event the spec asserted)
await expect
.poll(
() => testLogger.consoleLogs.some(l => l.includes('Picker controls test app started')),
{ message: 'Picker controls should initialize' }
)
.toBe(true);
await stableShot(page, 'pickers-02-colors.png', { fullPage: true });
});
test('Font picker is visible', async ({ page, testLogger }) => {
await page.goto('/standalone/pickers/pickers_test.html');
await waitForWxApp(page);
// Font picker should be part of the UI
await stableShot(page, 'pickers-03-font.png', { fullPage: true });
});
test('Color preview panel exists', async ({ page, testLogger }) => {
await page.goto('/standalone/pickers/pickers_test.html');
await waitForWxApp(page);
// The preview panel should exist and be colored
await stableShot(page, 'pickers-04-preview.png', { fullPage: true });
});
});