pcbjam/tests/web/footprint-write-spike.spec.ts
Viktor Vaczi 3ee174e9b4 tests: un-skip sweep — 26 tests revived on the JSPI build, failures re-gated with fresh evidence
Empirical pass over every skip/fixme whose premise the JSPI migration
could have changed. Revived (verified green):

- Firefox wasm-budget guards RETIRED (drift-trio, drift-trio-fuzz,
  drift-trio-scenarios, ysync-two-tab, ysync-libsymbols): the JSPI
  build (~half the asyncify size) fits three editor tabs inside
  Firefox 153's per-process budget — +20 firefox collab tests.
- roundtrip 'pcbnew preserves items through a yjs round trip': the
  asyncify-fragile envelope parse it waited on is gone — both engines.
- drift-trio-scenarios S4/S4b: converge now (was KNOWN ~5-8%).
- pcbnew-collab + eeschema-collab 'a local move propagates A→B'.
- web eeschema-fp-selector, read-only-editor's fixme'd writer-stream
  test, footprint-browse-remote read path (chromium; firefox gated:
  FootprintEnumerate rows never appear in 60s — slow wasm tier
  suspected).

Still broken, re-gated with re-verified reasons:

- 3d-viewer raytracer engine toggle: still inert, both engines.
- maximize display geometry: wxDisplay reports 0x0 in the harness.
- web editor WRITE bridge (symbol/footprint × remote/spike): wedges at
  the New Symbol/Footprint dialog step on both engines — the
  web-e2e-rot 01 gap stands for writes.

Verify runs: kicad+wx touched files 93 passed / 0 failed / 7 skipped
(intended gates); web touched files 7 passed / 0 failed / 9 skipped.
lint:determinism + lint:ci-coverage green.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016X9eh1s5sTx1o9Em9KBuwR
2026-08-13 18:43:36 +02:00

153 lines
8.1 KiB
TypeScript

import { test, expect, type Page } from '@playwright/test';
import { clickByTooltip, waitForWxApp, focusCanvas, stableShot } from '../e2e/utils/element-tracker';
/**
* 0009-S footprint write-path spike: does the FOOTPRINT editor boot+render in
* WASM (with a working Prj()), and does its FootprintSave path route through the
* pcbjam write bridge, on the MAIN thread, without wedging?
*
* Mirrors the proven 0004-A symbol spike, one domain over. Boots the
* project-scoped footprint_editor with `?fpwrite=1` (an in-memory writable
* "My Footprints (spike)" lib via the new PCB_IO_PCBJAM_FP plugin + the 4th
* `kind` bridge arg), creates a new footprint in it, and saves. The plugin's
* FootprintSave serializes a fork-native (footprint …) s-expr and calls
* window.kicadLibs.request("save", …, "footprint") on the main thread
* (EM_ASYNC_JS), captured onto window.__pcbjamSaved. Assert: the body is
* well-formed fork-native s-expr (version 20251028), and the app stays live
* (no abort / no OOM respawn) — i.e. the editor-as-tool + main-thread Asyncify
* save both work. THIS IS THE GATE before the backend (0009-A) is built.
*/
async function bootFootprintEditor(page: Page): Promise<void> {
await page.goto('/default/projects/demo/-/footprint_editor?fpwrite=1');
// GATE part 1: the footprint editor frame renders in WASM (canvas + GL) and the
// wx element registry is populated (deterministic, fails loudly).
await waitForWxApp(page, { timeout: 180000 });
await page.waitForFunction(
() => !!window.wxElementRegistry && window.wxElementRegistry.findAll({}).length > 5,
null,
{ timeout: 180000 },
);
await page.waitForFunction(() => !!(window as any).kicadLibs, null, { timeout: 60000 });
}
// KNOWN-BROKEN: the fp/sym editor kicadLibs enumerate/save flows are dead
// (docs/features/web-e2e-rot/01-editor-lib-bridge-flows.md). fixme, not fail:
// on CI this dies in a 180s boot timeout per engine — running it buys no signal.
// Probed 2026-08-13 on the JSPI build: still dead — wedges at the New Symbol/
// Footprint dialog step on BOTH engines (web-e2e-rot 01 stands for writes).
test.fixme(
'footprint editor save routes through the pcbjam_fp write bridge (main thread)', async ({ page }) => {
const logs: string[] = [];
page.on('console', (m) => logs.push(`[${m.type()}] ${m.text()}`));
page.on('pageerror', (e) => logs.push(`[pageerror] ${e.message}`));
await bootFootprintEditor(page);
await stableShot(page, 'fpwrite-01-boot.png');
// Spike provider is active.
expect(await page.evaluate(() => !!(window as any).__pcbjamSaved), 'spike marker present').toBe(true);
// Select the writable lib in the tree so New Footprint targets it. Same LIB_TREE
// widget as the symbol editor: the dataviewitem's registry y sits on the column
// header, so anchor off the "Item" column header and click one row below it.
const hdr = await page.evaluate(() => {
const rd = window.wxElementRegistry.findAllRendered({});
const h = rd.find((e: any) => e.elementType === 'columnheader' && e.label === 'Item');
return h ? { cx: h.centerX, cy: h.centerY, hgt: h.height } : null;
});
expect(hdr, 'Item column header present').not.toBeNull();
await page.mouse.click(hdr!.cx, hdr!.cy + hdr!.hgt + 8); // focus the tree
await page.waitForTimeout(200); // eslint-disable-line -- documented interaction dwell: tree focus commit
await page.keyboard.press('Home');
await page.waitForTimeout(150); // eslint-disable-line -- documented interaction dwell: tree-nav keystroke commit
await page.keyboard.press('ArrowDown');
await page.waitForTimeout(150); // eslint-disable-line -- documented interaction dwell: tree-nav keystroke commit
await page.keyboard.press('ArrowUp');
await page.waitForTimeout(400); // eslint-disable-line -- documented interaction dwell: tree selection commit
await stableShot(page, 'fpwrite-02-lib-selected.png');
// New Footprint via the toolbar button. The fork action's FriendlyName is
// "New Footprint" (PCB_ACTIONS::newFootprint).
const clicked = await clickByTooltip(page, 'New Footprint');
expect(clicked, 'New Footprint toolbar button clicked').toBe(true);
await page.waitForTimeout(1500); // eslint-disable-line -- documented interaction dwell: New Footprint dialog/creation commit
await stableShot(page, 'fpwrite-03-newfp-dialog.png');
// Diagnostics: what dialog/controls are present now.
const dlg = await page.evaluate(() => {
const all = window.wxElementRegistry.findAll({ visible: true });
const pick = (re: RegExp) => all.filter((e: any) => re.test(e.typeName))
.map((e: any) => ({ type: e.typeName, name: e.name, label: e.label, cx: Math.round(e.centerX), cy: Math.round(e.centerY), en: e.enabled }));
return { dialogs: pick(/Dialog/i), texts: pick(/TextCtrl/i), buttons: pick(/Button/i), combos: pick(/Choice|ComboBox/i) };
});
logs.push(`[spec] after New Footprint: ${JSON.stringify(dlg)}`);
// If a name dialog is present, type our name and confirm with Enter (default
// button). Some flows create directly with a default name — handle both.
const FP = 'SpikeFP';
if (dlg.texts.length > 0) {
const nameField = dlg.texts[0];
await page.mouse.click(nameField.cx, nameField.cy);
await page.waitForTimeout(150); // eslint-disable-line -- documented interaction dwell: name field focus commit
await page.keyboard.press('Control+a');
await page.keyboard.press('Delete');
await page.keyboard.type(FP, { delay: 40 });
await stableShot(page, 'fpwrite-04-name-typed.png');
await page.keyboard.press('Enter');
await page.waitForTimeout(1500); // eslint-disable-line -- documented interaction dwell: dialog confirm / footprint creation commit
}
await stableShot(page, 'fpwrite-05-fp-created.png');
logs.push(`[spec] title after create: ${await page.title()}`);
// Save: focus the canvas, Ctrl+S (the proven save trigger). The New Footprint
// flow may already auto-save into the writable lib; Ctrl+S is belt-and-braces.
await focusCanvas(page);
await page.keyboard.press('Control+s');
// Wait for the bridge to capture the saved body (name-agnostic — the editor may
// massage or default the footprint name).
await page.waitForFunction(
() => {
const saved = (window as any).__pcbjamSaved as Record<string, string> | undefined;
return !!saved && Object.values(saved).some((v) => typeof v === 'string' && v.length > 0);
},
null,
{ timeout: 30000 },
);
await stableShot(page, 'fpwrite-06-saved.png');
const { savedName, body } = await page.evaluate(() => {
const saved = (window as any).__pcbjamSaved as Record<string, string>;
const k = Object.keys(saved).find((n) => saved[n]?.length)!;
return { savedName: k, body: saved[k] };
});
logs.push(`[spec] saved "${savedName}" (${body.length} bytes):\n${body}`);
// The captured body is a well-formed fork-native footprint at the fork's native
// board/footprint file version (20251028) — proves verbatim round-trip, no shim.
expect(body).toContain('(footprint');
expect(body).toContain('(version 20251028)');
expect(body).toContain('(generator "pcbnew")');
expect(body).toContain(savedName);
// No post-save error dialog (the MEMFS placeholder-file fix for the footprint
// editor's setFPWatcher -> GetModificationTime stat).
await page.waitForTimeout(500); // eslint-disable-line -- documented dwell: let any post-save error dialog/log surface before asserting its absence
const errDialog = await page.evaluate(() =>
window.wxElementRegistry
.findAll({ visible: true })
.some((e: any) => /Dialog/i.test(e.typeName) && /Error/i.test(e.label || '')),
);
expect(errDialog, 'no post-save error dialog').toBe(false);
expect(
logs.some((l) => l.includes('Failed to retrieve file times')),
'no file-times error',
).toBe(false);
// App stayed live: no abort, no OOM respawn (the main-thread Asyncify save gate).
expect(logs.some((l) => l.includes('Aborted(')), 'no WASM abort').toBe(false);
expect(new URL(page.url()).searchParams.get('oomRetry'), 'no OOM respawn').toBeNull();
console.log('--- console + spec log ---\n' + logs.join('\n'));
});