pcbjam/tests/kicad/utils/board-ready.ts
Viktor Vaczi 31ff88ee9e tests: load-pcb e2e for microwave + pic_programmer demos
Adds an end-to-end test that drives File→Open in pcbnew, injects
the .kicad_pcb and .kicad_pro files into MEMFS at the dialog's
default starting directory, drives the menu + filename text input
+ Enter accept path, and screenshots the loaded board. Parametrized
for both kicad/demos/microwave (RF polygon footprints) and
kicad/demos/pic_programmer (full multi-IC layout).

Without the rtree fix bumped in via the kicad submodule, the load
would abort on every PCB at rtree.h:1771 Classify; the test asserts
no [RTREE-DIAG] line and no Aborted(. The post-load clipboard
RuntimeError in __asyncjs__js_clipboardHasText is a separate,
pre-existing wasm-port limitation that we explicitly do not regress
on here.

- tests/kicad/load-pcb.spec.ts: serial-mode parametrized spec
- tests/kicad/load-pcb-probe.spec.ts: one-shot diagnostic probe
  for inspecting wxFileDialog state on the canvas
- tests/kicad/utils/fs-inject.ts: FS.writeFile bridge from Node fs
- tests/kicad/utils/board-ready.ts: poll-for-no-dialogs readiness
- tests/baseline-screenshots/load-pcb-*.png: 6 baselines covering
  both demos at pcbnew-ready / dialog-open / loaded states
- features/.../rtree-debug-findings.md: full diagnosis trail with
  an upstream-reportable summary the maintainer can lift verbatim
- kicad submodule bumped to 07d8130d44 (shape_poly_set rtree fix)

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-29 09:51:18 +02:00

71 lines
2.9 KiB
TypeScript

import type { Page } from '@playwright/test';
/**
* Wait for pcbnew to finish opening a board.
*
* Indicators we can rely on with the current wxwidgets-wasm registry:
* 1. The wxFileDialog ("filedlg") that we used to pick the file disappears.
* 2. The wxProgressDialog that KiCad pops up during LoadBoard appears and
* then disappears — this is the most reliable "load complete" signal
* because pcbnew's frame title is set via wxFrame::SetTitle, which the
* WASM registry currently does not capture.
*
* We accept two terminal states:
* - "loaded": progress dialog was seen and then went away while PcbFrame
* stays visible (the happy path).
* - "no-dialogs": no dialogs are visible after the open command — covers
* tiny boards where LoadBoard finishes before the progress dialog paints.
*
* Returns a string describing which path completed, for the test log.
*/
export async function waitForBoardLoaded(
page: Page,
logger: { consoleLogs: string[]; errors: string[] },
timeoutMs = 60000,
): Promise<string> {
const deadline = Date.now() + timeoutMs;
let progressSeen = false;
while (Date.now() < deadline) {
// Surface a WASM abort fast — otherwise the progress dialog never
// goes away and we'd burn the full timeout. KiCad logs the abort
// line through Module.printErr, which our test logger captures as
// a console error. We re-read the live arrays each tick.
const allLines = [...logger.consoleLogs, ...logger.errors];
const abort = allLines.find((l) =>
l.includes('Aborted(') || l.includes('RuntimeError: unreachable')
);
if (abort) {
throw new Error(`WASM aborted during LoadBoard:\n${abort}`);
}
const state = await page.evaluate(() => {
const registry = window.wxElementRegistry;
if (!registry) return { ready: false, dialogs: [] as string[], hasProgress: false, hasFileDlg: false };
const dialogs = registry.findAll({ visible: true })
.filter((el) => /Dialog/.test(el.typeName))
.map((el) => el.typeName);
const hasFileDlg = dialogs.includes('wxFileDialog');
const hasProgress = dialogs.some((t) => /Progress/.test(t));
const hasPcbFrame = registry.findAll({ visible: true })
.some((el) => el.name === 'PcbFrame');
return {
ready: hasPcbFrame && !hasFileDlg && !hasProgress,
dialogs,
hasProgress,
hasFileDlg,
};
});
if (state.hasProgress) {
progressSeen = true;
}
if (state.ready) {
return progressSeen ? 'loaded (progress dialog observed)' : 'loaded (no progress dialog seen)';
}
await page.waitForTimeout(200);
}
throw new Error(`Timed out waiting for board to load after ${timeoutMs}ms`);
}