4c3a4cacd4
Make the Playwright e2e + kicad suites deterministic so screenshot flake stops tracing to timing races. - Blind page.waitForTimeout -> condition waits (expect.poll, web-first assertions, waitUntil) + readiness helpers (waitForWxApp, waitForCanvasApp). Remaining sleeps are documented interaction dwells (annotated). - Defensive "if element exists" branches -> loud asserts; label-fallback chains -> normalized clickMenuItemByText. First-run wizard for/if loops removed by seeding calculator/gerbview/pcbnew HTMLs. - Screenshots: new stableShot(page, name) settles the render in-page (canvas hash over rAF) then writes a raw PNG to test-results/ for the existing offline gate (tools/screenshots vs baseline-screenshots). Replaces toHaveScreenshot, which did inline compare + its own baselines and had decoupled the specs from the real gate. scale:'css' pinned. - retries: 0 in both configs. - Guard: tests/tools/lint-determinism.ts (npm run lint:determinism) bans blind sleeps / toHaveScreenshot / inline retries / swallowed catches in specs; documented exceptions carry a marker. Rules in tests/TESTING.md. Assertions, coverage, and renders unchanged (semantic-equivalence reviewed; captures pixel-identical modulo inherent timer/timestamp/3d-raytrace variance). Both suites green at retries:0 (e2e 340, kicad 92); ~35-61% faster. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BVX1pHMvRPYHdp6ZfEawrk
44 lines
2 KiB
TypeScript
44 lines
2 KiB
TypeScript
import { test, expect } from './fixtures';
|
|
import * as path from 'path';
|
|
import { measureLoad, measureOpenRender, measureFps, setThrottle, recordPerf } from './utils/perf-utils';
|
|
|
|
/**
|
|
* pcbnew runtime-perf (TRACK-ONLY, no gating). Mirrors eeschema-perf for the board editor.
|
|
*
|
|
* Measures the CURRENT build: cold load, open+render of the demo board, and sustained
|
|
* pan/zoom FPS across CPU-throttle rates → tests/test-results/perf-pcbnew.json (CI uploads it).
|
|
* Runs on the Chromium 'perf' project (pcbnew's big module OOMs Firefox/SpiderMonkey anyway,
|
|
* and CDP throttling is Chromium-only). Only asserts booted + opened; never a perf threshold.
|
|
*/
|
|
|
|
const THROTTLES = (process.env.PERF_THROTTLES || '1,4,6').split(',').map(Number);
|
|
const FPS_SECS = parseInt(process.env.PERF_FPS_SECS || '6', 10);
|
|
const DEMO = path.join(__dirname, '..', 'fixtures', 'demo', 'demo.kicad_pcb');
|
|
|
|
test.describe('pcbnew perf', () => {
|
|
test('load + open+render + FPS (track-only)', async ({ page, testLogger }) => {
|
|
test.setTimeout(300000);
|
|
|
|
const loadMs = await measureLoad(page, '/kicad/pcbnew.html');
|
|
console.log(`[perf] pcbnew cold load = ${loadMs} ms`);
|
|
|
|
const openMs = await measureOpenRender(page, DEMO, 'board', testLogger);
|
|
console.log(`[perf] pcbnew open+render = ${openMs} ms`);
|
|
await page.keyboard.press('Escape').catch(() => {}); // eslint-disable-line -- best-effort Escape (may not apply in all states)
|
|
|
|
const cdp = await page.context().newCDPSession(page);
|
|
const fps: { throttle: number; fps: number }[] = [];
|
|
for (const rate of THROTTLES) {
|
|
await setThrottle(cdp, rate);
|
|
const f = await measureFps(page, FPS_SECS);
|
|
console.log(`[perf] pcbnew FPS @ ${rate}x = ${f}`);
|
|
fps.push({ throttle: rate, fps: f });
|
|
}
|
|
await setThrottle(cdp, 1);
|
|
|
|
recordPerf('pcbnew', { loadMs, openMs, fps });
|
|
|
|
expect(loadMs).toBeGreaterThan(0);
|
|
expect(openMs).toBeGreaterThan(0);
|
|
});
|
|
});
|