4c3a4cacd4
Make the Playwright e2e + kicad suites deterministic so screenshot flake stops tracing to timing races. - Blind page.waitForTimeout -> condition waits (expect.poll, web-first assertions, waitUntil) + readiness helpers (waitForWxApp, waitForCanvasApp). Remaining sleeps are documented interaction dwells (annotated). - Defensive "if element exists" branches -> loud asserts; label-fallback chains -> normalized clickMenuItemByText. First-run wizard for/if loops removed by seeding calculator/gerbview/pcbnew HTMLs. - Screenshots: new stableShot(page, name) settles the render in-page (canvas hash over rAF) then writes a raw PNG to test-results/ for the existing offline gate (tools/screenshots vs baseline-screenshots). Replaces toHaveScreenshot, which did inline compare + its own baselines and had decoupled the specs from the real gate. scale:'css' pinned. - retries: 0 in both configs. - Guard: tests/tools/lint-determinism.ts (npm run lint:determinism) bans blind sleeps / toHaveScreenshot / inline retries / swallowed catches in specs; documented exceptions carry a marker. Rules in tests/TESTING.md. Assertions, coverage, and renders unchanged (semantic-equivalence reviewed; captures pixel-identical modulo inherent timer/timestamp/3d-raytrace variance). Both suites green at retries:0 (e2e 340, kicad 92); ~35-61% faster. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BVX1pHMvRPYHdp6ZfEawrk
65 lines
2.7 KiB
TypeScript
65 lines
2.7 KiB
TypeScript
// wxGrid Cell Editing Tests - Property editing simulation
|
|
import { test, expect, waitForWxApp } from './utils/fixtures';
|
|
import { clickByLabel, clickGridCell, findGridCell, stableShot } from './utils/element-tracker';
|
|
|
|
test.describe('wxGrid Cell Editing Tests', () => {
|
|
|
|
test('GridEdit test app loads successfully', async ({ page, testLogger }) => {
|
|
await page.goto('/standalone/gridedit/gridedit_test.html');
|
|
await waitForWxApp(page);
|
|
|
|
await stableShot(page, 'gridedit-01-loaded.png', { fullPage: true });
|
|
|
|
expect(testLogger.errors.filter(e => !e.includes('favicon'))).toHaveLength(0);
|
|
});
|
|
|
|
test('Grid cells can be selected', async ({ page, testLogger }) => {
|
|
await page.goto('/standalone/gridedit/gridedit_test.html');
|
|
await waitForWxApp(page);
|
|
|
|
// Click on a cell using element registry
|
|
const clicked = await clickGridCell(page, 1, 1);
|
|
expect(clicked, 'Grid cell should be found and clicked').toBe(true);
|
|
|
|
await stableShot(page, 'gridedit-02-select-cell.png', { fullPage: true });
|
|
});
|
|
|
|
test('Grid cells can be edited', async ({ page, testLogger }) => {
|
|
await page.goto('/standalone/gridedit/gridedit_test.html');
|
|
await waitForWxApp(page);
|
|
|
|
// Double-click to enter edit mode using element registry
|
|
const cell = await findGridCell(page, 1, 1);
|
|
expect(cell, 'Grid cell should be found').not.toBeNull();
|
|
await page.mouse.dblclick(cell!.centerX, cell!.centerY);
|
|
|
|
await stableShot(page, 'gridedit-03-edit-cell.png', { fullPage: true });
|
|
});
|
|
|
|
test('Grid rows can be added', async ({ page, testLogger }) => {
|
|
await page.goto('/standalone/gridedit/gridedit_test.html');
|
|
await waitForWxApp(page);
|
|
|
|
// Click Add Row button using element registry
|
|
const clicked = await clickByLabel(page, 'Add Row');
|
|
expect(clicked, 'Add Row button should be found and clicked').toBe(true);
|
|
|
|
await stableShot(page, 'gridedit-04-add-row.png', { fullPage: true });
|
|
});
|
|
|
|
test('Grid rows can be deleted', async ({ page, testLogger }) => {
|
|
await page.goto('/standalone/gridedit/gridedit_test.html');
|
|
await waitForWxApp(page);
|
|
|
|
// Select a row first using element registry
|
|
const cellClicked = await clickGridCell(page, 1, 1);
|
|
expect(cellClicked, 'Grid cell should be found and clicked').toBe(true);
|
|
await page.waitForTimeout(100); // eslint-disable-line -- documented interaction dwell: let the cell-selection commit before the Delete Row click; no observable event is emitted
|
|
|
|
// Click Delete Row button using element registry
|
|
const deleteClicked = await clickByLabel(page, 'Delete Row');
|
|
expect(deleteClicked, 'Delete Row button should be found and clicked').toBe(true);
|
|
|
|
await stableShot(page, 'gridedit-05-delete-row.png', { fullPage: true });
|
|
});
|
|
});
|