4c3a4cacd4
Make the Playwright e2e + kicad suites deterministic so screenshot flake stops tracing to timing races. - Blind page.waitForTimeout -> condition waits (expect.poll, web-first assertions, waitUntil) + readiness helpers (waitForWxApp, waitForCanvasApp). Remaining sleeps are documented interaction dwells (annotated). - Defensive "if element exists" branches -> loud asserts; label-fallback chains -> normalized clickMenuItemByText. First-run wizard for/if loops removed by seeding calculator/gerbview/pcbnew HTMLs. - Screenshots: new stableShot(page, name) settles the render in-page (canvas hash over rAF) then writes a raw PNG to test-results/ for the existing offline gate (tools/screenshots vs baseline-screenshots). Replaces toHaveScreenshot, which did inline compare + its own baselines and had decoupled the specs from the real gate. scale:'css' pinned. - retries: 0 in both configs. - Guard: tests/tools/lint-determinism.ts (npm run lint:determinism) bans blind sleeps / toHaveScreenshot / inline retries / swallowed catches in specs; documented exceptions carry a marker. Rules in tests/TESTING.md. Assertions, coverage, and renders unchanged (semantic-equivalence reviewed; captures pixel-identical modulo inherent timer/timestamp/3d-raytrace variance). Both suites green at retries:0 (e2e 340, kicad 92); ~35-61% faster. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BVX1pHMvRPYHdp6ZfEawrk
70 lines
2.6 KiB
TypeScript
70 lines
2.6 KiB
TypeScript
// wxFileDialog Tests - File dialogs for KiCad open/save operations
|
|
// Uses element registry for semantic element identification
|
|
import { test, expect, waitForWxApp, clickByLabel } from './utils/fixtures';
|
|
import { stableShot } from './utils/element-tracker';
|
|
|
|
test.describe('wxFileDialog Tests', () => {
|
|
|
|
test('FileDialog test app loads successfully', async ({ page, testLogger }) => {
|
|
await page.goto('/standalone/filedialog/filedialog_test.html');
|
|
await waitForWxApp(page);
|
|
|
|
await stableShot(page, 'filedialog-01-loaded.png', { fullPage: true });
|
|
|
|
const hasStartup = testLogger.consoleLogs.some(l => l.includes('FileDialog test app started'));
|
|
|
|
expect(testLogger.errors.filter(e => !e.includes('favicon'))).toHaveLength(0);
|
|
});
|
|
|
|
test('Open file button can be clicked', async ({ page, testLogger }) => {
|
|
await page.goto('/standalone/filedialog/filedialog_test.html');
|
|
await waitForWxApp(page);
|
|
|
|
// Click "Open File..." button
|
|
await clickByLabel(page, 'Open File...');
|
|
|
|
await stableShot(page, 'filedialog-02-open-clicked.png', { fullPage: true });
|
|
|
|
expect(true).toBe(true); // Smoke test
|
|
});
|
|
|
|
test('Save file button can be clicked', async ({ page, testLogger }) => {
|
|
await page.goto('/standalone/filedialog/filedialog_test.html');
|
|
await waitForWxApp(page);
|
|
|
|
// Click "Save File..." button
|
|
await clickByLabel(page, 'Save File...');
|
|
|
|
await stableShot(page, 'filedialog-03-save-clicked.png', { fullPage: true });
|
|
|
|
expect(true).toBe(true);
|
|
});
|
|
|
|
test('Open multiple button can be clicked', async ({ page, testLogger }) => {
|
|
await page.goto('/standalone/filedialog/filedialog_test.html');
|
|
await waitForWxApp(page);
|
|
|
|
// Click "Open Multiple..." button
|
|
await clickByLabel(page, 'Open Multiple...');
|
|
|
|
await stableShot(page, 'filedialog-04-multiple-clicked.png', { fullPage: true });
|
|
|
|
expect(true).toBe(true);
|
|
});
|
|
|
|
test('All file dialog buttons accessible', async ({ page, testLogger }) => {
|
|
await page.goto('/standalone/filedialog/filedialog_test.html');
|
|
await waitForWxApp(page);
|
|
|
|
// Try all three buttons
|
|
await clickByLabel(page, 'Open File...');
|
|
await page.waitForTimeout(300); // eslint-disable-line -- documented interaction dwell
|
|
await clickByLabel(page, 'Save File...');
|
|
await page.waitForTimeout(300); // eslint-disable-line -- documented interaction dwell
|
|
await clickByLabel(page, 'Open Multiple...');
|
|
|
|
await stableShot(page, 'filedialog-05-all-buttons.png', { fullPage: true });
|
|
|
|
expect(testLogger.errors.filter(e => !e.includes('favicon'))).toHaveLength(0);
|
|
});
|
|
});
|