Squash of experiment/ff-big-modules vs main.
Big-module routing removed: native-EH shrank kicad_editor below
SpiderMonkey's x86-64 code budget (runs 29355049705/29356152413 green on
stock Firefox), so BIG_MODULE_SPECS routing and the baseline-only-JIT
crutch are gone — kicad-firefox and kicad-chromium both run the full
suite, with the module compiled the way real users' browsers compile it.
Per-engine screenshots end to end: stableShot/shotPath write
test-results/<engine>/<name>.png; baselines move to
baseline-screenshots/{chromium,firefox}/ and the whole tools/screenshots
pipeline (compare/promote/manifest/spec-map/changelog/Discord) keys on
<engine>/<name>. Previously Firefox and Chromium renders of one spec
overwrote each other and Firefox renders were never actually gated.
Seeded from CI run 29421380806 (92 new firefox baselines, +24 chromium
web-suite shots); manifest generated from the baseline tree.
One merged playwright.config.ts (kicad/asyncify/coroutine/perf as
projects); ~25 dead npm scripts dropped. The web suite is gated in CI for
the first time ever (4 rotted specs fixed, 5 broken lib-bridge specs
triaged as fixme in docs/features/web-e2e-rot/); cheap lint step after
npm ci; last 26 blind-sleep violations fixed.
SwiftShader retired: CI Chromium renders WebGL on ANGLE → Mesa llvmpipe
(--use-gl=angle --use-angle=gl --ignore-gpu-blocklist; the blocklist flag
is mandatory — llvmpipe is blocklisted and WebGL is silently unavailable
without it) in BOTH configs. Under WORKERS=4 congestion SwiftShader
transiently failed the first post-board-load draw and the recovery
cascade ended in a silent permanent Cairo fallback — that engine flip was
the "~1.2% changedRatio both directions" occ-export baseline flake.
Validated 160/160 across two 80-repeat rigs; full analysis in
docs/features/wx-parity-bugs/occ-export-context-eviction.md. Chromium
baselines shift slightly on llvmpipe — promote once from the first green
run. Deflakes the new coverage exposed: presence baselines settle before
capture; presence fixtures declare current file formats; perf gets its
own outputDir so CI evidence survives; occ-export settles the board paint
before the export dialog; menu-item waits (waitForRenderedByLabel before
clickMenuItem) in 4 specs + the TESTING.md rule.
Web suite runs the PROD build, in parallel: webServer becomes backend
`start` + the standalone's e2e:preview (build-preview.mjs: link-wasm →
stash the public/wasm symlink aside during vite build, build-demo.mjs's
move — then vite preview as the persistent server). The wasm middleware
serves /wasm/* in preview and emits COOP/COEP/CORP itself (a pthread
worker script's own response must carry COEP or Chrome kills it with
ERR_BLOCKED_BY_RESPONSE). VITE_* flags bake at build time;
VITE_ALLOW_USER_OVERRIDE joins turbo globalEnv. fullyParallel + default
workers: 5.2m → 1.4m. Determinism fixes the parallel run exposed:
shared-page specs become serial groups; locks.spec grabs alice's exact
item via the new kicadCollabTestSelectByUuid hook (cross-tab "first
footprint" order is not a ysync invariant); quit specs poll page.url()
(quit supersedes its own navigation — NS_BINDING_ABORTED on Firefox).
Suite: 51 passed / 12 skipped / 0 failed in 1.6m.
CI-coverage gate (lint:ci-coverage): every tests/**/*.spec.ts must be
reachable from the npm scripts the workflows invoke — scraped from
.github/workflows/, resolved through package.json, coverage asked from
playwright --list itself. Rules: uncovered-spec + orphan-project (with a
documented LOCAL_ONLY_PROJECTS allowlist). Gating next to
lint:determinism; 138 spec files / 13 projects accounted for.
Product fixes kept from the investigations (reachable on real GPUs too):
wx 7799fd1be5 — paint flags clear before dispatch + Invalidate always
propagates; kicad 3dcfea5e45 — SwiftShader pass-boundary flush +
per-instance font texture + first-frame GL-error drain (GAL recovery
recovers instead of falling back to Cairo) + the user-facing eeschema
switch navigates again under __EMSCRIPTEN__ (project-sync's
FaceRegistered gate had rerouted it into the hidden sync player; caught
by the newly-gated web suite).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018eUxiPApHgGiu9NFyQfhAq
117 lines
4.4 KiB
TypeScript
117 lines
4.4 KiB
TypeScript
import { test, expect, type Page } from '@playwright/test';
|
|
|
|
/**
|
|
* Selection soft-locks e2e (collab-presence 0007): two tabs of the real app
|
|
* on the SAME board share the per-file room — one tab's live selection must
|
|
* soft-lock those items for the other, and an overlapping hold (both grab the
|
|
* same item inside the propagation window — simulated with the programmatic
|
|
* select, which bypasses the acquisition veto exactly like a real race)
|
|
* resolves by the deterministic (user.id, clientID) tiebreak: alice keeps,
|
|
* bob's client releases.
|
|
*/
|
|
|
|
const SCOPE = 'default';
|
|
|
|
type Mod = {
|
|
kicadCollabGetSelection(): string;
|
|
kicadCollabTestGetLocked(): string;
|
|
kicadCollabTestSelectComponent(): string;
|
|
kicadCollabTestSelectByUuid(uuid: string): boolean;
|
|
kicadCollabTestClearSelection(): boolean;
|
|
};
|
|
type W = { Module: Mod };
|
|
|
|
async function bootBoard(page: Page, user: string): Promise<void> {
|
|
await page.goto(`/${SCOPE}/projects/demo/demo.kicad_pcb?user=${user}`);
|
|
await expect(page.locator('#canvas')).toBeVisible({ timeout: 120000 });
|
|
await expect
|
|
.poll(() => page.title(), {
|
|
message: `${user}: board editor never reached the expected title`,
|
|
timeout: 120000,
|
|
intervals: [1000],
|
|
})
|
|
.toMatch(/demo — PCB Editor/i);
|
|
await page.waitForFunction(
|
|
() =>
|
|
typeof (window as unknown as Partial<W>).Module?.kicadCollabTestGetLocked ===
|
|
'function',
|
|
null,
|
|
{ timeout: 60000 },
|
|
);
|
|
}
|
|
|
|
const selection = (page: Page) =>
|
|
page.evaluate(() =>
|
|
JSON.parse((window as unknown as W).Module.kicadCollabGetSelection()),
|
|
);
|
|
const locked = (page: Page) =>
|
|
page.evaluate(() =>
|
|
JSON.parse((window as unknown as W).Module.kicadCollabTestGetLocked()),
|
|
);
|
|
|
|
test('a peer selection locks the item; overlapping holds tiebreak deterministically', async ({
|
|
page,
|
|
context,
|
|
}) => {
|
|
test.setTimeout(480000); // two full board boots
|
|
|
|
const alice = page;
|
|
await bootBoard(alice, 'alice');
|
|
const bob = await context.newPage();
|
|
await bootBoard(bob, 'bob');
|
|
|
|
// ── lock propagation ───────────────────────────────────────────────────────
|
|
const fpId = await alice.evaluate(() =>
|
|
(window as unknown as W).Module.kicadCollabTestSelectComponent(),
|
|
);
|
|
expect(fpId, 'demo board should contain a footprint').toBeTruthy();
|
|
|
|
await expect
|
|
.poll(() => locked(bob), {
|
|
timeout: 20000,
|
|
message: "bob never saw alice's selection as a lock",
|
|
})
|
|
.toEqual([{ uuid: fpId, name: 'alice' }]);
|
|
// The holder's own tab is NOT locked against itself.
|
|
await expect.poll(() => locked(alice), { timeout: 20000 }).toEqual([]);
|
|
|
|
// ── overlapping hold → tiebreak ────────────────────────────────────────────
|
|
// bob grabs the SAME footprint programmatically (the race-window simulation:
|
|
// AddItemToSel bypasses the acquisition veto, like two grabs inside the
|
|
// awareness propagation window). By uuid — bob's ysync-materialized board
|
|
// need not iterate footprints in alice's parse order, so "the first
|
|
// footprint" is not a cross-tab invariant.
|
|
const bobPick = await bob.evaluate(
|
|
(uuid) => (window as unknown as W).Module.kicadCollabTestSelectByUuid(uuid),
|
|
fpId,
|
|
);
|
|
expect(bobPick, "bob must resolve alice's footprint by uuid").toBe(true);
|
|
|
|
// alice ("alice" < "bob") keeps it; bob's client releases it.
|
|
await expect
|
|
.poll(() => selection(bob), {
|
|
timeout: 20000,
|
|
message: "bob's losing hold was never released",
|
|
})
|
|
.toEqual([]);
|
|
expect(await selection(alice)).toContain(fpId);
|
|
|
|
// ── unlock on clear ────────────────────────────────────────────────────────
|
|
await alice.evaluate(() =>
|
|
(window as unknown as W).Module.kicadCollabTestClearSelection(),
|
|
);
|
|
await expect.poll(() => locked(bob), { timeout: 20000 }).toEqual([]);
|
|
|
|
// Now bob's grab sticks, and it locks the item for alice (same uuid — the
|
|
// assertions below compare against fpId).
|
|
await bob.evaluate(
|
|
(uuid) => (window as unknown as W).Module.kicadCollabTestSelectByUuid(uuid),
|
|
fpId,
|
|
);
|
|
await expect
|
|
.poll(() => selection(bob), { timeout: 20000 })
|
|
.toContain(fpId);
|
|
await expect
|
|
.poll(() => locked(alice), { timeout: 20000 })
|
|
.toEqual([{ uuid: fpId, name: 'bob' }]);
|
|
});
|