9a04217788
Main-repo side of a multi-part WIP covering the KiCad WASM tool-selection and nested-Asyncify work. Submodule commits are in kicad@f6e9239aaa (libcontext hygiene) and wxwidgets@bb80f91e8b (auibar registration + dialog diagnostics). ## scripts/common/inject-dyncall-shims.sh Wrap Asyncify.handleSleep / allocateData to save-and-restore Asyncify.currData around each EM_ASYNC_JS sleep. This fixes the nested Asyncify collision where a fiber swap that fired during a modal's event loop clobbered currData, and the modal's later doRewind used the fiber's buffer and hit "RuntimeError: index out of bounds". Root cause documented as Emscripten Issue #9153 (wontfix upstream). Diagnostic-rewind logging (forcedBottomOfCallStack, callStack traces) is retained to help future debugging of Asyncify state corruption. ## tests/ - tests/playwright-kicad.config.ts: add `channel: 'chrome'` for the chromium project so --project=chromium --headed uses system Chrome (real GPU) instead of SwiftShader on ARM Mac. Also switch trace to retain-on-failure + screenshot on-failure for easier E2E debugging. - tests/kicad/pcbnew.spec.ts: replace `tool.checked` assertions with a label-suffix check (`[checked]`) since our auibar registration encodes checked state in the label (no schema change to the registry). - tests/apps/Makefile.wasm: add `coroutine-nested` build target + include it in the all: list. - tests/apps/standalone/coroutine/: kicad_coroutine_harness.h + test app reproducing KiCad COROUTINE semantics against real libcontext. - tests/apps/standalone/coroutine-nested/: nested_test.cpp reproduces the EM_ASYNC_JS-modal + fiber-swap nesting bug in isolation. 8 scenarios from baseline_modal_alone through nested_fibers_inside_modal. - tests/e2e/coroutine.spec.ts + coroutine-nested.spec.ts: Playwright specs that load the standalone apps and assert all case cases pass via [COROUTINE_TEST] SUMMARY log parsing. ## research/ and features/browser-tools/ Three background docs capturing the investigation trajectory: - features/browser-tools/0001-kicad-wasm-tool-activation-investigation.md Early investigation: why tools don't activate; initial dynCall-empty- callback hypothesis. - features/browser-tools/0002-wasm-coroutine-deep-dive.md Deep dive on Asyncify internals, fiber API, QEMU's coroutine-wasm reference implementation. - features/browser-tools/0003-wxauitoolbar-registration-fix.md The narrow fix: why wxAuiToolBar needs a registration block, where to add it, what the fallback plan is. - research/threading_1.md: corrected root-cause analysis after reading runtime logs — nested-Asyncify currData collision, Emscripten #9153. - research/threading_2.md: extended research on alternative approaches (JSPI/WasmFX/state-machines) and why they don't help here. ## Submodule pointer updates kicad: f6e9239aaa (wip: libcontext WASM hygiene cleanup) wxwidgets: bb80f91e8b (wip: wxAuiToolBar element-registry registration + dialog diagnostics) ## Open threads not yet in scope - Firefox/Chrome divergent behavior: "indirect call signature mismatch" traps in Firefox vs renderer crash in system Chrome (tracked in plans/peaceful-hugging-pnueli.md and the research docs). - E2E pixel-diff for Draw Lines fails because the test's diff region does not cover where the line is actually drawn; tool activation works, the line is visible in test-results/pcbnew-draw-lines-02-after-drawing.png. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
65 lines
2.4 KiB
Shell
Executable file
65 lines
2.4 KiB
Shell
Executable file
#!/bin/bash
|
|
# Apply asyncify transformation to KiCad WASM
|
|
#
|
|
# Usage: ./scripts/common/apply-asyncify.sh <input.wasm> <output.wasm>
|
|
#
|
|
# This script is called by docker/build.sh but can also be run standalone
|
|
# for debugging asyncify issues.
|
|
|
|
set -e
|
|
|
|
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
|
|
PROJECT_ROOT="$(cd "${SCRIPT_DIR}/../.." && pwd)"
|
|
|
|
# Get wasm-opt path
|
|
WASM_OPT=$("${SCRIPT_DIR}/get-wasm-opt.sh")
|
|
|
|
INPUT_WASM="${1:-output/pcbnew.wasm}"
|
|
OUTPUT_WASM="${2:-${INPUT_WASM}}"
|
|
|
|
if [ ! -f "${INPUT_WASM}" ]; then
|
|
echo "ERROR: Input file not found: ${INPUT_WASM}"
|
|
exit 1
|
|
fi
|
|
|
|
echo "Applying asyncify transformation..."
|
|
echo " Input: ${INPUT_WASM}"
|
|
echo " Output: ${OUTPUT_WASM}"
|
|
echo " Tool: ${WASM_OPT}"
|
|
|
|
# Asyncify import patterns (functions that trigger async suspension)
|
|
# - env.invoke_* : Exception handling trampolines
|
|
# - env.__asyncjs__* : EM_ASYNC_JS functions (like startModal())
|
|
ASYNCIFY_IMPORTS="env.invoke_*,env.__asyncjs__*,env.emscripten_fiber_swap"
|
|
|
|
# Functions to exclude from asyncify instrumentation
|
|
# These are large functions that inflate beyond V8's local-count limits.
|
|
ASYNCIFY_REMOVE=$(cat << 'REMOVELIST'
|
|
COLOR_SETTINGS::COLOR_SETTINGS(wxString const&, bool)
|
|
BuildBitmapInfo(std::__2::unordered_map<BITMAPS, std::__2::vector<BITMAP_INFO, std::__2::allocator<BITMAP_INFO>>, std::__2::hash<BITMAPS>, std::__2::equal_to<BITMAPS>, std::__2::allocator<std::__2::pair<BITMAPS const, std::__2::vector<BITMAP_INFO, std::__2::allocator<BITMAP_INFO>>>>>&)
|
|
match
|
|
DIALOG_PAD_PROPERTIES_BASE::DIALOG_PAD_PROPERTIES_BASE(wxWindow*, int, wxString const&, wxPoint const&, wxSize const&, long)
|
|
buildKicadAboutBanner(EDA_BASE_FRAME*, ABOUT_APP_INFO&)
|
|
IGESToBRep_CurveAndSurface::TransferGeometry(opencascade::handle<IGESData_IGESEntity> const&, Message_ProgressRange const&)
|
|
StepAP214_Protocol::StepAP214_Protocol()
|
|
BRepCheck_ParallelAnalyzer::operator()(int) const
|
|
ShapeFix_Wire::FixGap3d(int, bool)
|
|
ShapeFix_Wire::FixGap2d(int, bool)
|
|
REMOVELIST
|
|
)
|
|
|
|
ASYNCIFY_REMOVE_ARG=$(echo "${ASYNCIFY_REMOVE}" | tr '\n' ',' | sed 's/,$//')
|
|
|
|
echo ""
|
|
echo "Running wasm-opt --asyncify..."
|
|
echo "This may take several minutes and use significant RAM..."
|
|
|
|
"${WASM_OPT}" --asyncify \
|
|
"--pass-arg=asyncify-imports@${ASYNCIFY_IMPORTS}" \
|
|
"--pass-arg=asyncify-removelist@${ASYNCIFY_REMOVE_ARG}" \
|
|
--pass-arg=asyncify-propagate-addlist \
|
|
"${INPUT_WASM}" -o "${OUTPUT_WASM}"
|
|
|
|
echo ""
|
|
echo "Asyncify complete: ${OUTPUT_WASM}"
|
|
ls -lh "${OUTPUT_WASM}"
|