pcbjam/wasm/shims/nanosleep_yield.c
Viktor Vaczi 9c475a804e jspi cleanup: remove the asyncify-era residue — dead code, conditionals, pipeline scaffolding, stale prose
The runtime is JSPI-only; this removes everything that still pretended
otherwise. Three exhaustive sweeps (C++/JS+build+CI/tests+docs) drove
the inventory; every deletion verified by grep closure + full gates.

Broken-right-now fixes:
- deploy-staging.yml passed the retired opt_level input — the workflow
  could not even start. Removed.
- env.sh carried dead exports with a live -sASYNCIFY=1 inside
  (WASM_LDFLAGS/PTHREAD_LDFLAGS, zero consumers). Removed; the
  WASM_LEGACY_EXCEPTIONS rationale rewritten to the real reason.
- docker/build.sh exported PCBJAM_ASYNC_BACKEND (read nowhere). Gone.

Dead weight removed:
- binaryen submodule (nothing builds or invokes it), wasm-opt-bench
  workflow + scripts/bench/, get-wasm-opt.sh, diagnostics.js (242 lines
  of Asyncify-API-only code), the KICAD_PIPELINE background-postprocess
  scaffolding (existed to parallelize the deleted wasm-opt phase; the
  postprocess is a seconds-long node script and now runs inline),
  build-monitor's dead asyncify rows, sched-context orphan build
  output, dead .gitignore entries, the .jspi-assets spike dir (the two
  wf-result research JSONs moved to docs/features/async/migration-evidence/).
- bindings: fiber_park.h + its 12 embind registrations (broken-if-
  called under JSPI), the kicadOpenFileStart/OPEN_JOB starter route,
  main_stack_runner.h + 5 includes, the always-null context-sleep weak
  hook in nanosleep_yield.c.
- shim: the backend field (installed-flag idempotency instead),
  noteContextWait (dead both sides), the __wxAsyncifyDump alias (+ the
  WasmTool fallback and string-dump normalize branch).
- web: the emscripten-6-ignored mainScriptUrlOrBlob option in boot.ts
  (gerber-demo keeps it: it loads the deployed CDN release, which
  predates emscripten 6 — noted inline).

Conditionals: all 'backend === jspi' checks reduced to scheduler-
presence checks; races_quiescent re-keyed from Asyncify.state (vacuous)
to real backlog quiescence (resumeReady/mutatorQueue — NOT _windowLive,
which is the probing activation's own window by definition).

Renames (identifiers only, no file renames): ASYNC_LINK_FLAGS→
JSPI_LINK_FLAGS and Makefile ASYNC_LDFLAGS→JSPI_LDFLAGS,
kicadCollabFiberBusy→kicadCollabBusy (embind + web + tests),
collab_common.h fiber*→apply*/coroutine naming, asyncifySignatures→
wasmTrapSignatures (lists byte-identical).

Tests: the two remaining vacuous [wx-asyncify]/fiber-resume-refused
asserts re-keyed to live JSPI beacons; eeschema-load's failure message
no longer sends the developer to a deleted script; wait-beacons' dead
families/parser deleted; lane-0 legacy-glue guards removed (lane 0 is
unconstructible); the embind test.fail re-gated with the JSPI reason
(plain embind invokers cannot suspend — verified still failing);
lint-determinism now scans tests/jspi (166 files clean);
eeschema-collab local-move gated to chromium (~50% flaky on FF even
solo; pcbnew twin covers both engines).

Docs: DEBUG.md rewritten as the JSPI debugging guide; build.md
describes the single-phase build; docs/features/async/README.md
banner-marked historical and repointed at the NEW
23-jspi-runtime.md (current architecture: export census, turnstile,
libcontext ownership + refusal contract, embind call shapes, the
em-pthread service-wrapper trick, exception policy, known gaps).

Gates on the cleaned tree: test:e2e 725 passed / 0 failed (after the
quiescence-probe fix; the 3 other reds were verified contention flakes
solo-green or the documented FF gate), web 76/0, jspi 18/18 both
engines, vitest 295/295 + 17/17, all lints green, live-app census
clean.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016X9eh1s5sTx1o9Em9KBuwR
2026-08-14 09:25:32 +02:00

74 lines
3.5 KiB
C

/*
* nanosleep_yield.c — make a MAIN-THREAD nanosleep() YIELD to the JS event loop
* (a JSPI suspension) instead of busy-spinning, so on-demand pthread-Worker
* creation can complete WITHOUT editing KiCad.
*
* THE PROBLEM (the "non-warm thread" deadlock): once KiCad's thread pool has consumed all
* the pre-warmed Workers (-sPTHREAD_POOL_SIZE), a later raw std::thread (the raytracer)
* must spawn a NEW Worker on demand. Finalizing it needs the main thread's event loop to
* run the new-Worker 'loaded' -> 'run' handshake. KiCad's join is a sleep_for() busy-wait
* -> nanosleep -> emscripten_thread_sleep, which busy-spins and NEVER returns to the JS
* event loop, so the new Worker never starts -> deadlock.
*
* THE FIX: the only main-thread primitive that returns to the event loop is a suspension.
* This provides a nanosleep that, ON THE MAIN THREAD, yields via an EM_ASYNC_JS await
* (= emscripten_sleep semantics under JSPI). The unmodified sleep_for busy-wait then pumps
* the loop, the Worker handshake completes, and on-demand creation works with no KiCad
* edit.
*
* MECHANISM: a STRONG definition of nanosleep here SHADOWS musl's archive member — the
* linker only pulls musl's nanosleep.o if the symbol is left undefined, and ours defines it.
* (-Wl,--wrap=nanosleep is not an option here — it crashes wasm-ld with a SIGSEGV in
* lld::wasm::ImportSection::addImport.) On a pthread worker we fall back to
* emscripten_thread_sleep (the real underlying blocking sleep — workers may block).
*
* SCOPE: only the main browser thread yields; only it must never block the event loop.
*
* ZERO-DURATION GUARD (ported from staging 29c61b8): a nanosleep of 0 ms
* returns immediately WITHOUT yielding. mimalloc's spin-wait hint
* mi_atomic_yield() is sleep(0) on wasm, reached from malloc's slow path
* under cross-thread delayed-free contention. Under JSPI a yield there
* SUSPENDS the activation inside the allocator — any other activation that
* then runs can re-enter mimalloc mid-operation. A zero-duration sleep never
* promised an event-loop turn — stock emscripten busy-waits and returns
* immediately. mimalloc is the module's only zero-duration sleeper; the
* worker-boot deadlock this shim fixes needs only the ms-scale yields.
*/
#include <emscripten/emscripten.h>
#include <emscripten/threading.h>
#include <time.h>
/* EM_ASYNC_JS is a suspending import: JSPI suspends every activation that awaits it. */
EM_ASYNC_JS( void, __wasm_main_thread_yield_ms, ( double ms ), {
/* Route through the scheduler's turnstile when it exists - a raw await's
engine-level resume bypasses the shim's SP discipline and leaves its
window marked live (the pump then refuses every later resume). The
scheduler-free harness builds keep the raw await. */
var S = globalThis.__wxScheduler;
if( S ) {
await S.sleepYield( ms );
return;
}
await new Promise( function( resolve ) { setTimeout( resolve, ms ); } );
} );
int nanosleep( const struct timespec* req, struct timespec* rem )
{
if( req )
{
double ms = (double) req->tv_sec * 1000.0 + (double) req->tv_nsec / 1.0e6;
if( ms > 0.0 )
{
if( emscripten_is_main_runtime_thread() )
__wasm_main_thread_yield_ms( ms ); /* yield -> event loop runs -> Worker boots */
else
emscripten_thread_sleep( ms ); /* worker: real blocking sleep */
}
}
if( rem )
{
rem->tv_sec = 0;
rem->tv_nsec = 0;
}
return 0;
}