Squash of experiment/ff-big-modules vs main.
Big-module routing removed: native-EH shrank kicad_editor below
SpiderMonkey's x86-64 code budget (runs 29355049705/29356152413 green on
stock Firefox), so BIG_MODULE_SPECS routing and the baseline-only-JIT
crutch are gone — kicad-firefox and kicad-chromium both run the full
suite, with the module compiled the way real users' browsers compile it.
Per-engine screenshots end to end: stableShot/shotPath write
test-results/<engine>/<name>.png; baselines move to
baseline-screenshots/{chromium,firefox}/ and the whole tools/screenshots
pipeline (compare/promote/manifest/spec-map/changelog/Discord) keys on
<engine>/<name>. Previously Firefox and Chromium renders of one spec
overwrote each other and Firefox renders were never actually gated.
Seeded from CI run 29421380806 (92 new firefox baselines, +24 chromium
web-suite shots); manifest generated from the baseline tree.
One merged playwright.config.ts (kicad/asyncify/coroutine/perf as
projects); ~25 dead npm scripts dropped. The web suite is gated in CI for
the first time ever (4 rotted specs fixed, 5 broken lib-bridge specs
triaged as fixme in docs/features/web-e2e-rot/); cheap lint step after
npm ci; last 26 blind-sleep violations fixed.
SwiftShader retired: CI Chromium renders WebGL on ANGLE → Mesa llvmpipe
(--use-gl=angle --use-angle=gl --ignore-gpu-blocklist; the blocklist flag
is mandatory — llvmpipe is blocklisted and WebGL is silently unavailable
without it) in BOTH configs. Under WORKERS=4 congestion SwiftShader
transiently failed the first post-board-load draw and the recovery
cascade ended in a silent permanent Cairo fallback — that engine flip was
the "~1.2% changedRatio both directions" occ-export baseline flake.
Validated 160/160 across two 80-repeat rigs; full analysis in
docs/features/wx-parity-bugs/occ-export-context-eviction.md. Chromium
baselines shift slightly on llvmpipe — promote once from the first green
run. Deflakes the new coverage exposed: presence baselines settle before
capture; presence fixtures declare current file formats; perf gets its
own outputDir so CI evidence survives; occ-export settles the board paint
before the export dialog; menu-item waits (waitForRenderedByLabel before
clickMenuItem) in 4 specs + the TESTING.md rule.
Web suite runs the PROD build, in parallel: webServer becomes backend
`start` + the standalone's e2e:preview (build-preview.mjs: link-wasm →
stash the public/wasm symlink aside during vite build, build-demo.mjs's
move — then vite preview as the persistent server). The wasm middleware
serves /wasm/* in preview and emits COOP/COEP/CORP itself (a pthread
worker script's own response must carry COEP or Chrome kills it with
ERR_BLOCKED_BY_RESPONSE). VITE_* flags bake at build time;
VITE_ALLOW_USER_OVERRIDE joins turbo globalEnv. fullyParallel + default
workers: 5.2m → 1.4m. Determinism fixes the parallel run exposed:
shared-page specs become serial groups; locks.spec grabs alice's exact
item via the new kicadCollabTestSelectByUuid hook (cross-tab "first
footprint" order is not a ysync invariant); quit specs poll page.url()
(quit supersedes its own navigation — NS_BINDING_ABORTED on Firefox).
Suite: 51 passed / 12 skipped / 0 failed in 1.6m.
CI-coverage gate (lint:ci-coverage): every tests/**/*.spec.ts must be
reachable from the npm scripts the workflows invoke — scraped from
.github/workflows/, resolved through package.json, coverage asked from
playwright --list itself. Rules: uncovered-spec + orphan-project (with a
documented LOCAL_ONLY_PROJECTS allowlist). Gating next to
lint:determinism; 138 spec files / 13 projects accounted for.
Product fixes kept from the investigations (reachable on real GPUs too):
wx 7799fd1be5 — paint flags clear before dispatch + Invalidate always
propagates; kicad 3dcfea5e45 — SwiftShader pass-boundary flush +
per-instance font texture + first-frame GL-error drain (GAL recovery
recovers instead of falling back to Cairo) + the user-facing eeschema
switch navigates again under __EMSCRIPTEN__ (project-sync's
FaceRegistered gate had rerouted it into the hidden sync player; caught
by the newly-gated web suite).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018eUxiPApHgGiu9NFyQfhAq
65 lines
2.9 KiB
TypeScript
65 lines
2.9 KiB
TypeScript
/**
|
|
* Resolve a screenshot name → the spec that writes it, by scanning the specs for
|
|
* screenshot-name literals. Used by compare/changelog for the caption strip only —
|
|
* the ENGINE of a screenshot is the directory it lives in (test-results/<engine>/,
|
|
* baseline-screenshots/<engine>/), never guessed from specs.
|
|
*
|
|
* Two literal shapes are scanned:
|
|
* - stableShot(page, 'name.png' …) / shotPath(page, 'name.png') — the standard writers
|
|
* - 'test-results/<prefix>' — legacy direct paths
|
|
*
|
|
* Attribution is longest-prefix (`pcbnew-loaded` → the spec that writes `pcbnew-…`).
|
|
* Names written only by a helper (e.g. `wizard-*` via completeWizard, which lives in
|
|
* a util not a *.spec.ts) don't match → specFor returns null (the caption then just
|
|
* shows the name).
|
|
*/
|
|
import * as fs from 'fs';
|
|
import * as path from 'path';
|
|
|
|
function listSpecs(dir: string): string[] {
|
|
const out: string[] = [];
|
|
if (!fs.existsSync(dir)) return out;
|
|
for (const e of fs.readdirSync(dir, { withFileTypes: true })) {
|
|
const p = path.join(dir, e.name);
|
|
if (e.isDirectory()) out.push(...listSpecs(p));
|
|
// Only *.spec.ts — a literal in a util would be mis-attributed to the util's dir.
|
|
else if (e.name.endsWith('.spec.ts')) out.push(p);
|
|
}
|
|
return out;
|
|
}
|
|
|
|
type PrefixEntry = { prefix: string; spec: string };
|
|
|
|
/** prefix → spec-rel-to-tests, longest-prefix first. */
|
|
function prefixMap(root: string): PrefixEntry[] {
|
|
const map = new Map<string, string>();
|
|
for (const dir of ['e2e', 'kicad', 'web']) {
|
|
for (const spec of listSpecs(path.join(root, dir))) {
|
|
const rel = path.relative(root, spec); // e.g. 'kicad/pcbnew.spec.ts'
|
|
const content = fs.readFileSync(spec, 'utf8');
|
|
const add = (prefix: string) => {
|
|
if (prefix && !map.has(prefix)) map.set(prefix, rel); // first writer wins
|
|
};
|
|
// stableShot(page, 'name.png') / shotPath(page, `name-${x}.png`)
|
|
for (const m of content.matchAll(/(?:stableShot|shotPath)\(\s*\w+,\s*[`']([A-Za-z0-9_-]+)/g)) add(m[1]);
|
|
// legacy direct 'test-results/<prefix>' literals
|
|
for (const m of content.matchAll(/test-results\/([A-Za-z0-9_-]+)/g)) add(m[1]);
|
|
}
|
|
}
|
|
return [...map.entries()]
|
|
.map(([prefix, spec]) => ({ prefix, spec }))
|
|
.sort((a, b) => b.prefix.length - a.prefix.length);
|
|
}
|
|
|
|
export type SpecResolver = { specFor(name: string): string | null };
|
|
|
|
/** Build a name→spec resolver by scanning the specs under `root` once. */
|
|
export function buildSpecResolver(root: string): SpecResolver {
|
|
const prefixes = prefixMap(root);
|
|
return {
|
|
specFor: (name) => {
|
|
const stem = name.replace(/\.png$/i, '');
|
|
return prefixes.find((p) => stem === p.prefix || stem.startsWith(p.prefix))?.spec ?? null;
|
|
},
|
|
};
|
|
}
|