c421d724b0
A review of the group-E fixes found 13 further defects; ten were introduced by
those fixes, two pre-existed and were merely relocated, one is deferred.
Services / transport
E-10 retireWorker synthesized no bg/exit frame, so sharedspice's s_bgRunning
mirror stayed latched true after a mid-run worker death: Run stayed
disabled and the promised fresh-worker restart was unreachable for the
whole session. Retirement now dispatches a synthetic controlled-exit
straight to the installed handler (never through dispatchEvt — a
fabricated frame must not touch the credit ledger). Driving the repro
exposed two further defects, both fixed here: a replacement worker
trapped on pre-init engine reads, and the rerun's cm_input_path/circ hit
that uninitialized engine before KiCad's validate() re-init (the native
flow assumes a crashed engine survives in-process — true for the dll,
false for a dead worker). Reads now answer their empty shapes pre-init,
writes lazy-init, and init is idempotent per worker engine.
E-19 dispatchEvt acked only AFTER handler(evt) returned, and the sharedspice
client deliberately rethrows non-trap errors — so each throw leaked one
unit of the 64-frame credit window until the stream died with a
misattributed "transport exceeded". The ack moves to a finally in both
service copies; the throw still propagates (the trap machinery needs it).
E-20 the oversize-line path promises to transfer the accepted prefix, but
with the window full that flush only DEFERS, and stopEventStream wiped
the deferred queue — losing the diagnostics that explain the failure.
The terminal notice now carries them as pendingEvents; both hosts
deliver them in order, unacked (the fatal frame is outside the credit
protocol).
E-21 the 30s prefetch deadline discarded every model already collected and
reported nothing. A caller-owned progress sink ships the partials and
the omission reaches the export report. (Awaiting the aborted collection
was rejected: an in-flight source fetch is not abortable — E-4's
original disease.) Plus a serving-candidate memo, so a .wrl ref served
by its .step fallback stops re-probing the miss on every export.
Scheduler
E-14 _terminalizeNativeTrap classified by message substring, so any plain JS
error QUOTING 'Aborted(' or 'out of bounds' permanently bricked a
healthy instance. Now structural only: instanceof RuntimeError plus a
duck-typed name check (verified in this build's glue that abort() throws
a genuine RuntimeError both pre- and post-runtime-init). Module.onAbort
now latches the gate — the authoritative notification, previously
ignored.
E-15 the shim half: _pumpResume gates on terminal (catching wakes already
queued at latch time) and resolveWait refuses on terminal WITHOUT
consuming the entry, so a frame stays visibly parked rather than
resuming inside a trapped module.
E-16 the E-5 handler read the realm-global scheduler at dispatch instead of
its installing module's; also frees the per-line buffer on the non-trap
rethrow path.
E-11 get_vec trusted the worker's res.length over the transferred arrays.
Observed death shape: a 4 GiB std::vector threw an unhandled
std::length_error that exited the editor's main loop. Now clamped, with
the buffers freed on every failure path.
Guardrails (replacing two deferred refactors: e2e→production-code injection and
collapsing the four copies of the worker-lifecycle machinery)
E-18 the source contract asserted comment-string counts — rewording failed
CI while moving a guard outside its #ifdef passed. It now parses the
#ifdef regions and asserts on code.
service-stub-parity.ts pins what the four lifecycle copies must share:
credit-window equality parsed from source, the finally-ack, boot
deadlines, terminal-notice consumption. The transport numbers are now
single-sourced from the worker.
CI actually runs the gates: the web/standalone vitest suites (which had
NEVER run in CI), the reducer, the source contract and the parity tool —
with a NON_PLAYWRIGHT_GATES check so deleting a step re-fails the lint.
E-22 the e2e occ stub's 60s boot watchdog, deleted in a66e109, is restored in
the ngspice-stub shape with a wedgeNextBoot() repro hook.
Every behavioral fix has red-then-green evidence (the reds were captured first).
E-17 (a stale RUNNING cross-stamping the next run's generation under E-6's
transport deferral) is DEFERRED with its analysis recorded — a real fix needs
run identity on the bg frames.
Test hygiene: the dwell lint now requires the mandated ": <why>" and all 47 bare
markers carry their reason; three export-report dwells became modal-lease polls;
exact-ledger assertions became relative deltas; the dead data-wx-dom-id branch,
an unused fault hook and unused receipt plumbing are gone; abort scans, wx
dialog drivers, the sim harness and the vitest FakeWorker are each one copy now.
Bumps kicad and wxwidgets to their findings-group-e tips.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
52 lines
3.4 KiB
JSON
52 lines
3.4 KiB
JSON
{
|
|
"name": "kicad-wasm-tests",
|
|
"version": "1.0.0",
|
|
"description": "Playwright tests for wxWidgets WASM and KiCad",
|
|
"scripts": {
|
|
"test": "npm run test:e2e",
|
|
"test:e2e": "npm run setup:kicad && playwright test --project=wx-chromium --project=kicad-firefox --project=kicad-chromium --project=jspi-firefox --project=coroutine-firefox",
|
|
"test:kicad": "npm run setup:kicad && playwright test --project=kicad-firefox",
|
|
"test:kicad:headed": "npm run setup:kicad && playwright test --project=kicad-chrome --headed",
|
|
"test:jspi:chrome": "playwright test --project=jspi-chrome",
|
|
"test:perf": "npm run setup:kicad && playwright test --project=perf --workers=1",
|
|
"test:web": "npm run setup:kicad && playwright test --config=playwright-web.config.ts --project=web-firefox",
|
|
"test:web:ci": "npm run setup:kicad && playwright test --config=playwright-web.config.ts --project=web-firefox --project=web-chromium --project=web-mobile",
|
|
"build:collab": "node collab/build.mjs",
|
|
"serve": "npx serve apps -p 8080 -c ../serve.json",
|
|
"setup:kicad": "./scripts/setup-kicad-wasm.sh",
|
|
"corpus:lint": "tsx tools/corpus-lint.ts",
|
|
"lint:determinism": "tsx tools/lint-determinism.ts",
|
|
"lint:ci-coverage": "tsx tools/lint-ci-coverage.ts",
|
|
"screenshots:check": "tsx tools/screenshots/compare.ts",
|
|
"screenshots:noise": "tsx tools/screenshots/noise.ts",
|
|
"screenshots:report": "tsx tools/screenshots/post-discord.ts",
|
|
"screenshots:fetch-manifest": "tsx tools/screenshots/r2-sync.ts --manifest",
|
|
"screenshots:fetch": "tsx tools/screenshots/r2-sync.ts --pull",
|
|
"screenshots:upload-run": "tsx tools/screenshots/upload-run.ts",
|
|
"3d:compare": "tsx tools/screenshots/compare-dirs.ts",
|
|
"3d:check": "tsx tools/screenshots/compare-dirs.ts --old 3d-regression/baseline --new 3d-regression/output/native --out 3d-regression/output/diff/native-self --floors 3d-regression/floors.json --level native-self --label 3d-native --fail-on-change",
|
|
"3d:check:webgl": "tsx tools/screenshots/compare-dirs.ts --old 3d-regression/baseline-webgl --new 3d-regression/output/webgl --out 3d-regression/output/diff/webgl-self --floors 3d-regression/floors.json --level webgl-self --label 3d-webgl --fail-on-change",
|
|
"3d:check:parity": "tsx tools/screenshots/compare-dirs.ts --old 3d-regression/baseline --new 3d-regression/output/webgl --out 3d-regression/output/diff/parity --floors 3d-regression/floors.json --level webgl-vs-native --label 3d-parity",
|
|
"3d:review": "tsx tools/screenshots/compare-dirs.ts --old 3d-regression/baseline --new 3d-regression/output/webgl --out 3d-regression/output/diff/parity-review --floors 3d-regression/floors.json --level webgl-vs-native --label 3d-parity --artifacts always",
|
|
"3d:test:webgl": "playwright test --project=wx-chromium e2e/3d-webgl.spec.ts",
|
|
"tools:contract": "tsx tools/cli-contract.ts",
|
|
"ngspice:worker-batch": "tsx tools/ngspice-worker-batch-unit.ts",
|
|
"findings-e:contract": "tsx tools/findings-e-source-contract.ts",
|
|
"findings-e:parity": "tsx tools/service-stub-parity.ts"
|
|
},
|
|
"devDependencies": {
|
|
"@playwright/test": "^1.62.1",
|
|
"@types/node": "^24.10.1",
|
|
"@types/pixelmatch": "^5.2.6",
|
|
"@types/pngjs": "^6.0.5",
|
|
"aws4fetch": "^1.0.20",
|
|
"esbuild": "^0.28.0",
|
|
"pixelmatch": "^5.3.0",
|
|
"playwright": "^1.62.1",
|
|
"pngjs": "^7.0.0",
|
|
"serve": "^14.2.0",
|
|
"tsx": "^4.22.4",
|
|
"typescript": "^5.9.3",
|
|
"yjs": "^13.6.31"
|
|
}
|
|
}
|