AI_Assistant/pcbjam
Watch
1
0
Fork
You've already forked pcbjam
 0
Code Issues Pull requests Projects Releases 7 Packages Wiki Activity Actions

tests: dark-mode spec diffs against a per-engine light-mode reference

Browse source 
CI firefox read 0.228 header diff against the Chromium reference while its own
dark and light renders were pixel-identical — pure Firefox-vs-Chromium AA, not
a theme leak. Add the firefox light render as wizard-04-finish-headless-firefox.png
and pick the reference by browserName.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LvvARNMxQrq17vogn3REMU
This commit is contained in:
Gergő Törcsvári 2026-08-28 23:24:20 +02:00
commit c666a37f51
No known key found for this signature in database
GPG key ID: 8E75F2CDE64E5322
3 changed files with 15 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

12
tests/kicad/utils/screenshot-compare.ts
View file

@ -38,6 +38,18 @@ export type ReferenceComparison = {
* spec with ENOENT once — see the baselines-to-R2 migration).
*/
export const PCBNEW_REFERENCE = path.resolve(__dirname, '../../wizard-04-finish-headless.png');
/**
* Firefox rasterizes the toolbar text/icon edges differently enough from
* Chromium that the Chromium reference reads ~0.23 header diff on the CI
* firefox leg (2026-08-28, pure AA — the firefox dark and light renders were
* pixel-identical), so each engine diffs against its own light-mode render.
* Both files are spec-owned and committed, like PCBNEW_REFERENCE.
*/
export const PCBNEW_REFERENCE_FIREFOX = path.resolve(__dirname, '../../wizard-04-finish-headless-firefox.png');
export function pcbnewReferenceFor(browserName: string): string {
return browserName === 'firefox' ? PCBNEW_REFERENCE_FIREFOX : PCBNEW_REFERENCE;
}
export const PCBNEW_HEADER_REGION: ReferenceRegion = {
// maxDiffRatio counts every pixel differing by >16 in any channel, so it is dominated
// by sub-pixel/anti-aliasing differences along text and icon edges. Those vary with the