findings(E-10..E-22): fix the defects a code review found in the E-1..E-9 work

A review of the group-E fixes found 13 further defects; ten were introduced by
those fixes, two pre-existed and were merely relocated, one is deferred.

Services / transport
  E-10  retireWorker synthesized no bg/exit frame, so sharedspice's s_bgRunning
        mirror stayed latched true after a mid-run worker death: Run stayed
        disabled and the promised fresh-worker restart was unreachable for the
        whole session. Retirement now dispatches a synthetic controlled-exit
        straight to the installed handler (never through dispatchEvt — a
        fabricated frame must not touch the credit ledger). Driving the repro
        exposed two further defects, both fixed here: a replacement worker
        trapped on pre-init engine reads, and the rerun's cm_input_path/circ hit
        that uninitialized engine before KiCad's validate() re-init (the native
        flow assumes a crashed engine survives in-process — true for the dll,
        false for a dead worker). Reads now answer their empty shapes pre-init,
        writes lazy-init, and init is idempotent per worker engine.
  E-19  dispatchEvt acked only AFTER handler(evt) returned, and the sharedspice
        client deliberately rethrows non-trap errors — so each throw leaked one
        unit of the 64-frame credit window until the stream died with a
        misattributed "transport exceeded". The ack moves to a finally in both
        service copies; the throw still propagates (the trap machinery needs it).
  E-20  the oversize-line path promises to transfer the accepted prefix, but
        with the window full that flush only DEFERS, and stopEventStream wiped
        the deferred queue — losing the diagnostics that explain the failure.
        The terminal notice now carries them as pendingEvents; both hosts
        deliver them in order, unacked (the fatal frame is outside the credit
        protocol).
  E-21  the 30s prefetch deadline discarded every model already collected and
        reported nothing. A caller-owned progress sink ships the partials and
        the omission reaches the export report. (Awaiting the aborted collection
        was rejected: an in-flight source fetch is not abortable — E-4's
        original disease.) Plus a serving-candidate memo, so a .wrl ref served
        by its .step fallback stops re-probing the miss on every export.

Scheduler
  E-14  _terminalizeNativeTrap classified by message substring, so any plain JS
        error QUOTING 'Aborted(' or 'out of bounds' permanently bricked a
        healthy instance. Now structural only: instanceof RuntimeError plus a
        duck-typed name check (verified in this build's glue that abort() throws
        a genuine RuntimeError both pre- and post-runtime-init). Module.onAbort
        now latches the gate — the authoritative notification, previously
        ignored.
  E-15  the shim half: _pumpResume gates on terminal (catching wakes already
        queued at latch time) and resolveWait refuses on terminal WITHOUT
        consuming the entry, so a frame stays visibly parked rather than
        resuming inside a trapped module.
  E-16  the E-5 handler read the realm-global scheduler at dispatch instead of
        its installing module's; also frees the per-line buffer on the non-trap
        rethrow path.
  E-11  get_vec trusted the worker's res.length over the transferred arrays.
        Observed death shape: a 4 GiB std::vector threw an unhandled
        std::length_error that exited the editor's main loop. Now clamped, with
        the buffers freed on every failure path.

Guardrails (replacing two deferred refactors: e2e→production-code injection and
collapsing the four copies of the worker-lifecycle machinery)
  E-18  the source contract asserted comment-string counts — rewording failed
        CI while moving a guard outside its #ifdef passed. It now parses the
        #ifdef regions and asserts on code.
        service-stub-parity.ts pins what the four lifecycle copies must share:
        credit-window equality parsed from source, the finally-ack, boot
        deadlines, terminal-notice consumption. The transport numbers are now
        single-sourced from the worker.
        CI actually runs the gates: the web/standalone vitest suites (which had
        NEVER run in CI), the reducer, the source contract and the parity tool —
        with a NON_PLAYWRIGHT_GATES check so deleting a step re-fails the lint.
  E-22  the e2e occ stub's 60s boot watchdog, deleted in a66e109, is restored in
        the ngspice-stub shape with a wedgeNextBoot() repro hook.

Every behavioral fix has red-then-green evidence (the reds were captured first).
E-17 (a stale RUNNING cross-stamping the next run's generation under E-6's
transport deferral) is DEFERRED with its analysis recorded — a real fix needs
run identity on the bg frames.

Test hygiene: the dwell lint now requires the mandated ": <why>" and all 47 bare
markers carry their reason; three export-report dwells became modal-lease polls;
exact-ledger assertions became relative deltas; the dead data-wx-dom-id branch,
an unused fault hook and unused receipt plumbing are gone; abort scans, wx
dialog drivers, the sim harness and the vitest FakeWorker are each one copy now.

Bumps kicad and wxwidgets to their findings-group-e tips.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

tests/kicad/occ-export-models.spec.ts

@@ -5,6 +5,7 @@ import { test, expect } from './fixtures';
 import { clickMenuBarItem, clickMenuItem, waitForEditorReady, waitForRenderedByLabel, waitUntil } from '../e2e/utils/element-tracker';
 import { injectFromSubmodule } from './utils/fs-inject';
 import { waitForBoardLoaded } from './utils/board-ready';
+import { clickWxButton, openStepExportDialog, waitForMenuItems, dismissReportDialog } from './utils/wx-dialogs';
 
 /**
  * STEP export × 3D model delivery (docs/features/3d-models, 0007): File →
@@ -52,19 +53,6 @@ interface ExportCapture {
     productCount: number;
 }
 
-/** Wait for a rendered popup menu to have its items (replaces a fixed post-menu-click sleep). */
-async function waitForMenuItems(page: Page): Promise<void> {
-    await waitUntil(
-        page,
-        () => {
-            const r = window.wxElementRegistry;
-            if (!r?.findAllRendered) return false;
-            return r.findAllRendered({ elementType: 'menuitem' }).length > 3;
-        },
-        'popup menu items rendered',
-    );
-}
-
 /**
  * Record every model3d bridge request and serve ALL of them from the fixture —
  * the delivery side is never the bottleneck in this spec (mirrors the serveAll
@@ -92,7 +80,6 @@ async function installModelProviderStub(page: Page): Promise<void> {
 
                 // Mirror models-bridge.ts ensureModelInMemfs: write under the
                 // JS-owned model root, answer with the ABSOLUTE path.
-                // @ts-expect-error — Emscripten FS lives on window
                 const FS = (window as any).FS;
                 const dest = `${stockDir}/${arg}`;
                 FS.mkdirTree(dest.slice(0, dest.lastIndexOf('/')));
@@ -149,48 +136,18 @@ async function loadBoard(page: Page, testLogger: { consoleLogs: string[]; errors
 
     await page.mouse.click(filenameInput.x, filenameInput.y);
     // Documented interaction dwells: focus + typed-text registration have no observable signal.
-    await page.waitForTimeout(200); // eslint-disable-line -- documented interaction dwell
+    await page.waitForTimeout(200); // eslint-disable-line -- documented interaction dwell: focus registration has no observable signal
     await page.keyboard.type(pcbFilename);
-    await page.waitForTimeout(300); // eslint-disable-line -- documented interaction dwell
+    await page.waitForTimeout(300); // eslint-disable-line -- documented interaction dwell: typed-text registration has no observable signal
     await page.keyboard.press('Enter');
 
     const result = await waitForBoardLoaded(page, testLogger, 60000);
     console.log(`[TEST] ${DEMO.name} board-ready result: ${result}`);
 }
 
-/** Click a visible wx button by label; returns whether it was found. */
-async function clickWxButton(page: Page, label: string): Promise<boolean> {
-    const pos = await page.evaluate((wanted: string) => {
-        const registry = window.wxElementRegistry;
-        if (!registry) return null;
-        const el = registry.findAll({ visible: true })
-            .find((e) => (e.label === wanted || e.label === `&${wanted}`)
-                && (e.typeName ?? '').includes('Button'));
-        return el ? { x: el.centerX, y: el.centerY } : null;
-    }, label);
-    if (!pos) return false;
-    await page.mouse.click(pos.x, pos.y);
-    return true;
-}
-
 /** Drive File → Export → STEP through the (unchanged) dialog; return the capture. */
 async function runStepExport(page: Page): Promise<{ exp: ExportCapture; ensures: Array<{ op: string; arg: string }> }> {
-    expect(await clickMenuBarItem(page, 'File'), 'File menu').toBe(true);
-    await waitForMenuItems(page);
-    await waitForRenderedByLabel(page, 'Export', { elementType: 'menuitem' });
-    expect(await clickMenuItem(page, 'Export'), 'Export submenu').toBe(true);
-    // Wait for the SUBMENU's item — waitForMenuItems(>3) is satisfied by
-    // the still-rendered File menu items before the submenu paints.
-    await waitForRenderedByLabel(page, 'STEP/GLB/BREP/XAO/PLY/STL...', { elementType: 'menuitem' });
-    expect(await clickMenuItem(page, 'STEP/GLB/BREP/XAO/PLY/STL...'),
-        'STEP export menu item').toBe(true);
-
-    await page.waitForFunction(() => {
-        const registry = window.wxElementRegistry;
-        return !!registry && registry.findAll({ visible: true })
-            .some((el) => (el.label === 'Export' || el.label === '&Export')
-                && (el.typeName ?? '').includes('Button'));
-    }, null, { timeout: 20000 });
+    await openStepExportDialog(page);
 
     expect(await clickWxButton(page, 'Export'), 'Export button click').toBe(true);
 
@@ -258,10 +215,9 @@ test.describe('STEP export × 3D model delivery', () => {
         for (const f of missing.lib.slice(0, 5)) console.log(`[TEST]   missing lib: ${f}`);
         for (const f of missing.project) console.log(`[TEST]   missing project: ${f}`);
 
-        // Dismiss the export report dialog (its appearance after the worker
-        // returns has no distinct registry signal to poll).
-        await page.waitForTimeout(1000); // eslint-disable-line -- documented interaction dwell
-        await clickWxButton(page, 'OK');
+        // Dismiss the export report dialog via its modal lease (the export
+        // dialog holds 1; the report raises it to 2).
+        await dismissReportDialog(page, 1, 'export report');
 
         expect(testLogger.errors, 'no page errors during the export flow').toEqual([]);
     });