AI_Assistant/pcbjam
Watch
1
0
Fork
You've already forked pcbjam
 0
Code Issues Pull requests Projects Releases 4 Packages Wiki Activity Actions 2

fix(collab): re-push viewport on canvas resize — comment pins sat offset until pan/zoom

Browse source 
emitViewportIfChanged deduped on scale+center only, so a canvas SIZE change
(boot layout settling after the bind-time seed, window resize) never re-pushed
{w,h} to JS. CommentLayer's worldToScreen maps through h/2, so every DOM pin
hit target (and its hover ring) sat vertically offset from its GAL dot by
exactly delta-h/2 css-px until the next pan/zoom finally passed the dedupe.

Size now participates in the dedupe and wxEVT_SIZE re-pushes post-layout
(CallAfter, after the GAL's own onSize). New regression e2e
comments-viewport-resize.spec.ts asserts the DOM pin re-aligns with GAL truth
(fresh kicadCollabGetViewport) across a window resize with no pan/zoom.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011x3h5AzkWDbHmCkeVYAuzU
This commit is contained in:
Gergő Törcsvári 2026-07-09 16:31:41 +02:00
commit c229c75ca6
No known key found for this signature in database
GPG key ID: 8E75F2CDE64E5322
2 changed files with 135 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

28
wasm/bindings/collab_presence_core.h
View file

@ -142,6 +142,7 @@ struct CORE
long long lastCursorEmitMs = 0;
double lastVpScale = 0.0;
VECTOR2D lastVpCenter;
VECTOR2I lastVpSize;
// ── local state emit (selection / cursor / viewport) ──────────────────
@ -203,17 +204,23 @@ struct CORE
if( !fr )
return;
KIGFX::VIEW* view = fr->GetCanvas()->GetView();
double scale = view->GetScale(); // zoom — cheap change detector only
VECTOR2D c = view->GetCenter();
KIGFX::VIEW* view = fr->GetCanvas()->GetView();
double scale = view->GetScale(); // zoom — cheap change detector only
VECTOR2D c = view->GetCenter();
const VECTOR2I& sz = view->GetScreenPixelSize();
if( scale == lastVpScale && c == lastVpCenter )
// Size participates in the dedupe: the JS worldToScreen maps through
// w/2,h/2, so a canvas resize (or the boot layout settling after the
// bind-time seed) with an unchanged scale/center must still re-push —
// else every DOM pin target is vertically offset until the next
// pan/zoom.
if( scale == lastVpScale && c == lastVpCenter && sz == lastVpSize )
return;
lastVpScale = scale;
lastVpCenter = c;
lastVpSize = sz;
const VECTOR2I& sz = view->GetScreenPixelSize();
// px per IU via the GAL matrix — GetScale() is the zoom, not px/IU.
pcbjam_collab::emitViewport( c.x, c.y, view->ToScreen( 1.0 ), sz.x, sz.y );
@ -453,6 +460,17 @@ struct CORE
canvas->Bind( wxEVT_RIGHT_UP, [selAndViewport]( wxMouseEvent& e ) { selAndViewport( e ); } );
canvas->Bind( wxEVT_KEY_UP, [selAndViewport]( wxKeyEvent& e ) { selAndViewport( e ); } );
canvas->Bind( wxEVT_MOUSEWHEEL, [selAndViewport]( wxMouseEvent& e ) { selAndViewport( e ); } );
// Canvas resizes change the w/h half of the world↔screen transform
// without touching scale/center — re-push post-layout (CallAfter runs
// after the GAL's own onSize updated the screen size).
canvas->Bind( wxEVT_SIZE, [this]( wxSizeEvent& e )
{
e.Skip();
if( EDA_DRAW_FRAME* f = frame() )
f->CallAfter( [this]() { emitViewportIfChanged(); } );
} );
}
/** kicadCollabSetRemote: full remote-peers snapshot — `{peers:[{id,name,