test(screenshots): restore screenshot-neutrality after the determinism refactor

Browse source

The determinism conversion silently dropped/renamed screenshots vs the committed
baselines, so CI flagged ~35 baselines as "removed". Restore them:

- pl_editor-*: re-add the "pl_editor-" prefix the conversion dropped (5).
- Buffer screenshots that lost their path: (eeschema draw-wires/loaded-css,
  pcbnew draw-lines/loaded-css, pcbnew-move, dark-mode, eeschema-crosshair,
  aui-resize) re-add path:'test-results/<name>' so they SAVE and still feed the
  in-test pixel-diff analysis (17).
- Dropped animating/loading captures re-added via stableShot / raw screenshot:
  timer-03/05/06, dialogs-timer-running/started, wxgrid-02/03, 01-loading (7).

Delete 5 obsolete wizard baselines (eeschema/gerbview/pl_editor/symbol_editor/
generic -wizard-00-initial): every app is now seeded to bypass the first-run
setup wizard (that was the point of removing the wizard for/if loop), so those
states are no longer produced — pl_editor.spec asserts "no wizard appears"
instead.

Net: every committed baseline has a producer again (0 "removed"); determinism
guard green; affected specs pass (e2e 40, kicad 12) and emit the restored PNGs.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BVX1pHMvRPYHdp6ZfEawrk

...

This commit is contained in:

Viktor Vaczi 2026-07-07 11:35:39 +02:00

parent 4c3a4cacd4

commit c1eb08108b

16 changed files with 47 additions and 23 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

BIN

tests/baseline-screenshots/eeschema-wizard-00-initial.png

View file

Binary file not shown.

Side by side Before Width:  |  Height:  |  Size: 55 KiB

BIN

tests/baseline-screenshots/gerbview-wizard-00-initial.png

View file

Binary file not shown.

Side by side Before Width:  |  Height:  |  Size: 64 KiB

BIN

tests/baseline-screenshots/pl_editor-wizard-00-initial.png

View file

Binary file not shown.

Side by side Before Width:  |  Height:  |  Size: 60 KiB

BIN

tests/baseline-screenshots/symbol_editor-wizard-00-initial.png

View file

Binary file not shown.

Side by side Before Width:  |  Height:  |  Size: 42 KiB

BIN

tests/baseline-screenshots/wizard-00-initial.png

View file

Binary file not shown.

Side by side Before Width:  |  Height:  |  Size: 104 KiB