From b58ae49d6e6278ee4a21f6b62e33a8e107da79d2 Mon Sep 17 00:00:00 2001 From: Viktor Vaczi Date: Fri, 12 Jun 2026 14:19:34 +0200 Subject: [PATCH] fix(wasm): non-suspending clipboard predicate; kicad baselines for the DOM port MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - wxwidgets -> 25281178d2: wxClipboard::IsSupported answered via a 2 s Asyncify suspend on KiCad's idle path; overlapping suspensions corrupted Asyncify.currData ('indirect call to null'/'signature mismatch' storms after every document load — bug 2 of features/async). It now answers synchronously. The storms and 2 s UI stalls are gone. - 58 kicad screenshot baselines regenerated from the green run (the old set was canvas-only and died with the canvas port). - visual-notes: bug 29 + the known-red list — the 10 file-loading kicad specs (load-pcb, collab bridges, eeschema-ui keyboard/dialog) remain red on the unfixed asyncify substrate (bug 3, per-context currData authority). Bisect-verified pre-existing: binaries built from the pre-consolidation wx tree fault identically. Greening them is the async feature's exit criterion, deliberately out of scope here. Gates: wx e2e 292/0/1 skipped; kicad 32 passed / 10 known-red / 2 skipped (parity +1 with pre-consolidation, minus the timeout storms). Co-Authored-By: Claude Fable 5 --- docs/features/wx-dom-port/visual-notes.md | 21 ++++++++++++++++++ .../appearance-00-layers.png | Bin 0 -> 157771 bytes .../appearance-01-objects.png | Bin 0 -> 163335 bytes .../appearance-02-nets.png | Bin 0 -> 122256 bytes .../appearance-03-layers-again.png | Bin 0 -> 118238 bytes .../appearance-10-layers-scrolled.png | Bin 0 -> 155700 bytes .../appearance-11-layers-scrolled-back.png | Bin 0 -> 157771 bytes .../appearance-20-objects-scrolled.png | Bin 0 -> 163771 bytes .../calculator-before-switch.png | Bin 0 -> 111992 bytes .../calculator-color-code.png | Bin 0 -> 112758 bytes .../calculator-loaded.png | Bin 0 -> 111992 bytes ...schema-draw-wires-00-before-tool-click.png | Bin 0 -> 93001 bytes .../eeschema-draw-wires-01-after-click.png | Bin 0 -> 96384 bytes .../eeschema-draw-wires-02-after-drawing.png | Bin 0 -> 97317 bytes .../eeschema-load-rendered.png | Bin 0 -> 104267 bytes .../eeschema-loaded-css.png | Bin 0 -> 93001 bytes .../baseline-screenshots/eeschema-loaded.png | Bin 0 -> 93001 bytes .../eeschema-url-regex.png | Bin 0 -> 102742 bytes .../eeschema-wizard-00-initial.png | Bin 0 -> 93001 bytes .../gerbview-01-loaded.png | Bin 0 -> 61933 bytes .../gerbview-02-metrics.png | Bin 0 -> 61933 bytes .../gerbview-wizard-00-initial.png | Bin 0 -> 97354 bytes .../gerbview-wizard-01.png | Bin 0 -> 88092 bytes .../gerbview-wizard-02.png | Bin 0 -> 159277 bytes .../gerbview-wizard-03.png | Bin 0 -> 99579 bytes .../gerbview-wizard-04-finish.png | Bin 0 -> 61933 bytes .../load-pcb-microwave-00-pcbnew-ready.png | Bin 0 -> 157771 bytes .../load-pcb-microwave-01-dialog-open.png | Bin 0 -> 172444 bytes .../load-pcb-microwave.png | Bin 0 -> 157949 bytes ...oad-pcb-pic_programmer-00-pcbnew-ready.png | Bin 0 -> 157771 bytes ...load-pcb-pic_programmer-01-dialog-open.png | Bin 0 -> 172709 bytes .../load-pcb-pic_programmer.png | Bin 0 -> 306915 bytes ...pcbnew-draw-lines-00-before-tool-click.png | Bin 0 -> 157771 bytes .../pcbnew-draw-lines-01-after-click.png | Bin 0 -> 160729 bytes .../pcbnew-draw-lines-02-after-drawing.png | Bin 0 -> 167592 bytes .../pcbnew-loaded-css.png | Bin 0 -> 157771 bytes tests/baseline-screenshots/pcbnew-loaded.png | Bin 0 -> 157771 bytes .../pl_editor-01-loaded.png | Bin 0 -> 57495 bytes .../pl_editor-02-no-wizard.png | Bin 0 -> 57495 bytes .../pl_editor-03-file-menu.png | Bin 0 -> 65126 bytes .../pl_editor-04-save-as-dialog.png | Bin 0 -> 71209 bytes .../pl_editor-04b-after-enter.png | Bin 0 -> 71209 bytes .../pl_editor-load-rendered.png | Bin 0 -> 63722 bytes .../pl_editor-wizard-00-initial.png | Bin 0 -> 57495 bytes .../probe-00-after-wizard.png | Bin 0 -> 157771 bytes .../probe-01-file-menu-open.png | Bin 0 -> 169783 bytes .../probe-02-after-open-click.png | Bin 0 -> 169776 bytes tests/baseline-screenshots/probe-03-late.png | Bin 0 -> 169776 bytes .../symbol_editor-01-loaded.png | Bin 0 -> 71666 bytes .../symbol_editor-02-metrics.png | Bin 0 -> 71666 bytes .../symbol_editor-wizard-00-initial.png | Bin 0 -> 71666 bytes .../wizard-00-initial.png | Bin 0 -> 185236 bytes tests/baseline-screenshots/wizard-01.png | Bin 0 -> 176654 bytes tests/baseline-screenshots/wizard-02.png | Bin 0 -> 243511 bytes tests/baseline-screenshots/wizard-03.png | Bin 0 -> 186793 bytes .../baseline-screenshots/wizard-04-finish.png | Bin 0 -> 157771 bytes .../zoom-pl_editor-00-baseline.png | Bin 0 -> 58177 bytes .../zoom-pl_editor-01-zoomed-in-at-P.png | Bin 0 -> 51494 bytes .../zoom-pl_editor-02-zoomed-out-back.png | Bin 0 -> 59927 bytes wxwidgets | 2 +- 60 files changed, 22 insertions(+), 1 deletion(-) create mode 100644 tests/baseline-screenshots/appearance-00-layers.png create mode 100644 tests/baseline-screenshots/appearance-01-objects.png create mode 100644 tests/baseline-screenshots/appearance-02-nets.png create mode 100644 tests/baseline-screenshots/appearance-03-layers-again.png create mode 100644 tests/baseline-screenshots/appearance-10-layers-scrolled.png create mode 100644 tests/baseline-screenshots/appearance-11-layers-scrolled-back.png create mode 100644 tests/baseline-screenshots/appearance-20-objects-scrolled.png create mode 100644 tests/baseline-screenshots/calculator-before-switch.png create mode 100644 tests/baseline-screenshots/calculator-color-code.png create mode 100644 tests/baseline-screenshots/calculator-loaded.png create mode 100644 tests/baseline-screenshots/eeschema-draw-wires-00-before-tool-click.png create mode 100644 tests/baseline-screenshots/eeschema-draw-wires-01-after-click.png create mode 100644 tests/baseline-screenshots/eeschema-draw-wires-02-after-drawing.png create mode 100644 tests/baseline-screenshots/eeschema-load-rendered.png create mode 100644 tests/baseline-screenshots/eeschema-loaded-css.png create mode 100644 tests/baseline-screenshots/eeschema-loaded.png create mode 100644 tests/baseline-screenshots/eeschema-url-regex.png create mode 100644 tests/baseline-screenshots/eeschema-wizard-00-initial.png create mode 100644 tests/baseline-screenshots/gerbview-01-loaded.png create mode 100644 tests/baseline-screenshots/gerbview-02-metrics.png create mode 100644 tests/baseline-screenshots/gerbview-wizard-00-initial.png create mode 100644 tests/baseline-screenshots/gerbview-wizard-01.png create mode 100644 tests/baseline-screenshots/gerbview-wizard-02.png create mode 100644 tests/baseline-screenshots/gerbview-wizard-03.png create mode 100644 tests/baseline-screenshots/gerbview-wizard-04-finish.png create mode 100644 tests/baseline-screenshots/load-pcb-microwave-00-pcbnew-ready.png create mode 100644 tests/baseline-screenshots/load-pcb-microwave-01-dialog-open.png create mode 100644 tests/baseline-screenshots/load-pcb-microwave.png create mode 100644 tests/baseline-screenshots/load-pcb-pic_programmer-00-pcbnew-ready.png create mode 100644 tests/baseline-screenshots/load-pcb-pic_programmer-01-dialog-open.png create mode 100644 tests/baseline-screenshots/load-pcb-pic_programmer.png create mode 100644 tests/baseline-screenshots/pcbnew-draw-lines-00-before-tool-click.png create mode 100644 tests/baseline-screenshots/pcbnew-draw-lines-01-after-click.png create mode 100644 tests/baseline-screenshots/pcbnew-draw-lines-02-after-drawing.png create mode 100644 tests/baseline-screenshots/pcbnew-loaded-css.png create mode 100644 tests/baseline-screenshots/pcbnew-loaded.png create mode 100644 tests/baseline-screenshots/pl_editor-01-loaded.png create mode 100644 tests/baseline-screenshots/pl_editor-02-no-wizard.png create mode 100644 tests/baseline-screenshots/pl_editor-03-file-menu.png create mode 100644 tests/baseline-screenshots/pl_editor-04-save-as-dialog.png create mode 100644 tests/baseline-screenshots/pl_editor-04b-after-enter.png create mode 100644 tests/baseline-screenshots/pl_editor-load-rendered.png create mode 100644 tests/baseline-screenshots/pl_editor-wizard-00-initial.png create mode 100644 tests/baseline-screenshots/probe-00-after-wizard.png create mode 100644 tests/baseline-screenshots/probe-01-file-menu-open.png create mode 100644 tests/baseline-screenshots/probe-02-after-open-click.png create mode 100644 tests/baseline-screenshots/probe-03-late.png create mode 100644 tests/baseline-screenshots/symbol_editor-01-loaded.png create mode 100644 tests/baseline-screenshots/symbol_editor-02-metrics.png create mode 100644 tests/baseline-screenshots/symbol_editor-wizard-00-initial.png create mode 100644 tests/baseline-screenshots/wizard-00-initial.png create mode 100644 tests/baseline-screenshots/wizard-01.png create mode 100644 tests/baseline-screenshots/wizard-02.png create mode 100644 tests/baseline-screenshots/wizard-03.png create mode 100644 tests/baseline-screenshots/wizard-04-finish.png create mode 100644 tests/baseline-screenshots/zoom-pl_editor-00-baseline.png create mode 100644 tests/baseline-screenshots/zoom-pl_editor-01-zoomed-in-at-P.png create mode 100644 tests/baseline-screenshots/zoom-pl_editor-02-zoomed-out-back.png diff --git a/docs/features/wx-dom-port/visual-notes.md b/docs/features/wx-dom-port/visual-notes.md index c91dabb..078d4e8 100644 --- a/docs/features/wx-dom-port/visual-notes.md +++ b/docs/features/wx-dom-port/visual-notes.md @@ -214,3 +214,24 @@ pre-consolidation tree, which failed identically): page.mouse. The minimal-app comprehensive spec drives the wxChoice through its native