jspi cleanup: remove the asyncify-era residue — dead code, conditionals, pipeline scaffolding, stale prose
The runtime is JSPI-only; this removes everything that still pretended otherwise. Three exhaustive sweeps (C++/JS+build+CI/tests+docs) drove the inventory; every deletion verified by grep closure + full gates. Broken-right-now fixes: - deploy-staging.yml passed the retired opt_level input — the workflow could not even start. Removed. - env.sh carried dead exports with a live -sASYNCIFY=1 inside (WASM_LDFLAGS/PTHREAD_LDFLAGS, zero consumers). Removed; the WASM_LEGACY_EXCEPTIONS rationale rewritten to the real reason. - docker/build.sh exported PCBJAM_ASYNC_BACKEND (read nowhere). Gone. Dead weight removed: - binaryen submodule (nothing builds or invokes it), wasm-opt-bench workflow + scripts/bench/, get-wasm-opt.sh, diagnostics.js (242 lines of Asyncify-API-only code), the KICAD_PIPELINE background-postprocess scaffolding (existed to parallelize the deleted wasm-opt phase; the postprocess is a seconds-long node script and now runs inline), build-monitor's dead asyncify rows, sched-context orphan build output, dead .gitignore entries, the .jspi-assets spike dir (the two wf-result research JSONs moved to docs/features/async/migration-evidence/). - bindings: fiber_park.h + its 12 embind registrations (broken-if- called under JSPI), the kicadOpenFileStart/OPEN_JOB starter route, main_stack_runner.h + 5 includes, the always-null context-sleep weak hook in nanosleep_yield.c. - shim: the backend field (installed-flag idempotency instead), noteContextWait (dead both sides), the __wxAsyncifyDump alias (+ the WasmTool fallback and string-dump normalize branch). - web: the emscripten-6-ignored mainScriptUrlOrBlob option in boot.ts (gerber-demo keeps it: it loads the deployed CDN release, which predates emscripten 6 — noted inline). Conditionals: all 'backend === jspi' checks reduced to scheduler- presence checks; races_quiescent re-keyed from Asyncify.state (vacuous) to real backlog quiescence (resumeReady/mutatorQueue — NOT _windowLive, which is the probing activation's own window by definition). Renames (identifiers only, no file renames): ASYNC_LINK_FLAGS→ JSPI_LINK_FLAGS and Makefile ASYNC_LDFLAGS→JSPI_LDFLAGS, kicadCollabFiberBusy→kicadCollabBusy (embind + web + tests), collab_common.h fiber*→apply*/coroutine naming, asyncifySignatures→ wasmTrapSignatures (lists byte-identical). Tests: the two remaining vacuous [wx-asyncify]/fiber-resume-refused asserts re-keyed to live JSPI beacons; eeschema-load's failure message no longer sends the developer to a deleted script; wait-beacons' dead families/parser deleted; lane-0 legacy-glue guards removed (lane 0 is unconstructible); the embind test.fail re-gated with the JSPI reason (plain embind invokers cannot suspend — verified still failing); lint-determinism now scans tests/jspi (166 files clean); eeschema-collab local-move gated to chromium (~50% flaky on FF even solo; pcbnew twin covers both engines). Docs: DEBUG.md rewritten as the JSPI debugging guide; build.md describes the single-phase build; docs/features/async/README.md banner-marked historical and repointed at the NEW 23-jspi-runtime.md (current architecture: export census, turnstile, libcontext ownership + refusal contract, embind call shapes, the em-pthread service-wrapper trick, exception policy, known gaps). Gates on the cleaned tree: test:e2e 725 passed / 0 failed (after the quiescence-probe fix; the 3 other reds were verified contention flakes solo-green or the documented FF gate), web 76/0, jspi 18/18 both engines, vitest 295/295 + 17/17, all lints green, live-app census clean. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016X9eh1s5sTx1o9Em9KBuwR
This commit is contained in:
parent
3ee174e9b4
commit
9c475a804e
120 changed files with 1522 additions and 2974 deletions
|
|
@ -8,13 +8,13 @@ import { clickMenuBarItem, clickMenuItemByText } from '../e2e/utils/element-trac
|
|||
* (a quasi-modal running a NESTED event loop, opened from the place-footprint
|
||||
* TOOL COROUTINE) → click Cancel → the whole UI freezes.
|
||||
*
|
||||
* Root cause (recorder, live demo board): the nested loop parks IN PLACE on the
|
||||
* tool coroutine's fiber stack (`inplace-park-on-fiber-stack`), then the resume
|
||||
* that would close it is refused by the stale-fiber quarantine
|
||||
* (`fiber-resume-refused: … asyncify-parked mid-body`) and dropped — the
|
||||
* doc-19 disease. It was masked by the mainstack bounce until Phase F4 removed
|
||||
* it; the footprint chooser has no automated coverage so the removal went
|
||||
* unnoticed. This spec is that coverage.
|
||||
* Root cause (recorder, live demo board, found asyncify-era): the nested loop
|
||||
* parked IN PLACE on the tool coroutine's stack, then the resume that would
|
||||
* close it was refused by the stale-fiber quarantine
|
||||
* and dropped — the doc-19 disease. It was masked by
|
||||
* the mainstack bounce until Phase F4 removed it; the footprint chooser had no
|
||||
* automated coverage so the removal went unnoticed. This spec is that coverage,
|
||||
* kept as the dead-app liveness gate for the chooser's nested wait.
|
||||
*
|
||||
* Mechanics that matter: the chooser is a wxFrame (not a wxDialog), so detect
|
||||
* it by a second top-level frame + a "nested" scheduler wait; drive the canvas
|
||||
|
|
@ -138,8 +138,8 @@ test.describe('Add Footprint chooser close (doc-19 dead-app repro)', () => {
|
|||
expect(cancel, 'Cancel button found').not.toBeNull();
|
||||
await synthClick(page, cancel!.x, cancel!.y);
|
||||
|
||||
// The chooser must close AND the app must stay alive. On the broken
|
||||
// build the loop stalls here (the dropped fiber resume).
|
||||
// The chooser must close AND the app must stay alive. On a broken
|
||||
// build the loop stalls here (a dropped coroutine resume).
|
||||
await page
|
||||
.waitForFunction(
|
||||
(n) =>
|
||||
|
|
|
|||
Loading…
Reference in a new issue