From 9697de7b26dcadbe5ee0cfe5194e86007c9923ac Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gerg=C5=91=20T=C3=B6rcsv=C3=A1ri?= Date: Wed, 8 Jul 2026 15:46:51 +0200 Subject: [PATCH] deploy: pass --models-tag in release.yml demo + editor builds MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The tag-triggered release pipeline built the demo (and backed editor) without --models-tag, so modelsSourceConfig() returned null and every kind=model3d ensure logged "(unserved)" — 3D component models never loaded on demo.pcbjam.com. The manual deploy-demo.yml already passed it; mirror its MODELS_TAG env (10.0.3) in release.yml for both builds. Co-Authored-By: Claude Fable 5 Claude-Session: https://claude.ai/code/session_01UQRBzfidkoTU5yc7HnF9x7 --- .github/workflows/release.yml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 027e8d5..cd8196a 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -33,6 +33,11 @@ env: BUCKET: pcbjam-cdn # KiCad library snapshot the demo points at (published by publish-libs.yml). LIB_TAG: "10.0.3" + # kicad-packages3D snapshot the demo's lazy 3D models point at (published once + # to libs/kicad-models// — see scripts/deploy/publish-models.ts + + # upload-models-r2.sh; docs/features/3d-models). Empty ⇒ 3D models off. + # Keep in sync with deploy-demo.yml. + MODELS_TAG: "10.0.3" PAGES_PROJECT: pcbjam-demo PAGES_PROD_BRANCH: production # Backed editor deployment (remote mode against the closed API). The closed @@ -124,6 +129,7 @@ jobs: run: > node scripts/deploy/build-demo.mjs --tag "${{ needs.meta.outputs.tag }}" --cdn "$CDN" --lib-tag "$LIB_TAG" + ${MODELS_TAG:+--models-tag "$MODELS_TAG"} --plausible "${{ vars.PLAUSIBLE_DOMAIN }}" - name: Ensure Pages project exists @@ -172,6 +178,7 @@ jobs: node scripts/deploy/build-editor.mjs --tag "$RELEASE_TAG" --cdn "$CDN" --api-base "$EDITOR_API_BASE" --plausible "editor.pcbjam.com" + ${MODELS_TAG:+--models-tag "$MODELS_TAG"} - name: Ensure Pages project exists run: >