AI_Assistant/pcbjam
Watch
1
0
Fork
You've already forked pcbjam
 0
Code Issues Pull requests Projects Releases 4 Packages Wiki Activity Actions 2

fix(test): Fix WebGL screenshot capture and comparison

Browse source 
1. Fix gal-webgl.spec.ts sequential test:
   - Wait for isReady() not just module existence
   - Use .gl-canvas selector (same as individual tests)
   - Increase timeout from 50ms to 100ms
   - This fixes blank screenshots in full test runs

2. Fix test-gal-regression.sh comparison:
   - Normalize PNG format before comparing (flatten + sRGB TrueColor)
   - This handles RGBA vs RGB and palette differences
   - gal-basic-lines now passes comparison (0.34% different)

Results after fixes:
- Native vs Baseline: PASSED (28/28)
- WebGL screenshots now capture actual rendered content
- gal-basic-lines matches native (first successful scenario!)
- Other scenarios have rendering differences to investigate

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Viktor Vaczi 2026-01-08 11:32:39 +01:00
commit 8f803b45ea
2 changed files with 23 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

20
tests/e2e/gal-webgl.spec.ts
View file

@ -162,13 +162,22 @@ test.describe('GAL WebGL Regression Tests', () => {
test('Run all scenarios sequentially', async ({ page, testLogger }) => {
await page.goto('/gal-webgl/gal_webgl_test.html');
// Wait for module to be ready
// Wait for module to be fully ready (not just defined)
await page.waitForFunction(() => {
return (window as any).galTest !== undefined;
return (window as any).galTest !== undefined && (window as any).galTest.isReady();
}, { timeout: 60000 });
console.log('Running all 28 scenarios...');
// Find the GL canvas (same logic as individual tests)
let canvas = page.locator('.gl-canvas').first();
if (!(await canvas.count())) {
canvas = page.locator('#canvas');
}
if (!(await canvas.count())) {
canvas = page.locator('canvas').first();
}
for (let i = 0; i < SCENARIO_NAMES.length; i++) {
const scenarioName = SCENARIO_NAMES[i];
@ -177,14 +186,13 @@ test.describe('GAL WebGL Regression Tests', () => {
(window as any).galTest.runScenario(index);
}, i);
// Wait for rendering
await page.waitForTimeout(50);
// Wait for rendering to complete (same timeout as individual tests)
await page.waitForTimeout(100);
// Hide controls overlay before screenshot
await page.locator('#controls-overlay').evaluate(el => el.style.visibility = 'hidden');
// Screenshot the canvas
const canvas = await page.locator('#canvas');
// Screenshot the GL canvas
const screenshotPath = path.join(OUTPUT_DIR, `gal-${scenarioName}.png`);
await canvas.screenshot({ path: screenshotPath });