AI_Assistant/pcbjam
Watch
1
0
Fork
You've already forked pcbjam
 0
Code Issues Pull requests Projects Releases 7 Packages Wiki Activity Actions

Extend element registry and migrate all tests to semantic selectors

Browse source 
Phase 2 of element registry migration - eliminate hardcoded coordinates:

Element tracker additions:
- wxTreeCtrl items (clickTreeItem, findTreeItem)
- wxDataViewCtrl items and column headers
- wxPropertyGrid rows
- wxListBox items
- wxSpinButton arrows
- wxSlider thumb/track
- wxTextCtrl area
- wxSearchCtrl field
- wxAuiManager pane content areas
- wxCalendarCtrl dates

Test migrations:
- 24 test files updated to use element registry helpers
- Replaced coordinate-based clicks with semantic selectors
- Added find-hardcoded-coords.sh script for auditing

Remaining coordinates are legitimate (scroll positioning, drawing, test.fail blocks).

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Viktor Vaczi 2025-12-30 14:17:51 +01:00
commit 64142aa8de
27 changed files with 1710 additions and 839 deletions
Download patch file Download diff file Expand all files Collapse all files

77
tests/e2e/wizard.spec.ts
View file

@ -1,5 +1,6 @@
// wxWizard Tests - Footprint Wizard simulation
import { test, expect, tryLoadApp } from './utils/fixtures';
import { clickByLabel } from './utils/element-tracker';
test.describe('wxWizard Tests', () => {
@ -23,13 +24,10 @@ test.describe('wxWizard Tests', () => {
await page.waitForTimeout(300);
const canvas = page.locator('#canvas');
const box = await canvas.boundingBox();
if (box) {
// Click Launch button
await page.mouse.click(box.x + 120, box.y + 60);
await page.waitForTimeout(500);
}
// Click Launch button using element registry
const clicked = await clickByLabel(page, 'Launch Footprint Wizard');
expect(clicked, 'Launch Wizard button should be found and clicked').toBe(true);
await page.waitForTimeout(500);
await page.screenshot({ path: 'test-results/wizard-02-launch.png', fullPage: true });
});
@ -44,16 +42,15 @@ test.describe('wxWizard Tests', () => {
await page.waitForTimeout(300);
const canvas = page.locator('#canvas');
const box = await canvas.boundingBox();
if (box) {
// Launch wizard
await page.mouse.click(box.x + 120, box.y + 60);
await page.waitForTimeout(500);
// Click Next
await page.mouse.click(box.x + 500, box.y + 400);
await page.waitForTimeout(200);
}
// Launch wizard using element registry
const launchClicked = await clickByLabel(page, 'Launch Footprint Wizard');
expect(launchClicked, 'Launch Wizard button should be found').toBe(true);
await page.waitForTimeout(500);
// Click Next using element registry
const nextClicked = await clickByLabel(page, 'Next');
expect(nextClicked, 'Next button should be found and clicked').toBe(true);
await page.waitForTimeout(200);
await page.screenshot({ path: 'test-results/wizard-03-next-page.png', fullPage: true });
});
@ -68,19 +65,20 @@ test.describe('wxWizard Tests', () => {
await page.waitForTimeout(300);
const canvas = page.locator('#canvas');
const box = await canvas.boundingBox();
if (box) {
// Launch wizard
await page.mouse.click(box.x + 120, box.y + 60);
await page.waitForTimeout(500);
// Click Next
await page.mouse.click(box.x + 500, box.y + 400);
await page.waitForTimeout(200);
// Click Back
await page.mouse.click(box.x + 400, box.y + 400);
await page.waitForTimeout(200);
}
// Launch wizard using element registry
const launchClicked = await clickByLabel(page, 'Launch Footprint Wizard');
expect(launchClicked, 'Launch Wizard button should be found').toBe(true);
await page.waitForTimeout(500);
// Click Next using element registry
const nextClicked = await clickByLabel(page, 'Next');
expect(nextClicked, 'Next button should be found').toBe(true);
await page.waitForTimeout(200);
// Click Back using element registry
const backClicked = await clickByLabel(page, 'Back');
expect(backClicked, 'Back button should be found and clicked').toBe(true);
await page.waitForTimeout(200);
await page.screenshot({ path: 'test-results/wizard-04-back-page.png', fullPage: true });
});
@ -95,16 +93,15 @@ test.describe('wxWizard Tests', () => {
await page.waitForTimeout(300);
const canvas = page.locator('#canvas');
const box = await canvas.boundingBox();
if (box) {
// Launch wizard
await page.mouse.click(box.x + 120, box.y + 60);
await page.waitForTimeout(500);
// Click Cancel
await page.mouse.click(box.x + 300, box.y + 400);
await page.waitForTimeout(200);
}
// Launch wizard using element registry
const launchClicked = await clickByLabel(page, 'Launch Footprint Wizard');
expect(launchClicked, 'Launch Wizard button should be found').toBe(true);
await page.waitForTimeout(500);
// Click Cancel using element registry
const cancelClicked = await clickByLabel(page, 'Cancel');
expect(cancelClicked, 'Cancel button should be found and clicked').toBe(true);
await page.waitForTimeout(200);
await page.screenshot({ path: 'test-results/wizard-05-cancel.png', fullPage: true });
});