AI_Assistant/pcbjam
Watch
1
0
Fork
You've already forked pcbjam
 0
Code Issues Pull requests Projects Releases 7 Packages Wiki Activity Actions

Extend element registry and migrate all tests to semantic selectors

Browse source 
Phase 2 of element registry migration - eliminate hardcoded coordinates:

Element tracker additions:
- wxTreeCtrl items (clickTreeItem, findTreeItem)
- wxDataViewCtrl items and column headers
- wxPropertyGrid rows
- wxListBox items
- wxSpinButton arrows
- wxSlider thumb/track
- wxTextCtrl area
- wxSearchCtrl field
- wxAuiManager pane content areas
- wxCalendarCtrl dates

Test migrations:
- 24 test files updated to use element registry helpers
- Replaced coordinate-based clicks with semantic selectors
- Added find-hardcoded-coords.sh script for auditing

Remaining coordinates are legitimate (scroll positioning, drawing, test.fail blocks).

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Viktor Vaczi 2025-12-30 14:17:51 +01:00
commit 64142aa8de
27 changed files with 1710 additions and 839 deletions
Download patch file Download diff file Expand all files Collapse all files

54
tests/e2e/gridedit.spec.ts
View file

@ -1,5 +1,6 @@
// wxGrid Cell Editing Tests - Property editing simulation
import { test, expect, tryLoadApp } from './utils/fixtures';
import { clickByLabel, clickGridCell, findGridCell } from './utils/element-tracker';
test.describe('wxGrid Cell Editing Tests', () => {
@ -23,13 +24,10 @@ test.describe('wxGrid Cell Editing Tests', () => {
await page.waitForTimeout(300);
const canvas = page.locator('#canvas');
const box = await canvas.boundingBox();
if (box) {
// Click on a cell
await page.mouse.click(box.x + 150, box.y + 180);
await page.waitForTimeout(200);
}
// Click on a cell using element registry
const clicked = await clickGridCell(page, 1, 1);
expect(clicked, 'Grid cell should be found and clicked').toBe(true);
await page.waitForTimeout(200);
await page.screenshot({ path: 'test-results/gridedit-02-select-cell.png', fullPage: true });
});
@ -44,13 +42,13 @@ test.describe('wxGrid Cell Editing Tests', () => {
await page.waitForTimeout(300);
const canvas = page.locator('#canvas');
const box = await canvas.boundingBox();
if (box) {
// Double-click to enter edit mode
await page.mouse.dblclick(box.x + 150, box.y + 180);
await page.waitForTimeout(300);
// Double-click to enter edit mode using element registry
const cell = await findGridCell(page, 1, 1);
expect(cell, 'Grid cell should be found').not.toBeNull();
if (cell) {
await page.mouse.dblclick(cell.centerX, cell.centerY);
}
await page.waitForTimeout(300);
await page.screenshot({ path: 'test-results/gridedit-03-edit-cell.png', fullPage: true });
});
@ -65,13 +63,10 @@ test.describe('wxGrid Cell Editing Tests', () => {
await page.waitForTimeout(300);
const canvas = page.locator('#canvas');
const box = await canvas.boundingBox();
if (box) {
// Click Add Row button
await page.mouse.click(box.x + 60, box.y + 60);
await page.waitForTimeout(200);
}
// Click Add Row button using element registry
const clicked = await clickByLabel(page, 'Add Row');
expect(clicked, 'Add Row button should be found and clicked').toBe(true);
await page.waitForTimeout(200);
await page.screenshot({ path: 'test-results/gridedit-04-add-row.png', fullPage: true });
});
@ -86,16 +81,15 @@ test.describe('wxGrid Cell Editing Tests', () => {
await page.waitForTimeout(300);
const canvas = page.locator('#canvas');
const box = await canvas.boundingBox();
if (box) {
// Select a row first
await page.mouse.click(box.x + 150, box.y + 180);
await page.waitForTimeout(100);
// Click Delete Row button
await page.mouse.click(box.x + 150, box.y + 60);
await page.waitForTimeout(200);
}
// Select a row first using element registry
const cellClicked = await clickGridCell(page, 1, 1);
expect(cellClicked, 'Grid cell should be found and clicked').toBe(true);
await page.waitForTimeout(100);
// Click Delete Row button using element registry
const deleteClicked = await clickByLabel(page, 'Delete Row');
expect(deleteClicked, 'Delete Row button should be found and clicked').toBe(true);
await page.waitForTimeout(200);
await page.screenshot({ path: 'test-results/gridedit-05-delete-row.png', fullPage: true });
});