e2e/CI: dual-engine suites, per-engine screenshots, SwiftShader retired, prod web suite, CI-coverage gate
Squash of experiment/ff-big-modules vs main.
Big-module routing removed: native-EH shrank kicad_editor below
SpiderMonkey's x86-64 code budget (runs 29355049705/29356152413 green on
stock Firefox), so BIG_MODULE_SPECS routing and the baseline-only-JIT
crutch are gone — kicad-firefox and kicad-chromium both run the full
suite, with the module compiled the way real users' browsers compile it.
Per-engine screenshots end to end: stableShot/shotPath write
test-results/<engine>/<name>.png; baselines move to
baseline-screenshots/{chromium,firefox}/ and the whole tools/screenshots
pipeline (compare/promote/manifest/spec-map/changelog/Discord) keys on
<engine>/<name>. Previously Firefox and Chromium renders of one spec
overwrote each other and Firefox renders were never actually gated.
Seeded from CI run 29421380806 (92 new firefox baselines, +24 chromium
web-suite shots); manifest generated from the baseline tree.
One merged playwright.config.ts (kicad/asyncify/coroutine/perf as
projects); ~25 dead npm scripts dropped. The web suite is gated in CI for
the first time ever (4 rotted specs fixed, 5 broken lib-bridge specs
triaged as fixme in docs/features/web-e2e-rot/); cheap lint step after
npm ci; last 26 blind-sleep violations fixed.
SwiftShader retired: CI Chromium renders WebGL on ANGLE → Mesa llvmpipe
(--use-gl=angle --use-angle=gl --ignore-gpu-blocklist; the blocklist flag
is mandatory — llvmpipe is blocklisted and WebGL is silently unavailable
without it) in BOTH configs. Under WORKERS=4 congestion SwiftShader
transiently failed the first post-board-load draw and the recovery
cascade ended in a silent permanent Cairo fallback — that engine flip was
the "~1.2% changedRatio both directions" occ-export baseline flake.
Validated 160/160 across two 80-repeat rigs; full analysis in
docs/features/wx-parity-bugs/occ-export-context-eviction.md. Chromium
baselines shift slightly on llvmpipe — promote once from the first green
run. Deflakes the new coverage exposed: presence baselines settle before
capture; presence fixtures declare current file formats; perf gets its
own outputDir so CI evidence survives; occ-export settles the board paint
before the export dialog; menu-item waits (waitForRenderedByLabel before
clickMenuItem) in 4 specs + the TESTING.md rule.
Web suite runs the PROD build, in parallel: webServer becomes backend
`start` + the standalone's e2e:preview (build-preview.mjs: link-wasm →
stash the public/wasm symlink aside during vite build, build-demo.mjs's
move — then vite preview as the persistent server). The wasm middleware
serves /wasm/* in preview and emits COOP/COEP/CORP itself (a pthread
worker script's own response must carry COEP or Chrome kills it with
ERR_BLOCKED_BY_RESPONSE). VITE_* flags bake at build time;
VITE_ALLOW_USER_OVERRIDE joins turbo globalEnv. fullyParallel + default
workers: 5.2m → 1.4m. Determinism fixes the parallel run exposed:
shared-page specs become serial groups; locks.spec grabs alice's exact
item via the new kicadCollabTestSelectByUuid hook (cross-tab "first
footprint" order is not a ysync invariant); quit specs poll page.url()
(quit supersedes its own navigation — NS_BINDING_ABORTED on Firefox).
Suite: 51 passed / 12 skipped / 0 failed in 1.6m.
CI-coverage gate (lint:ci-coverage): every tests/**/*.spec.ts must be
reachable from the npm scripts the workflows invoke — scraped from
.github/workflows/, resolved through package.json, coverage asked from
playwright --list itself. Rules: uncovered-spec + orphan-project (with a
documented LOCAL_ONLY_PROJECTS allowlist). Gating next to
lint:determinism; 138 spec files / 13 projects accounted for.
Product fixes kept from the investigations (reachable on real GPUs too):
wx 7799fd1be5 — paint flags clear before dispatch + Invalidate always
propagates; kicad 3dcfea5e45 — SwiftShader pass-boundary flush +
per-instance font texture + first-frame GL-error drain (GAL recovery
recovers instead of falling back to Cairo) + the user-facing eeschema
switch navigates again under __EMSCRIPTEN__ (project-sync's
FaceRegistered gate had rerouted it into the hidden sync player; caught
by the newly-gated web suite).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018eUxiPApHgGiu9NFyQfhAq
This commit is contained in:
parent
8a20f69c5e
commit
63ed1f3c1f
556 changed files with 2470 additions and 1389 deletions
|
|
@ -8,13 +8,44 @@
|
|||
* Paths are relative to the `tests/` directory (that is the working directory
|
||||
* the npm scripts and CI steps run from).
|
||||
*/
|
||||
import * as nodeFs from 'fs';
|
||||
import * as nodePath from 'path';
|
||||
|
||||
/**
|
||||
* Committed baseline directory. Single dir on purpose: `e2e/baseline-screenshots/`
|
||||
* used to also hold a few names (grid-tab-final, wxgrid-*) that ALSO live here with
|
||||
* different bytes — so they got silently shadowed. Consolidated to one dir.
|
||||
* Committed baseline root. One PER-ENGINE subdirectory per browser family:
|
||||
* `baseline-screenshots/{chromium,firefox}/<name>.png`. Renders mirror the
|
||||
* layout (`test-results/<engine>/<name>.png`, written by stableShot/shotPath),
|
||||
* so each engine is gated against its OWN baselines — the old flat namespace
|
||||
* let two engines running the same spec overwrite each other's PNG, and the
|
||||
* surviving file was whichever parallel worker wrote last.
|
||||
*/
|
||||
export const BASELINE_DIRS = ['baseline-screenshots'] as const;
|
||||
export const BASELINE_ROOT = 'baseline-screenshots';
|
||||
|
||||
/** Engine subdirectories the tooling recognizes (a browser family per dir). */
|
||||
export const ENGINES = ['chromium', 'firefox', 'webkit'] as const;
|
||||
|
||||
/**
|
||||
* The canonical screenshot key is `<engine>/<name>.png` — the path of both the
|
||||
* render (under test-results/) and the baseline (under baseline-screenshots/)
|
||||
* relative to their root.
|
||||
*/
|
||||
export function splitKey(key: string): { engine: string; name: string } {
|
||||
const i = key.indexOf('/');
|
||||
return i < 0 ? { engine: 'unknown', name: key } : { engine: key.slice(0, i), name: key.slice(i + 1) };
|
||||
}
|
||||
|
||||
/** Engine-qualified keys (`<engine>/<name>.png`) found under a root's engine subdirs. */
|
||||
export function listEngineKeys(base: string): string[] {
|
||||
const keys: string[] = [];
|
||||
for (const engine of ENGINES) {
|
||||
const dir = nodePath.join(base, engine);
|
||||
if (!nodeFs.existsSync(dir)) continue;
|
||||
for (const f of nodeFs.readdirSync(dir)) {
|
||||
if (f.toLowerCase().endsWith('.png')) keys.push(`${engine}/${f}`);
|
||||
}
|
||||
}
|
||||
return keys;
|
||||
}
|
||||
|
||||
/** Where Playwright writes the current run's screenshots (gitignored). */
|
||||
export const RESULTS_DIR = 'test-results';
|
||||
|
|
@ -67,9 +98,10 @@ export const TRIPTYCH = {
|
|||
*/
|
||||
export type EngineFloor = { changedRatio: number; meanChannelGuard: number };
|
||||
|
||||
// Keyed by engine dir name (CI renderers: firefox = Mesa llvmpipe, chromium = SwiftShader).
|
||||
export const FLOORS: Record<string, EngineFloor> = {
|
||||
'firefox-llvmpipe': { changedRatio: 0.005, meanChannelGuard: 2.0 },
|
||||
'chromium-swiftshader': { changedRatio: 0.005, meanChannelGuard: 2.0 },
|
||||
firefox: { changedRatio: 0.005, meanChannelGuard: 2.0 },
|
||||
chromium: { changedRatio: 0.005, meanChannelGuard: 2.0 },
|
||||
default: { changedRatio: 0.005, meanChannelGuard: 2.0 },
|
||||
};
|
||||
|
||||
|
|
@ -88,9 +120,10 @@ export const IGNORE_REGIONS: Record<string, Array<{ x: number; y: number; width:
|
|||
*/
|
||||
export const IGNORE_SCREENSHOTS = new Set<string>(['retinascale-01-loaded.png']);
|
||||
|
||||
/** True if a screenshot is excluded from comparison. */
|
||||
export function isIgnored(name: string): boolean {
|
||||
return IGNORE_SCREENSHOTS.has(name);
|
||||
/** True if a screenshot is excluded from comparison. Matches the bare name, so an
|
||||
* ignored screenshot is ignored in every engine. */
|
||||
export function isIgnored(key: string): boolean {
|
||||
return IGNORE_SCREENSHOTS.has(splitKey(key).name);
|
||||
}
|
||||
|
||||
/** Bottom caption strip baked onto each posted composite (status + name + spec). */
|
||||
|
|
@ -109,17 +142,21 @@ export const LABEL = {
|
|||
|
||||
export type LabelStatus = 'added' | 'removed' | 'changed' | 'unchanged';
|
||||
|
||||
/** Caption text: `CHANGED name.png · kicad/pcbnew.spec.ts` (spec omitted if unknown). */
|
||||
export function labelText(status: LabelStatus, name: string, spec: string | null): string {
|
||||
/** Caption text: `CHANGED [chromium] name.png · kicad/pcbnew.spec.ts` (spec omitted if
|
||||
* unknown). The engine is PREPENDED — the auto-fit strip truncates the tail, so a
|
||||
* trailing tag could be cut off on long names. Accepts an engine-qualified key. */
|
||||
export function labelText(status: LabelStatus, key: string, spec: string | null): string {
|
||||
const s = status.toUpperCase();
|
||||
return spec ? `${s} ${name} · ${spec}` : `${s} ${name}`;
|
||||
const { engine, name } = splitKey(key);
|
||||
const head = `${s} [${engine}] ${name}`;
|
||||
return spec ? `${head} · ${spec}` : head;
|
||||
}
|
||||
|
||||
export type ManifestEntry = { name: string; engine: string };
|
||||
export type Manifest = { screenshots: ManifestEntry[] };
|
||||
|
||||
/** Resolve the verdict floor for a screenshot via the manifest's engine tag. */
|
||||
export function floorFor(name: string, manifest?: Manifest): EngineFloor {
|
||||
const engine = manifest?.screenshots.find((e) => e.name === name)?.engine;
|
||||
return (engine && FLOORS[engine]) || FLOORS.default;
|
||||
/** Verdict floor for an engine-qualified key — the engine IS the key prefix now,
|
||||
* no manifest lookup needed. */
|
||||
export function floorFor(key: string): EngineFloor {
|
||||
return FLOORS[splitKey(key).engine] || FLOORS.default;
|
||||
}
|
||||
|
|
|
|||
Loading…
Reference in a new issue