e2e/CI: dual-engine suites, per-engine screenshots, SwiftShader retired, prod web suite, CI-coverage gate

Squash of experiment/ff-big-modules vs main.

Big-module routing removed: native-EH shrank kicad_editor below
SpiderMonkey's x86-64 code budget (runs 29355049705/29356152413 green on
stock Firefox), so BIG_MODULE_SPECS routing and the baseline-only-JIT
crutch are gone — kicad-firefox and kicad-chromium both run the full
suite, with the module compiled the way real users' browsers compile it.

Per-engine screenshots end to end: stableShot/shotPath write
test-results/<engine>/<name>.png; baselines move to
baseline-screenshots/{chromium,firefox}/ and the whole tools/screenshots
pipeline (compare/promote/manifest/spec-map/changelog/Discord) keys on
<engine>/<name>. Previously Firefox and Chromium renders of one spec
overwrote each other and Firefox renders were never actually gated.
Seeded from CI run 29421380806 (92 new firefox baselines, +24 chromium
web-suite shots); manifest generated from the baseline tree.

One merged playwright.config.ts (kicad/asyncify/coroutine/perf as
projects); ~25 dead npm scripts dropped. The web suite is gated in CI for
the first time ever (4 rotted specs fixed, 5 broken lib-bridge specs
triaged as fixme in docs/features/web-e2e-rot/); cheap lint step after
npm ci; last 26 blind-sleep violations fixed.

SwiftShader retired: CI Chromium renders WebGL on ANGLE → Mesa llvmpipe
(--use-gl=angle --use-angle=gl --ignore-gpu-blocklist; the blocklist flag
is mandatory — llvmpipe is blocklisted and WebGL is silently unavailable
without it) in BOTH configs. Under WORKERS=4 congestion SwiftShader
transiently failed the first post-board-load draw and the recovery
cascade ended in a silent permanent Cairo fallback — that engine flip was
the "~1.2% changedRatio both directions" occ-export baseline flake.
Validated 160/160 across two 80-repeat rigs; full analysis in
docs/features/wx-parity-bugs/occ-export-context-eviction.md. Chromium
baselines shift slightly on llvmpipe — promote once from the first green
run. Deflakes the new coverage exposed: presence baselines settle before
capture; presence fixtures declare current file formats; perf gets its
own outputDir so CI evidence survives; occ-export settles the board paint
before the export dialog; menu-item waits (waitForRenderedByLabel before
clickMenuItem) in 4 specs + the TESTING.md rule.

Web suite runs the PROD build, in parallel: webServer becomes backend
`start` + the standalone's e2e:preview (build-preview.mjs: link-wasm →
stash the public/wasm symlink aside during vite build, build-demo.mjs's
move — then vite preview as the persistent server). The wasm middleware
serves /wasm/* in preview and emits COOP/COEP/CORP itself (a pthread
worker script's own response must carry COEP or Chrome kills it with
ERR_BLOCKED_BY_RESPONSE). VITE_* flags bake at build time;
VITE_ALLOW_USER_OVERRIDE joins turbo globalEnv. fullyParallel + default
workers: 5.2m → 1.4m. Determinism fixes the parallel run exposed:
shared-page specs become serial groups; locks.spec grabs alice's exact
item via the new kicadCollabTestSelectByUuid hook (cross-tab "first
footprint" order is not a ysync invariant); quit specs poll page.url()
(quit supersedes its own navigation — NS_BINDING_ABORTED on Firefox).
Suite: 51 passed / 12 skipped / 0 failed in 1.6m.

CI-coverage gate (lint:ci-coverage): every tests/**/*.spec.ts must be
reachable from the npm scripts the workflows invoke — scraped from
.github/workflows/, resolved through package.json, coverage asked from
playwright --list itself. Rules: uncovered-spec + orphan-project (with a
documented LOCAL_ONLY_PROJECTS allowlist). Gating next to
lint:determinism; 138 spec files / 13 projects accounted for.

Product fixes kept from the investigations (reachable on real GPUs too):
wx 7799fd1be5 — paint flags clear before dispatch + Invalidate always
propagates; kicad 3dcfea5e45 — SwiftShader pass-boundary flush +
per-instance font texture + first-frame GL-error drain (GAL recovery
recovers instead of falling back to Cairo) + the user-facing eeschema
switch navigates again under __EMSCRIPTEN__ (project-sync's
FaceRegistered gate had rerouted it into the hidden sync player; caught
by the newly-gated web suite).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018eUxiPApHgGiu9NFyQfhAq

.github/workflows/screenshot-changelog.yml

@@ -12,7 +12,6 @@ on:
     branches: [main]
     paths:
       - 'tests/baseline-screenshots/**.png'
-      - 'tests/e2e/baseline-screenshots/**.png'
 
 concurrency:
   group: screenshot-changelog-${{ github.ref }}

.github/workflows/wasm-build.yml

@@ -372,6 +372,21 @@ jobs:
         working-directory: tests
         run: npm ci
 
+      # Cheap hygiene gates (no build needed): the determinism lint keeps the
+      # banned flake patterns out of the specs, the manifest check keeps
+      # screenshot-manifest.json in lockstep with the committed baselines
+      # (a stale manifest silently disables removed-screenshot detection), and
+      # the CI-coverage lint proves every spec file on disk is reachable from
+      # the npm scripts THIS workflow invokes (a spec/project that CI never
+      # runs is how the web suite once rotted unnoticed).
+      - name: Lint test determinism + screenshot manifest + CI coverage
+        if: inputs.run_tests
+        working-directory: tests
+        run: |
+          npm run lint:determinism
+          npm run screenshots:manifest -- --check
+          npm run lint:ci-coverage
+
       - name: Install web workspace deps (collab bundle)
         if: inputs.run_tests
         working-directory: web
@@ -413,37 +428,36 @@ jobs:
         working-directory: tests
         run: npm run setup:kicad
 
-      # The e2e suites run as separate steps so one suite's failure never skips
-      # the others — every suite still renders its screenshots, so the screenshot
-      # report below can show exactly what broke/went missing. A failing step
-      # still fails the JOB (no continue-on-error); the later steps run anyway
-      # via `!cancelled()` + "previous stage wasn't skipped" guards
-      # (steps.wx_e2e.outcome != 'skipped' ⇔ the build reached the tests — on a
-      # build failure everything below stays skipped, as before).
-      - name: wxWidgets e2e (npm run test:wx)
-        id: wx_e2e
+      # ONE merged Playwright invocation for every apps-server suite (wx,
+      # kicad×2 engines, asyncify, coroutine — see playwright.config.ts). One
+      # invocation = one start-of-run outputDir wipe BEFORE anything rendered,
+      # so the engine-scoped screenshots in test-results/{chromium,firefox}/
+      # accumulate naturally for the offline compare. A failure fails the JOB
+      # (no continue-on-error); the report below still runs and shows exactly
+      # what broke or went missing. xvfb: the Firefox projects run headed on CI
+      # (GPU-less VMs have no headless GL).
+      - name: e2e (npm run test:e2e — all suites, both engines)
+        id: e2e
         if: inputs.run_tests
         working-directory: tests
-        run: npm run test:wx
+        run: xvfb-run -a npm run test:e2e
 
-      - name: Asyncify e2e (npm run test:asyncify:firefox)
-        id: asyncify_e2e
-        if: inputs.run_tests && !cancelled() && steps.wx_e2e.outcome != 'skipped'
+      # The React web-app suite (web/) against the pnpm dev stack (frontend
+      # :3048 + backend :3060, cold-started by Playwright's webServer on CI).
+      # Runs even if the main e2e failed (`!cancelled()` + not-skipped guard) so
+      # its screenshots still reach the report.
+      - name: web e2e (npm run test:web:ci)
+        id: web_e2e
+        if: inputs.run_tests && !cancelled() && steps.e2e.outcome != 'skipped'
         working-directory: tests
-        run: npm run test:asyncify:firefox
-
-      - name: KiCad e2e (npm run test:kicad:ci)
-        id: kicad_e2e
-        if: inputs.run_tests && !cancelled() && steps.wx_e2e.outcome != 'skipped'
-        working-directory: tests
-        run: xvfb-run -a npm run test:kicad:ci
+        run: xvfb-run -a npm run test:web:ci
 
       # Runtime-perf E2E (eeschema + pcbnew): measures the current build's
       # load / open+render / FPS and writes tests/test-results/perf-*.json.
       # Track-only — never gates the build (continue-on-error). CI is
       # headless/SwiftShader so FPS is CPU-bound + noisy; openMs is the stable number.
       - name: KiCad runtime perf (track-only, non-gating)
-        if: inputs.run_tests && !cancelled() && steps.kicad_e2e.outcome != 'skipped'
+        if: inputs.run_tests && !cancelled() && steps.e2e.outcome != 'skipped'
         continue-on-error: true
         working-directory: tests
         run: xvfb-run -a npm run test:perf
@@ -458,7 +472,7 @@ jobs:
       # baseline-webgl/ and flip this step gating. 3d:review writes the full
       # 47-pair triptych gallery for the artifact upload below.
       - name: 3D renderer parity (report-only)
-        if: inputs.run_tests && !cancelled() && steps.wx_e2e.outcome != 'skipped'
+        if: inputs.run_tests && !cancelled() && steps.e2e.outcome != 'skipped'
         continue-on-error: true
         working-directory: tests
         run: |
@@ -479,7 +493,7 @@ jobs:
       # the already-produced test-results (screenshots + perf-*.json).
       - name: Screenshot report + perf
         id: report
-        if: inputs.run_tests && !cancelled() && steps.kicad_e2e.outcome != 'skipped'
+        if: inputs.run_tests && !cancelled() && steps.e2e.outcome != 'skipped'
         continue-on-error: true
         working-directory: tests
         env:
@@ -490,9 +504,8 @@ jobs:
         # without --fail-on-change; continue-on-error also shields transient Discord hiccups.
         run: |
           E2E=pass
-          { [ "${{ steps.wx_e2e.outcome }}" = "success" ] \
-            && [ "${{ steps.asyncify_e2e.outcome }}" = "success" ] \
-            && [ "${{ steps.kicad_e2e.outcome }}" = "success" ]; } || E2E=fail
+          { [ "${{ steps.e2e.outcome }}" = "success" ] \
+            && [ "${{ steps.web_e2e.outcome }}" = "success" ]; } || E2E=fail
           npm run screenshots:check
           npm run screenshots:report -- --e2e "$E2E"