AI_Assistant/pcbjam
Watch
1
0
Fork
You've already forked pcbjam
 0
Code Issues Pull requests Projects Releases 4 Packages Wiki Activity Actions 2

tests: eeschema-copy-paste — satisfy the determinism guard

Browse source 
CI's lint:determinism rejects blind waitForTimeout. Convert the chromium
clipboard-content read to expect.poll (the write lands after a JSPI
suspension) and annotate the remaining waits as documented interaction
dwells — select-all/paste/commit resolve inside the wx tool framework with
no page-observable, and the test's real gate is the FS-save poll.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Istvan Matejcsok 2026-08-26 12:16:57 +02:00
commit 4b92175c4e
1 changed files with 30 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

42
tests/kicad/eeschema-copy-paste.spec.ts
View file

@ -124,7 +124,9 @@ async function bootWithSchematic(page: import('@playwright/test').Page) {
// panels are wx widgets, so the click must land right of them // panels are wx widgets, so the click must land right of them
// (drawing area ≈ x 340-1250, y 90-660 at the 1280x720 viewport). // (drawing area ≈ x 340-1250, y 90-660 at the 1280x720 viewport).
await page.mouse.click(700, 400); await page.mouse.click(700, 400);
await page.waitForTimeout(500); // Interaction dwell: the click's focus handoff rides the wx scheduler with
// no page-observable; hotkeys sent too early land before the frame focuses.
await page.waitForTimeout(500); // dwell
} }
// The kicad projects run under devices['Desktop Chrome'/'Desktop Firefox'], // The kicad projects run under devices['Desktop Chrome'/'Desktop Firefox'],
@ -135,11 +137,15 @@ async function bootWithSchematic(page: import('@playwright/test').Page) {
// ignores (observed: 'a' alone opened the Place Symbol dialog). // ignores (observed: 'a' alone opened the Place Symbol dialog).
async function selectAllAndCopy(page: import('@playwright/test').Page) { async function selectAllAndCopy(page: import('@playwright/test').Page) {
await page.keyboard.press('Control+a'); await page.keyboard.press('Control+a');
await page.waitForTimeout(800); // Interaction dwell: select-all resolves inside the wx tool framework with
// no page-observable (the element registry doesn't expose selection).
await page.waitForTimeout(800); // dwell
await page.keyboard.press('Control+c'); await page.keyboard.press('Control+c');
// The clipboard write suspends via JSPI (browser round-trip, 2s timeout // Interaction dwell: the copy's clipboard write suspends via JSPI (browser
// budget inside wxClipboard) — give it room before acting on the result. // round-trip, 2 s timeout budget inside wxClipboard) and firefox offers no
await page.waitForTimeout(2500); // readText to poll; chromium callers re-verify via expect.poll on the
// clipboard content.
await page.waitForTimeout(2500); // dwell
} }
test.describe('Eeschema copy/paste', () => { test.describe('Eeschema copy/paste', () => {
@ -156,12 +162,18 @@ test.describe('Eeschema copy/paste', () => {
await selectAllAndCopy(page); await selectAllAndCopy(page);
const clip = await page.evaluate(() => navigator.clipboard.readText());
// eeschema's clipboard blob is the multi-form shape // eeschema's clipboard blob is the multi-form shape
// `(lib_symbols ...)\n(symbol ...)` (see pcbjam-shared items-wire.ts). // `(lib_symbols ...)\n(symbol ...)` (see pcbjam-shared items-wire.ts).
// The original bug left exactly "(" here (UTF-32 truncated at its // The original bug left exactly "(" here (UTF-32 truncated at its
// first NUL by the clipboard write helper). // first NUL by the clipboard write helper). Poll: the write lands
expect(clip).toMatch(/^\(lib_symbols/); // asynchronously after the JSPI suspension.
await expect
.poll(() => page.evaluate(() => navigator.clipboard.readText()), {
message: 'copied s-expression should reach navigator.clipboard in full',
timeout: 10000,
})
.toMatch(/^\(lib_symbols/);
const clip = await page.evaluate(() => navigator.clipboard.readText());
expect(clip).toContain('(symbol "Device:R"'); expect(clip).toContain('(symbol "Device:R"');
expect(clip).toContain('(lib_id "Device:R")'); expect(clip).toContain('(lib_id "Device:R")');
}); });
@ -173,17 +185,23 @@ test.describe('Eeschema copy/paste', () => {
await selectAllAndCopy(page); await selectAllAndCopy(page);
await page.keyboard.press('Escape'); await page.keyboard.press('Escape');
await page.waitForTimeout(300); // Interaction dwell: selection-clear has no page-observable.
await page.waitForTimeout(300); // dwell
// Paste attaches the items to the cursor; click commits the placement. // Paste attaches the items to the cursor; click commits the placement.
await page.mouse.move(500, 300); await page.mouse.move(500, 300);
await page.keyboard.press('Control+v'); await page.keyboard.press('Control+v');
await page.waitForTimeout(2500); // Interaction dwell: paste parses the clipboard (a JSPI-suspending
// read) and attaches the preview with no page-observable; the real
// gate is the FS-save poll below.
await page.waitForTimeout(2500); // dwell
await stableShot(page, 'eeschema-copy-paste-preview.png'); await stableShot(page, 'eeschema-copy-paste-preview.png');
await page.mouse.click(500, 300); await page.mouse.click(500, 300);
await page.waitForTimeout(800); // Interaction dwell: the placement commit has no page-observable.
await page.waitForTimeout(800); // dwell
await page.keyboard.press('Escape'); await page.keyboard.press('Escape');
await page.waitForTimeout(300); // Interaction dwell: exit-move-tool has no page-observable.
await page.waitForTimeout(300); // dwell
await page.keyboard.press('Control+s'); await page.keyboard.press('Control+s');