AI_Assistant/pcbjam
Watch
1
0
Fork
You've already forked pcbjam
 0
Code Issues Pull requests Projects Releases 7 Packages Wiki Activity Actions

Refactor test logging into shared utilities

Browse source 
- Extract common logging code to tests/e2e/utils/
  - fixtures.ts: Playwright fixture with automatic log capture
  - test-utils.ts: Logging utilities and helper functions
- Each test now automatically captures:
  - Console logs with timestamps and log levels
  - Page errors with full stack traces
- Log files written per test to tests/logs/
  - <test-name>.log for all console output
  - <test-name>.errors.log only when errors occur
- Update all 13 spec files to use shared fixtures
- Update README with test structure and logging docs
- Net reduction of ~700 lines by removing duplicated code

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Viktor Vaczi 2025-11-29 20:54:54 +01:00
commit 26181bb929
16 changed files with 431 additions and 1131 deletions
Download patch file Download diff file Expand all files Collapse all files

79
tests/e2e/dialog.spec.ts
View file

@ -1,45 +1,21 @@
import { test, expect, Page } from '@playwright/test';
const MAIN_CANVAS = '#canvas';
async function tryLoadApp(page: Page, timeout = 15000) {
try {
await page.waitForSelector(MAIN_CANVAS, { state: 'visible', timeout });
await page.waitForTimeout(500);
return true;
} catch {
return false;
}
}
import { test, expect, MAIN_CANVAS, tryLoadApp, getCanvasBox } from './utils/fixtures';
test.describe('wxDialog/wxMessageBox Tests', () => {
test('Dialog test app loads successfully', async ({ page }) => {
const consoleLogs: string[] = [];
const pageErrors: string[] = [];
page.on('console', msg => consoleLogs.push(msg.text()));
page.on('pageerror', err => pageErrors.push(err.message));
test('Dialog test app loads successfully', async ({ page, testLogger }) => {
await page.goto('/standalone/dialog/dialog_test.html');
const loaded = await tryLoadApp(page);
await page.screenshot({ path: 'test-results/dialog-01-loaded.png', fullPage: true });
const hasStartupLog = consoleLogs.some(log =>
const hasStartupLog = testLogger.consoleLogs.some(log =>
log.includes('DIALOG_TEST') && log.includes('started successfully')
);
console.log('Dialog app logs:', consoleLogs.filter(l => l.includes('DIALOG')));
console.log('Dialog app loaded:', hasStartupLog);
expect(loaded, 'Canvas should be visible').toBe(true);
expect(pageErrors.filter(e => !e.includes('favicon'))).toHaveLength(0);
expect(testLogger.errors.filter(e => !e.includes('favicon'))).toHaveLength(0);
});
test('Info dialog button can be clicked', async ({ page }) => {
const consoleLogs: string[] = [];
page.on('console', msg => consoleLogs.push(msg.text()));
test('Info dialog button can be clicked', async ({ page, testLogger }) => {
await page.goto('/standalone/dialog/dialog_test.html');
const loaded = await tryLoadApp(page);
if (!loaded) {
@ -47,32 +23,23 @@ test.describe('wxDialog/wxMessageBox Tests', () => {
return;
}
const canvas = page.locator(MAIN_CANVAS);
const box = await canvas.boundingBox();
if (!box) throw new Error('Canvas not found');
const box = await getCanvasBox(page);
// Info Dialog button is first in the wxMessageBox row
// Layout: description (~80px) + fieldset header + buttons
// Buttons are centered horizontally in 3-button row
// Estimate: first button at ~(centerX - 120), y ~115
const centerX = box.width / 2;
await page.mouse.click(box.x + centerX - 110, box.y + 115);
await page.waitForTimeout(500);
console.log('Info dialog logs:', consoleLogs.filter(l => l.includes('DIALOG')));
await page.screenshot({ path: 'test-results/dialog-02-info-clicked.png', fullPage: true });
const hasInfoEvent = consoleLogs.some(log =>
const hasInfoEvent = testLogger.consoleLogs.some(log =>
log.includes('Opening Info dialog')
);
expect(hasInfoEvent, 'Info dialog should open').toBe(true);
});
test('Yes/No dialog button can be clicked', async ({ page }) => {
const consoleLogs: string[] = [];
page.on('console', msg => consoleLogs.push(msg.text()));
test('Yes/No dialog button can be clicked', async ({ page, testLogger }) => {
await page.goto('/standalone/dialog/dialog_test.html');
const loaded = await tryLoadApp(page);
if (!loaded) {
@ -80,28 +47,22 @@ test.describe('wxDialog/wxMessageBox Tests', () => {
return;
}
const canvas = page.locator(MAIN_CANVAS);
const box = await canvas.boundingBox();
if (!box) throw new Error('Canvas not found');
const box = await getCanvasBox(page);
// Yes/No Dialog button is second (center) in the wxMessageBox row
const centerX = box.width / 2;
await page.mouse.click(box.x + centerX, box.y + 115);
await page.waitForTimeout(500);
console.log('Yes/No dialog logs:', consoleLogs.filter(l => l.includes('DIALOG')));
await page.screenshot({ path: 'test-results/dialog-03-yesno-clicked.png', fullPage: true });
const hasYesNoEvent = consoleLogs.some(log =>
const hasYesNoEvent = testLogger.consoleLogs.some(log =>
log.includes('Opening Yes/No dialog')
);
expect(hasYesNoEvent, 'Yes/No dialog should open').toBe(true);
});
test('Error dialog button can be clicked', async ({ page }) => {
const consoleLogs: string[] = [];
page.on('console', msg => consoleLogs.push(msg.text()));
test('Error dialog button can be clicked', async ({ page, testLogger }) => {
await page.goto('/standalone/dialog/dialog_test.html');
const loaded = await tryLoadApp(page);
if (!loaded) {
@ -109,28 +70,22 @@ test.describe('wxDialog/wxMessageBox Tests', () => {
return;
}
const canvas = page.locator(MAIN_CANVAS);
const box = await canvas.boundingBox();
if (!box) throw new Error('Canvas not found');
const box = await getCanvasBox(page);
// Error Dialog button is third (rightmost) in the wxMessageBox row
const centerX = box.width / 2;
await page.mouse.click(box.x + centerX + 110, box.y + 115);
await page.waitForTimeout(500);
console.log('Error dialog logs:', consoleLogs.filter(l => l.includes('DIALOG')));
await page.screenshot({ path: 'test-results/dialog-04-error-clicked.png', fullPage: true });
const hasErrorEvent = consoleLogs.some(log =>
const hasErrorEvent = testLogger.consoleLogs.some(log =>
log.includes('Opening Error dialog')
);
expect(hasErrorEvent, 'Error dialog should open').toBe(true);
});
test('Custom dialog button can be clicked', async ({ page }) => {
const consoleLogs: string[] = [];
page.on('console', msg => consoleLogs.push(msg.text()));
test('Custom dialog button can be clicked', async ({ page, testLogger }) => {
await page.goto('/standalone/dialog/dialog_test.html');
const loaded = await tryLoadApp(page);
if (!loaded) {
@ -138,17 +93,13 @@ test.describe('wxDialog/wxMessageBox Tests', () => {
return;
}
const canvas = page.locator(MAIN_CANVAS);
const box = await canvas.boundingBox();
if (!box) throw new Error('Canvas not found');
const box = await getCanvasBox(page);
// Custom Dialog button is first in the wxDialog row (row 2)
// Y position is lower (~175) since it's in the second fieldset
const centerX = box.width / 2;
await page.mouse.click(box.x + centerX - 60, box.y + 175);
await page.waitForTimeout(500);
console.log('Custom dialog logs:', consoleLogs.filter(l => l.includes('DIALOG')));
await page.screenshot({ path: 'test-results/dialog-05-custom-clicked.png', fullPage: true });
expect(true).toBe(true);