AI_Assistant/pcbjam
Watch
1
0
Fork
You've already forked pcbjam
 0
Code Issues Pull requests Projects Releases 7 Packages Wiki Activity Actions

Clean up test infrastructure and fix test assertions

Browse source 
- Replace test.skip() with proper expect() assertions when app fails to load
- Remove button-finder utility (no longer needed with element registry)
- Remove kicad tests (tested separately)
- Add findByName/clickByName helpers for bitmap buttons
- Fix element lookups: use clickByName for bitmap buttons, clickTreeItem
  for treebook pages, selectComboItem for wxChoice items
- Add SetName() to shape buttons in bitmapbuttons_test.cpp
- Remove verbose logging from print and threadpool tests
- Update README to reflect current test infrastructure

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Viktor Vaczi 2026-01-01 20:18:19 +01:00
commit 251056e506
42 changed files with 241 additions and 1138 deletions
Download patch file Download diff file Expand all files Collapse all files

25
tests/e2e/validators.spec.ts
View file

@ -16,10 +16,7 @@ test.describe('wxValidator Tests', () => {
test('Text validator input exists', async ({ page, testLogger }) => {
await page.goto('/standalone/validators/validators_test.html');
const loaded = await tryLoadApp(page);
if (!loaded) {
test.skip();
return;
}
expect(loaded, 'App should load').toBe(true);
await page.waitForTimeout(500);
await page.screenshot({ path: 'test-results/validators-02-text.png', fullPage: true });
@ -31,10 +28,7 @@ test.describe('wxValidator Tests', () => {
test('Integer validator input exists', async ({ page, testLogger }) => {
await page.goto('/standalone/validators/validators_test.html');
const loaded = await tryLoadApp(page);
if (!loaded) {
test.skip();
return;
}
expect(loaded, 'App should load').toBe(true);
await page.waitForTimeout(500);
await page.screenshot({ path: 'test-results/validators-03-integer.png', fullPage: true });
@ -45,10 +39,7 @@ test.describe('wxValidator Tests', () => {
test('Floating point validator input exists', async ({ page, testLogger }) => {
await page.goto('/standalone/validators/validators_test.html');
const loaded = await tryLoadApp(page);
if (!loaded) {
test.skip();
return;
}
expect(loaded, 'App should load').toBe(true);
await page.waitForTimeout(500);
await page.screenshot({ path: 'test-results/validators-04-float.png', fullPage: true });
@ -59,10 +50,7 @@ test.describe('wxValidator Tests', () => {
test('Custom net name validator input exists', async ({ page, testLogger }) => {
await page.goto('/standalone/validators/validators_test.html');
const loaded = await tryLoadApp(page);
if (!loaded) {
test.skip();
return;
}
expect(loaded, 'App should load').toBe(true);
await page.waitForTimeout(500);
await page.screenshot({ path: 'test-results/validators-05-netname.png', fullPage: true });
@ -73,10 +61,7 @@ test.describe('wxValidator Tests', () => {
test('Validate all button exists', async ({ page, testLogger }) => {
await page.goto('/standalone/validators/validators_test.html');
const loaded = await tryLoadApp(page);
if (!loaded) {
test.skip();
return;
}
expect(loaded, 'App should load').toBe(true);
await page.waitForTimeout(500);
await page.screenshot({ path: 'test-results/validators-06-button.png', fullPage: true });