AI_Assistant/pcbjam
Watch
1
0
Fork
You've already forked pcbjam
 0
Code Issues Pull requests Projects Releases 7 Packages Wiki Activity Actions

Clean up test infrastructure and fix test assertions

Browse source 
- Replace test.skip() with proper expect() assertions when app fails to load
- Remove button-finder utility (no longer needed with element registry)
- Remove kicad tests (tested separately)
- Add findByName/clickByName helpers for bitmap buttons
- Fix element lookups: use clickByName for bitmap buttons, clickTreeItem
  for treebook pages, selectComboItem for wxChoice items
- Add SetName() to shape buttons in bitmapbuttons_test.cpp
- Remove verbose logging from print and threadpool tests
- Update README to reflect current test infrastructure

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Viktor Vaczi 2026-01-01 20:18:19 +01:00
commit 251056e506
42 changed files with 241 additions and 1138 deletions
Download patch file Download diff file Expand all files Collapse all files

30
tests/e2e/toolbar.spec.ts
View file

@ -19,10 +19,7 @@ test.describe('wxToolBar & wxStatusBar Tests', () => {
test('Toolbar buttons are visible', async ({ page, testLogger }) => {
await page.goto('/standalone/toolbar/toolbar_test.html');
const loaded = await tryLoadApp(page);
if (!loaded) {
test.skip();
return;
}
expect(loaded, 'App should load').toBe(true);
await page.screenshot({ path: 'test-results/toolbar-02-buttons.png', fullPage: true });
@ -34,10 +31,7 @@ test.describe('wxToolBar & wxStatusBar Tests', () => {
test('New tool button can be clicked', async ({ page, testLogger }) => {
await page.goto('/standalone/toolbar/toolbar_test.html');
const loaded = await tryLoadApp(page);
if (!loaded) {
test.skip();
return;
}
expect(loaded, 'App should load').toBe(true);
// Click New button using element registry
const clicked = await clickToolbarTool(page, 'New');
@ -50,10 +44,7 @@ test.describe('wxToolBar & wxStatusBar Tests', () => {
test('Zoom tools can be clicked', async ({ page, testLogger }) => {
await page.goto('/standalone/toolbar/toolbar_test.html');
const loaded = await tryLoadApp(page);
if (!loaded) {
test.skip();
return;
}
expect(loaded, 'App should load').toBe(true);
// Click Zoom In using element registry
const zoomInClicked = await clickToolbarTool(page, 'Zoom In');
@ -71,10 +62,7 @@ test.describe('wxToolBar & wxStatusBar Tests', () => {
test('Toggle tool changes state', async ({ page, testLogger }) => {
await page.goto('/standalone/toolbar/toolbar_test.html');
const loaded = await tryLoadApp(page);
if (!loaded) {
test.skip();
return;
}
expect(loaded, 'App should load').toBe(true);
// Click Toggle button using element registry
const toggleClicked1 = await clickToolbarTool(page, 'Toggle');
@ -94,10 +82,7 @@ test.describe('wxToolBar & wxStatusBar Tests', () => {
test('Status bar shows messages', async ({ page, testLogger }) => {
await page.goto('/standalone/toolbar/toolbar_test.html');
const loaded = await tryLoadApp(page);
if (!loaded) {
test.skip();
return;
}
expect(loaded, 'App should load').toBe(true);
await page.screenshot({ path: 'test-results/toolbar-07-statusbar.png', fullPage: true });
@ -109,10 +94,7 @@ test.describe('wxToolBar & wxStatusBar Tests', () => {
test('All toolbar buttons accessible', async ({ page, testLogger }) => {
await page.goto('/standalone/toolbar/toolbar_test.html');
const loaded = await tryLoadApp(page);
if (!loaded) {
test.skip();
return;
}
expect(loaded, 'App should load').toBe(true);
// Verify all tools are registered
const tools = await findRenderedByType(page, 'tool');