AI_Assistant/pcbjam
Watch
1
0
Fork
You've already forked pcbjam
 0
Code Issues Pull requests Projects Releases 7 Packages Wiki Activity Actions

Clean up test infrastructure and fix test assertions

Browse source 
- Replace test.skip() with proper expect() assertions when app fails to load
- Remove button-finder utility (no longer needed with element registry)
- Remove kicad tests (tested separately)
- Add findByName/clickByName helpers for bitmap buttons
- Fix element lookups: use clickByName for bitmap buttons, clickTreeItem
  for treebook pages, selectComboItem for wxChoice items
- Add SetName() to shape buttons in bitmapbuttons_test.cpp
- Remove verbose logging from print and threadpool tests
- Update README to reflect current test infrastructure

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Viktor Vaczi 2026-01-01 20:18:19 +01:00
commit 251056e506
42 changed files with 241 additions and 1138 deletions
Download patch file Download diff file Expand all files Collapse all files

75
tests/e2e/dnd.spec.ts
View file

@ -21,10 +21,7 @@ test.describe('wxDragDrop Tests', () => {
test('DnD handlers are registered', async ({ page, testLogger }) => {
await page.goto('/standalone/dnd/dnd_test.html');
const loaded = await tryLoadApp(page);
if (!loaded) {
test.skip();
return;
}
expect(loaded, 'App should load').toBe(true);
await page.screenshot({ path: 'test-results/dnd-02-handlers.png', fullPage: true });
@ -37,17 +34,11 @@ test.describe('wxDragDrop Tests', () => {
test('DragEnter event is detected', async ({ page, testLogger }) => {
await page.goto('/standalone/dnd/dnd_test.html');
const loaded = await tryLoadApp(page);
if (!loaded) {
test.skip();
return;
}
expect(loaded, 'App should load').toBe(true);
const canvas = page.locator('#canvas');
const box = await canvas.boundingBox();
if (!box) {
test.skip();
return;
}
expect(box, 'Canvas should have bounding box').not.toBeNull();
// Simulate dragenter event
await page.evaluate(({ x, y }) => {
@ -74,17 +65,11 @@ test.describe('wxDragDrop Tests', () => {
test('DragLeave event is detected', async ({ page, testLogger }) => {
await page.goto('/standalone/dnd/dnd_test.html');
const loaded = await tryLoadApp(page);
if (!loaded) {
test.skip();
return;
}
expect(loaded, 'App should load').toBe(true);
const canvas = page.locator('#canvas');
const box = await canvas.boundingBox();
if (!box) {
test.skip();
return;
}
expect(box, 'Canvas should have bounding box').not.toBeNull();
// Simulate dragenter then dragleave
await page.evaluate(({ x, y }) => {
@ -118,17 +103,11 @@ test.describe('wxDragDrop Tests', () => {
test('Drop event triggers file processing', async ({ page, testLogger }) => {
await page.goto('/standalone/dnd/dnd_test.html');
const loaded = await tryLoadApp(page);
if (!loaded) {
test.skip();
return;
}
expect(loaded, 'App should load').toBe(true);
const canvas = page.locator('#canvas');
const box = await canvas.boundingBox();
if (!box) {
test.skip();
return;
}
expect(box, 'Canvas should have bounding box').not.toBeNull();
// Create a test file and simulate drop
const testContent = 'Test file content for DnD';
@ -163,17 +142,11 @@ test.describe('wxDragDrop Tests', () => {
test('Dropped file is written to WASM filesystem', async ({ page, testLogger }) => {
await page.goto('/standalone/dnd/dnd_test.html');
const loaded = await tryLoadApp(page);
if (!loaded) {
test.skip();
return;
}
expect(loaded, 'App should load').toBe(true);
const canvas = page.locator('#canvas');
const box = await canvas.boundingBox();
if (!box) {
test.skip();
return;
}
expect(box, 'Canvas should have bounding box').not.toBeNull();
const testFileName = 'wasm-test-file.txt';
const testContent = 'Content written via DnD';
@ -208,17 +181,11 @@ test.describe('wxDragDrop Tests', () => {
test('wxDropFilesEvent is fired after drop', async ({ page, testLogger }) => {
await page.goto('/standalone/dnd/dnd_test.html');
const loaded = await tryLoadApp(page);
if (!loaded) {
test.skip();
return;
}
expect(loaded, 'App should load').toBe(true);
const canvas = page.locator('#canvas');
const box = await canvas.boundingBox();
if (!box) {
test.skip();
return;
}
expect(box, 'Canvas should have bounding box').not.toBeNull();
const testFileName = 'event-test.kicad_pcb';
const testContent = '(kicad_pcb (version 20230121))';
@ -255,17 +222,11 @@ test.describe('wxDragDrop Tests', () => {
test('Multiple files can be dropped', async ({ page, testLogger }) => {
await page.goto('/standalone/dnd/dnd_test.html');
const loaded = await tryLoadApp(page);
if (!loaded) {
test.skip();
return;
}
expect(loaded, 'App should load').toBe(true);
const canvas = page.locator('#canvas');
const box = await canvas.boundingBox();
if (!box) {
test.skip();
return;
}
expect(box, 'Canvas should have bounding box').not.toBeNull();
await page.evaluate(({ x, y }) => {
const canvas = document.getElementById('canvas');
@ -300,18 +261,12 @@ test.describe('wxDragDrop Tests', () => {
test('Clear files button exists in UI', async ({ page, testLogger }) => {
await page.goto('/standalone/dnd/dnd_test.html');
const loaded = await tryLoadApp(page);
if (!loaded) {
test.skip();
return;
}
expect(loaded, 'App should load').toBe(true);
// First drop a file to verify drop works
const canvas = page.locator('#canvas');
const box = await canvas.boundingBox();
if (!box) {
test.skip();
return;
}
expect(box, 'Canvas should have bounding box').not.toBeNull();
await page.evaluate(({ x, y }) => {
const canvas = document.getElementById('canvas');